Skip to content

Commit bd97f91

Browse files
authored
Merge pull request #3150 from PiyushChandra17/piyush/fix-edit-rename-using-keyboard
Fix edit rename using keyboard controls on SketchList && CollectionList
2 parents 99b9463 + d0a49b9 commit bd97f91

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

client/modules/IDE/components/CollectionList/CollectionListRow.jsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ const CollectionListRowBase = (props) => {
140140

141141
const handleRenameEnter = (e) => {
142142
if (e.key === 'Enter') {
143+
e.preventDefault();
143144
updateName();
144145
closeAll();
145146
}
@@ -187,7 +188,7 @@ const CollectionListRowBase = (props) => {
187188
<input
188189
value={renameValue}
189190
onChange={handleRenameChange}
190-
onKeyUp={handleRenameEnter}
191+
onKeyDown={handleRenameEnter}
191192
onBlur={handleRenameBlur}
192193
onClick={(e) => e.stopPropagation()}
193194
ref={renameInput}

client/modules/IDE/components/SketchList.jsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ class SketchListRowBase extends React.Component {
6464

6565
handleRenameEnter = (e) => {
6666
if (e.key === 'Enter') {
67+
e.preventDefault();
6768
this.updateName();
6869
this.closeRename();
6970
}
@@ -173,7 +174,7 @@ class SketchListRowBase extends React.Component {
173174
<input
174175
value={renameValue}
175176
onChange={this.handleRenameChange}
176-
onKeyUp={this.handleRenameEnter}
177+
onKeyDown={this.handleRenameEnter}
177178
onBlur={this.handleRenameBlur}
178179
onClick={(e) => e.stopPropagation()}
179180
ref={this.renameInput}

0 commit comments

Comments
 (0)