Review remarks for #172

Author: mlitwiniuk

app/controllers/lit/localization_keys_controller.rb

@@ -116,15 +116,12 @@ def localization_for(locale, localization_key)
       @_localization_for ||= {}
       key = [locale, localization_key]
       ret = @_localization_for[key]
-      binding.pry if localization_key == 'scopes.string'
       if ret == false
         nil
       elsif ret.nil?
         ret = grouped_localizations[localization_key][locale]
         unless ret
-          ::Rails.logger.info "******** REFRESHING the key"
           Lit.init.cache.refresh_key("#{locale}.#{localization_key.localization_key}")
-          ::Rails.logger.info "******** FETCHING the key"
           ret = localization_key.localizations.where(locale_id: Lit.init.cache.find_locale(locale).id).first
         end
         @_localization_for[key] = ret ? ret : false

app/views/lit/localization_keys/_localizations_list.html.erb

@@ -46,7 +46,7 @@
                 <td>
                   <% if localization %>
                     <%= draw_icon 'clock-o', title: "Last updated at #{localization.updated_at.to_s(:db)}" %>
-                    <%= link_to lit.previous_versions_localization_key_localization_path(lk, localization, format: :js), class: "show_prev_versions #{'hidden' unless versions?(localization)}", remote: true do %>
+                    <%= link_to lit.previous_versions_localization_key_localization_path(lk, localization, format: :js), class: "js-show_prev_versions #{'hidden' unless versions?(localization)}", remote: true do %>
                       <%= draw_icon 'random', title: I18n.t('lit.common.previous_versions', default: 'Previous versions') %>
                     <% end %>
                   <% end %>

app/views/lit/localizations/update.js.erb

@@ -1,6 +1,6 @@
 var $row = $('td.localization_row[data-id="<%= @localization.id %>"]');
 $row.data('editing', 0);
 $row.html("<%= ejs render(:partial=>"/lit/localization_keys/localization_row", formats: ['html'], :locals=>{:localization=>@localization.translated_value }) %>");
-$row.siblings().find('.show_prev_versions').removeClass('hidden');
+$row.siblings().find('.js-show_prev_versions').removeClass('hidden');
 $('a.change_completed_<%= @localization.id %> input[type=checkbox]').prop("checked", true);
 

test/functional/lit/localization_keys_controller_test.rb

@@ -77,8 +77,8 @@ class LocalizationKeysControllerTest < ActionController::TestCase
       v.update_column :updated_at, 1.day.ago
       a.update_column :updated_at, 1.day.ago
       post :batch_touch, params: { key: 'value' }, format: :js
-      assert v.reload.updated_at > 1.second.ago
-      assert a.reload.updated_at < 23.hours.ago
+      assert_in_delta(v.reload.updated_at, 1.second.ago, 5)
+      assert_in_delta(a.reload.updated_at, 1.day.ago, 5)
     end
 
     test 'wont fail when there wont be any search results when touching in batch' do