Merge pull request #2 from rafaltrojanowski/feat-option

add option for dont mark first record as default

Author: mlitwiniuk

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    primary (0.0.1)
+    primary (0.0.2)
       rails (>= 3.0.0)
 
 GEM
@@ -34,7 +34,7 @@ GEM
     activesupport (3.2.6)
       i18n (~> 0.6)
       multi_json (~> 1.0)
-    arel (3.0.2)
+    arel (3.0.3)
     builder (3.0.0)
     diff-lcs (1.1.3)
     erubis (2.7.0)
@@ -51,9 +51,9 @@ GEM
       i18n (>= 0.4.0)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
-    mime-types (1.19)
+    mime-types (1.25.1)
     multi_json (1.3.6)
-    polyglot (0.3.3)
+    polyglot (0.3.5)
     rack (1.4.1)
     rack-cache (1.2)
       rack (>= 0.4)
@@ -99,10 +99,10 @@ GEM
     sqlite3 (1.3.6)
     thor (0.15.3)
     tilt (1.3.3)
-    treetop (1.4.10)
+    treetop (1.4.15)
       polyglot
       polyglot (>= 0.3.1)
-    tzinfo (0.3.33)
+    tzinfo (0.3.42)
 
 PLATFORMS
   ruby

README.md

@@ -53,6 +53,8 @@ is_primary :on=>'is_default', :scope=>'site_id'
                           # Scope can be defined as array of params
 :scope => ['site_id', 'language_code']
 :scope => ['polymorphic_id', 'polymorphic_type']
+:auto_primary_record => false   # if you don't want primary record
+                                # to be set automatically (default: true)
 ```
 
 ##Requirements

lib/primary.rb

@@ -2,8 +2,9 @@ module Primary
   def is_primary options={}
     cattr_accessor :primary_is_primary_opts
     self.primary_is_primary_opts = options.reverse_merge({
-      :on     => :is_primary,
-      :scope  => nil
+      :on                  => :is_primary,
+      :scope               => nil,
+      :auto_primary_record => true
     })
 
     before_save :primary_is_primary_mark
@@ -14,6 +15,8 @@ module InstanceMethods
     private
       def primary_is_primary_mark
         options = self.class.primary_is_primary_opts
+        return unless !!options[:auto_primary_record]
+
         check = get_primary_scope(options)
         if check.count == 0
           self.send("#{options[:on]}=", true)
@@ -35,7 +38,7 @@ def get_primary_scope(options)
           if sc.is_a?(Symbol) or sc.is_a?(String)
             check = build_primary_scope(check, sc)
           elsif sc.is_a?(Array)
-            sc.each do |scope_elem| 
+            sc.each do |scope_elem|
               check = build_primary_scope(check, scope_elem)
             end
           end

spec/dummy/app/models/background.rb

@@ -0,0 +1,5 @@
+class Background < ActiveRecord::Base
+  is_primary auto_primary_record: false
+
+  attr_accessible :is_primary, :url
+end

spec/dummy/db/migrate/20141126165902_create_backgrounds.rb

@@ -0,0 +1,10 @@
+class CreateBackgrounds < ActiveRecord::Migration
+  def change
+    create_table :backgrounds do |t|
+      t.string :url
+      t.boolean :is_primary
+
+      t.timestamps
+    end
+  end
+end

spec/dummy/db/schema.rb

@@ -11,7 +11,14 @@
 #
 # It's strongly recommended to check this file into your version control system.
 
-ActiveRecord::Schema.define(:version => 20120708132456) do
+ActiveRecord::Schema.define(:version => 20141126165902) do
+
+  create_table "backgrounds", :force => true do |t|
+    t.string   "url"
+    t.boolean  "is_primary"
+    t.datetime "created_at", :null => false
+    t.datetime "updated_at", :null => false
+  end
 
   create_table "domains", :force => true do |t|
     t.integer  "site_id"

spec/factories/common.rb

@@ -9,8 +9,12 @@
     sequence(:domain){|n| "test_domain_#{n}.test"}
     is_primary false
   end
+
   factory :photo do
     is_primary false
   end
 
+  factory :background do
+    is_primary false
+  end
 end

spec/models/background_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe Background do
+
+  context 'auto_primary_record is false' do
+    it "should not be marked as default if it's first record" do
+      background = FactoryGirl.build(:background)
+      background.save
+      background.is_primary.should == false
+    end
+
+    it "should not be marked as default out of the box" do
+      background_1 = FactoryGirl.build(:background)
+      background_2 = FactoryGirl.build(:background)
+
+      [background_1, background_2].map(&:save)
+
+      background_1.is_primary.should == false
+      background_2.is_primary.should == false
+    end
+
+    it "should make sure, that there is only one default record" do
+      backgrounds = FactoryGirl.create_list(:background, 3)
+      Background.update_all(is_primary: true)
+
+      first_background = Background.first
+      first_background.is_primary = true
+      first_background.save
+
+      Background.where(is_primary: true).should == [first_background]
+    end
+  end
+end