Skip to content

Commit 6870901

Browse files
Merge pull request #119 from z103cb/z103cb/issue118
Upgrade to MCAD v1.33.0
2 parents 58282c6 + f73ca2e commit 6870901

File tree

4 files changed

+14
-93
lines changed

4 files changed

+14
-93
lines changed

controllers/appWrapper_controller_test.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
package controllers
22

33
import (
4+
"testing"
5+
46
"github.com/onsi/gomega"
57
arbv1 "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/apis/controller/v1beta1"
68
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
7-
"testing"
89
)
910

1011
func TestDiscoverInstanceTypes(t *testing.T) {
@@ -36,7 +37,6 @@ func TestDiscoverInstanceTypes(t *testing.T) {
3637
Replicas: 2,
3738
},
3839
},
39-
TypeMeta: metav1.TypeMeta{},
4040
},
4141
},
4242
},
@@ -64,7 +64,6 @@ func TestDiscoverInstanceTypes(t *testing.T) {
6464
Replicas: 1,
6565
},
6666
},
67-
TypeMeta: metav1.TypeMeta{},
6867
},
6968
},
7069
},

controllers/appwrapper_controller.go

+9-6
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,13 @@ import (
2626
mapiclientset "github.com/openshift/client-go/machine/clientset/versioned"
2727
machineinformersv1beta1 "github.com/openshift/client-go/machine/informers/externalversions"
2828
"github.com/openshift/client-go/machine/listers/machine/v1beta1"
29+
30+
appwrapperClientSet "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/client/clientset/versioned"
31+
2932
arbv1 "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/apis/controller/v1beta1"
30-
"github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/client/clientset/controller-versioned/clients"
31-
arbinformers "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/client/informers/controller-externalversion"
32-
v1 "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/client/listers/controller/v1"
33+
appwrapperlisters "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/client/listers/controller/v1beta1"
34+
35+
arbinformersFactory "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/client/informers/externalversions"
3336
apierrors "k8s.io/apimachinery/pkg/api/errors"
3437
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3538
"k8s.io/apimachinery/pkg/labels"
@@ -62,7 +65,7 @@ var (
6265
machineLister v1beta1.MachineLister
6366
msInformerHasSynced bool
6467
machineClient mapiclientset.Interface
65-
queueJobLister v1.AppWrapperLister
68+
queueJobLister appwrapperlisters.AppWrapperLister
6669
kubeClient *kubernetes.Clientset
6770
)
6871

@@ -199,11 +202,11 @@ func addAppwrappersThatNeedScaling() {
199202
if err != nil {
200203
klog.Fatalf("Error getting config: %v", err)
201204
}
202-
awJobClient, _, err := clients.NewClient(restConfig)
205+
awJobClient, err := appwrapperClientSet.NewForConfig(restConfig)
203206
if err != nil {
204207
klog.Fatalf("Error creating client: %v", err)
205208
}
206-
queueJobInformer := arbinformers.NewSharedInformerFactory(awJobClient, 0).AppWrapper().AppWrappers()
209+
queueJobInformer := arbinformersFactory.NewSharedInformerFactory(awJobClient, 0).Mcad().V1beta1().AppWrappers()
207210
queueJobInformer.Informer().AddEventHandler(
208211
cache.FilteringResourceEventHandler{
209212
FilterFunc: func(obj interface{}) bool {

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ require (
77
github.com/openshift-online/ocm-sdk-go v0.1.327
88
github.com/openshift/api v0.0.0-20220411210816-c3bb724c282a
99
github.com/openshift/client-go v0.0.0-20211209144617-7385dd6338e3
10-
github.com/project-codeflare/multi-cluster-app-dispatcher v1.32.0
10+
github.com/project-codeflare/multi-cluster-app-dispatcher v1.33.0
1111
k8s.io/api v0.23.0
1212
k8s.io/apimachinery v0.23.0
1313
k8s.io/client-go v0.23.0

0 commit comments

Comments
 (0)