Allow connect on Http2ProtocolOptions when Websockets are enabled

rajatvig · rajatvig · commit 98bfa4197850 · 2025-01-12T01:00:40.000Z
Signed-off-by: Rajat Vig &lt;rvig@etsy.com&gt;
diff --git a/changelogs/unreleased/6846-rvig-small.md b/changelogs/unreleased/6846-rvig-small.md
@@ -0,0 +1 @@
+Set `allow_connect` to true on `Http2ProtocolOptions` on the Listener when websockets are enabled.
diff --git a/internal/envoy/v3/listener.go b/internal/envoy/v3/listener.go
@@ -568,6 +568,7 @@ func (b *httpConnectionManagerBuilder) Get() *envoy_config_listener_v3.Filter {
 				UpgradeType: "websocket",
 			},
 		)
+		cm.Http2ProtocolOptions.AllowConnect = true
 	}
 
 	return &envoy_config_listener_v3.Filter{

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Set `allow_connect` to true on `Http2ProtocolOptions` on the Listener when websockets are enabled.
Original file line number	Diff line number	Diff line change
`@@ -568,6 +568,7 @@ func (b httpConnectionManagerBuilder) Get() envoy_config_listener_v3.Filter {`
`568`	`568`	`UpgradeType: "websocket",`
`569`	`569`	`},`
`570`	`570`	`)`
	`571`	`+ cm.Http2ProtocolOptions.AllowConnect = true`
`571`	`572`	`}`
`572`	`573`
`573`	`574`	`return &envoy_config_listener_v3.Filter{`