Use labels pattern

Sticksman · Sticksman · commit 1ac773ad8de0 · 2023-06-26T12:39:12.000-07:00
Signed-off-by: Felix Yuan &lt;felix.yuan@reddit.com&gt;
diff --git a/collector/pg_index_size.go b/collector/pg_index_size.go
@@ -86,6 +86,7 @@ func (PGIndexSizeCollector) Update(ctx context.Context, instance *instance, ch c
 		if indexrelname.Valid {
 			indexrelnameLabel = indexrelname.String
 		}
+		labels := []string{schemanameLabel, relnameLabel, indexrelnameLabel}
 
 		indexSizeMetric := 0.0
 		if indexSize.Valid {
@@ -95,7 +96,7 @@ func (PGIndexSizeCollector) Update(ctx context.Context, instance *instance, ch c
 			indexSizeDesc,
 			prometheus.GaugeValue,
 			indexSizeMetric,
-			schemanameLabel, relnameLabel, indexrelnameLabel,
+			labels...,
 		)
 	}
 	if err := rows.Err(); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ func (PGIndexSizeCollector) Update(ctx context.Context, instance *instance, ch c`
`86`	`86`	`if indexrelname.Valid {`
`87`	`87`	`indexrelnameLabel = indexrelname.String`
`88`	`88`	`}`
	`89`	`+ labels := []string{schemanameLabel, relnameLabel, indexrelnameLabel}`
`89`	`90`
`90`	`91`	`indexSizeMetric := 0.0`
`91`	`92`	`if indexSize.Valid {`
`@@ -95,7 +96,7 @@ func (PGIndexSizeCollector) Update(ctx context.Context, instance *instance, ch c`
`95`	`96`	`indexSizeDesc,`
`96`	`97`	`prometheus.GaugeValue,`
`97`	`98`	`indexSizeMetric,`
`98`		`- schemanameLabel, relnameLabel, indexrelnameLabel,`
	`99`	`+ labels...,`
`99`	`100`	`)`
`100`	`101`	`}`
`101`	`102`	`if err := rows.Err(); err != nil {`