Skip to content

Commit b5911c4

Browse files
authored
Merge pull request #181 from Logofile/main
Documentation change
2 parents 1e51d8c + 4429a79 commit b5911c4

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

content/editions/overview.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,11 @@ as it applies the file-level setting. The `Employment` `enum`, though, will be
269269

270270
### Prototiller {#prototiller}
271271

272-
We provide both a migration guide and migration tooling that ease the migration
273-
to and between editions. The tool, called Prototiller, will enable you to:
272+
Currently, all conversions to editions format are handled by the Protobuf team.
273+
274+
When this shifts to a self-serve model, we will provide both a migration guide
275+
and migration tooling to ease the migration to and between editions. The tool,
276+
called Prototiller, will enable you to:
274277

275278
* convert proto2 and proto3 definition files to the new editions syntax, at
276279
scale

content/programming-guides/dos-donts.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ their own file with no dependencies. Then it's easy for anyone to use those
159159
types without introducing the transitive dependencies in your other proto files.
160160

161161
For more on this topic, see
162-
[1-1-1 Rule](/programming-guides/1-1-1.md).
162+
[1-1-1 Rule](/programming-guides/1-1-1).
163163

164164
<a id="dont-change-the-default-value-of-a-field"></a>
165165

content/programming-guides/encoding.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ specify a `double` record by writing `5: 25.4`, or a `fixed64` record with `6:
227227
type.
228228

229229
Similarly `float` and `fixed32` have wire type `I32`, which tells it to expect
230-
four bytes instead. The syntax for these consists of adding an `i32` prefix.
230+
four bytes instead. The syntax for these consists of adding an `i32` suffix.
231231
`25.4i32` will emit four bytes, as will `200i32`. Tag types are inferred as
232232
`I32`.
233233

@@ -260,7 +260,7 @@ encoding of `"testing"`. The int32 varint means that the max length of a string
260260
is 2GB.
261261

262262
In Protoscope, this is written as `2:LEN 7 "testing"`. However, it can be
263-
incovenient to repeat the length of the string (which, in Protoscope text, is
263+
inconvenient to repeat the length of the string (which, in Protoscope text, is
264264
already quote-delimited). Wrapping Protoscope content in braces will generate a
265265
length prefix for it: `{"testing"}` is a shorthand for `7 "testing"`. `{}` is
266266
always inferred by fields to be a `LEN` record, so we can write this record

content/support/migration.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,14 +138,13 @@ After:
138138

139139
```cpp
140140
#include <google/protobuf/util/time_util.h>
141-
#ifdef GetCurrent
141+
#ifdef GetCurrentTime
142142
#undef GetCurrentTime
143143
#endif
144144

145145
void F() {
146146
auto time = google::protobuf::util::TimeUtil::GetCurrentTime();
147147
}
148-
149148
```
150149

151150
**Example 2: Preventing macro expansion**

0 commit comments

Comments
 (0)