Fix sonar bad practice issues (#461)

Author: wipfli

tiles/src/main/java/com/protomaps/basemap/text/FontRegistry.java

@@ -10,6 +10,7 @@
 import java.util.Enumeration;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import java.util.zip.ZipEntry;
 import java.util.zip.ZipFile;
 import org.slf4j.Logger;
@@ -22,9 +23,9 @@ private class FontBundle {
     public String name;
     public String version;
     public Font font;
-    public HashMap<String, Integer> encoding;
+    public Map<String, Integer> encoding;
 
-    public FontBundle(String name, String version, Font font, HashMap<String, Integer> encoding) {
+    public FontBundle(String name, String version, Font font, Map<String, Integer> encoding) {
       this.name = name;
       this.version = version;
       this.font = font;
@@ -192,7 +193,7 @@ public Font getFont(String script) {
     return fontBundle.font;
   }
 
-  public HashMap<String, Integer> getEncoding(String script) {
+  public Map<String, Integer> getEncoding(String script) {
     FontBundle fontBundle = registry.get(script);
     if (fontBundle == null) {
       return new HashMap<>();

tiles/src/main/java/com/protomaps/basemap/text/TextEngine.java

@@ -6,8 +6,8 @@
 import java.awt.font.GlyphMetrics;
 import java.awt.font.GlyphVector;
 import java.util.ArrayList;
-import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import org.slf4j.Logger;
@@ -60,7 +60,7 @@ public class TextEngine {
     {4, 0},
   };
 
-  private static int codepointFromGlyph(HashMap<String, Integer> encoding, int index, int xOffset, int yOffset,
+  private static int codepointFromGlyph(Map<String, Integer> encoding, int index, int xOffset, int yOffset,
     int xAdvance, int yAdvance) {
 
     for (int i = 0; i < deltas.length; ++i) {
@@ -83,7 +83,7 @@ private static int codepointFromGlyph(HashMap<String, Integer> encoding, int ind
     return 33;
   }
 
-  public static String encode(String text, Font font, HashMap<String, Integer> encoding) {
+  public static String encode(String text, Font font, Map<String, Integer> encoding) {
     String result = "";
 
     FontRenderContext frc = new FontRenderContext(null, true, true);

tiles/src/test/java/com/protomaps/basemap/text/TextEngineTest.java

@@ -4,8 +4,8 @@
 
 import java.awt.Font;
 import java.nio.file.Path;
-import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import org.junit.jupiter.api.Test;
 
 public class TextEngineTest {
@@ -25,7 +25,7 @@ void testEncode() {
 
     String text = "काठमाडौँ";
     Font font = fontRegistry.getFont(script);
-    HashMap<String, Integer> encoding = fontRegistry.getEncoding(script);
+    Map<String, Integer> encoding = fontRegistry.getEncoding(script);
 
     String textEncoded = TextEngine.encode(text, font, encoding);