Skip to content

Commit 42d7ee7

Browse files
committed
Fix tweak to where v8 looks for its fp16 dependency
Signed-off-by: Michael Warres <[email protected]>
1 parent bf4df28 commit 42d7ee7

File tree

1 file changed

+19
-9
lines changed

1 file changed

+19
-9
lines changed

bazel/external/v8.patch

+19-9
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# 6. Compile v8 with -Wno-deprecated-declarations
1010

1111
diff --git a/BUILD.bazel b/BUILD.bazel
12-
index 30be47fa333..093599d47df 100644
12+
index 30be47fa333..23cfc9c4754 100644
1313
--- a/BUILD.bazel
1414
+++ b/BUILD.bazel
1515
@@ -220,7 +220,7 @@ v8_int(
@@ -21,25 +21,35 @@ index 30be47fa333..093599d47df 100644
2121
)
2222

2323
# Default setting for v8_enable_pointer_compression.
24-
@@ -3698,13 +3698,14 @@ filegroup(
24+
@@ -3698,14 +3698,22 @@ filegroup(
2525

2626
v8_library(
2727
name = "lib_fp16",
2828
- srcs = ["third_party/fp16/src/include/fp16.h"],
29-
+ srcs = ["@fp16//:include/fp16.h"],
30-
hdrs = [
29+
- hdrs = [
3130
- "third_party/fp16/src/include/fp16/fp16.h",
3231
- "third_party/fp16/src/include/fp16/bitcasts.h",
33-
+ "@fp16//:include/fp16/fp16.h",
34-
+ "@fp16//:include/fp16/bitcasts.h",
35-
],
32+
+ hdrs = ["@fp16//:include/fp16.h"],
33+
+ srcs = [],
3634
+ include_prefix = "third_party/fp16/src",
37-
includes = [
35+
+ deps = [
36+
+ "lib_fp16_includes",
37+
],
38+
- includes = [
3839
- "third_party/fp16/src/include",
39-
+ "@fp16//:include",
40+
+)
41+
+
42+
+v8_library(
43+
+ name = "lib_fp16_includes",
44+
+ hdrs = [
45+
+ "@fp16//:include/fp16/fp16.h",
46+
+ "@fp16//:include/fp16/bitcasts.h",
4047
],
48+
+ srcs = [],
49+
+ strip_include_prefix = "include",
4150
)
4251

52+
filegroup(
4353
diff --git a/bazel/defs.bzl b/bazel/defs.bzl
4454
index 520a311595e..64b4928abe5 100644
4555
--- a/bazel/defs.bzl

0 commit comments

Comments
 (0)