Skip to content

remove native.bind for bzlmod compatibility #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmorel-35 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove native.bind for bzlmod compatibility #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ cc_library(
],
deps = [
":wasm_vm_headers",
"//external:wee8",
"@v8//:wee8",
],
)

Expand All @@ -151,7 +151,7 @@ cc_library(
],
deps = [
":wasm_vm_headers",
"//external:wamr",
"@com_github_bytecodealliance_wasm_micro_runtime//:wamr_lib",
],
)

Expand All @@ -178,7 +178,7 @@ cc_library(
}),
deps = [
":wasm_vm_headers",
"//external:wasmedge",
"@com_github_wasmedge_wasmedge//:wasmedge_lib",
],
)

Expand Down Expand Up @@ -217,7 +217,7 @@ cc_library(
}),
deps = [
":wasm_vm_headers",
"//external:wasmtime",
"@com_github_bytecodealliance_wasmtime//:wasmtime_lib",
],
)

Expand Down Expand Up @@ -276,7 +276,7 @@ cc_library(
}),
deps = [
":wasm_vm_headers",
"//external:prefixed_wasmtime",
"@com_github_bytecodealliance_wasmtime//:prefixed_wasmtime_lib",
],
)

Expand Down
25 changes: 0 additions & 25 deletions bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,6 @@ def proxy_wasm_cpp_host_repositories():
build_file = "@proxy_wasm_cpp_host//bazel/external:intel_ittapi.BUILD",
)

native.bind(
name = "wee8",
actual = "@v8//:wee8",
)

# WAMR with dependencies.

maybe(
Expand All @@ -274,11 +269,6 @@ def proxy_wasm_cpp_host_repositories():
url = "https://github.com/bytecodealliance/wasm-micro-runtime/archive/refs/tags/WAMR-2.4.1.zip",
)

native.bind(
name = "wamr",
actual = "@com_github_bytecodealliance_wasm_micro_runtime//:wamr_lib",
)

maybe(
http_archive,
name = "llvm-15_0_7",
Expand All @@ -299,11 +289,6 @@ def proxy_wasm_cpp_host_repositories():
url = "https://github.com/WasmEdge/WasmEdge/archive/refs/tags/proxy-wasm/0.13.1.tar.gz",
)

native.bind(
name = "wasmedge",
actual = "@com_github_wasmedge_wasmedge//:wasmedge_lib",
)

# Wasmtime with dependencies.

maybe(
Expand All @@ -314,13 +299,3 @@ def proxy_wasm_cpp_host_repositories():
strip_prefix = "wasmtime-24.0.0",
url = "https://github.com/bytecodealliance/wasmtime/archive/v24.0.0.tar.gz",
)

native.bind(
name = "wasmtime",
actual = "@com_github_bytecodealliance_wasmtime//:wasmtime_lib",
)

native.bind(
name = "prefixed_wasmtime",
actual = "@com_github_bytecodealliance_wasmtime//:prefixed_wasmtime_lib",
)
Loading