Skip to content

Commit afa3f16

Browse files
mohitpubnubparfeonpubnub-release-bot
authored
Fix/here_now (#193)
* fix: hereNow with channelGroups only, url * Update CODEOWNERS * Update CODEOWNERS * argument validation for hereNow * PubNub SDK v6.19.0.1 release. * revert b7e1e6b * PubNub SDK v6.19.1.0 release. --------- Co-authored-by: Serhii Mamontov <[email protected]> Co-authored-by: PubNub Release Bot <[email protected]>
1 parent 3f516b0 commit afa3f16

File tree

8 files changed

+31
-31
lines changed

8 files changed

+31
-31
lines changed

‎.pubnub.yml

+12-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
11
name: c-sharp
2-
version: "6.19.0"
2+
version: "6.19.1"
33
schema: 1
44
scm: github.com/pubnub/c-sharp
55
changelog:
6+
- date: 2023-10-24
7+
version: v6.19.1
8+
changes:
9+
- type: bug
10+
text: "Fixes issue of getting error when hereNow is called with channelGroups param only."
611
- date: 2023-10-16
712
version: v6.19.0
813
changes:
@@ -741,7 +746,7 @@ features:
741746
- QUERY-PARAM
742747
supported-platforms:
743748
-
744-
version: Pubnub 'C#' 6.19.0
749+
version: Pubnub 'C#' 6.19.1
745750
platforms:
746751
- Windows 10 and up
747752
- Windows Server 2008 and up
@@ -751,7 +756,7 @@ supported-platforms:
751756
- .Net Framework 4.5
752757
- .Net Framework 4.6.1+
753758
-
754-
version: PubnubPCL 'C#' 6.19.0
759+
version: PubnubPCL 'C#' 6.19.1
755760
platforms:
756761
- Xamarin.Android
757762
- Xamarin.iOS
@@ -771,7 +776,7 @@ supported-platforms:
771776
- .Net Core
772777
- .Net 6.0
773778
-
774-
version: PubnubUWP 'C#' 6.19.0
779+
version: PubnubUWP 'C#' 6.19.1
775780
platforms:
776781
- Windows Phone 10
777782
- Universal Windows Apps
@@ -795,7 +800,7 @@ sdks:
795800
distribution-type: source
796801
distribution-repository: GitHub
797802
package-name: Pubnub
798-
location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.0.0
803+
location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.1.0
799804
requires:
800805
-
801806
name: ".Net"
@@ -1078,7 +1083,7 @@ sdks:
10781083
distribution-type: source
10791084
distribution-repository: GitHub
10801085
package-name: PubNubPCL
1081-
location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.0.0
1086+
location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.1.0
10821087
requires:
10831088
-
10841089
name: ".Net Core"
@@ -1437,7 +1442,7 @@ sdks:
14371442
distribution-type: source
14381443
distribution-repository: GitHub
14391444
package-name: PubnubUWP
1440-
location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.0.0
1445+
location: https://github.com/pubnub/c-sharp/releases/tag/v6.19.1.0
14411446
requires:
14421447
-
14431448
name: "Universal Windows Platform Development"

‎CHANGELOG

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
v6.19.1 - October 24 2023
2+
-----------------------------
3+
- Fixed: fixes issue of getting error when hereNow is called with channelGroups param only.
4+
15
v6.19.0 - October 16 2023
26
-----------------------------
37
- Added: add crypto module that allows configure SDK to encrypt and decrypt messages.

‎src/Api/PubnubApi/Builder/UrlRequestBuilder.cs

+6-6
Original file line numberDiff line numberDiff line change
@@ -278,18 +278,18 @@ Uri IUrlRequestBuilder.BuildSignalRequest(string requestMethod, string requestBo
278278
Uri IUrlRequestBuilder.BuildHereNowRequest(string requestMethod, string requestBody, string[] channels, string[] channelGroups, bool showUUIDList, bool includeUserState, Dictionary<string, object> externalQueryParam)
279279
{
280280
PNOperationType currentType = PNOperationType.PNHereNowOperation;
281-
string channel = (channels != null && channels.Length > 0) ? string.Join(",", channels.OrderBy(x => x).ToArray()) : "";
281+
if ((channels == null || channels.Length == 0) && (channelGroups == null || channelGroups.Length == 0)) {
282+
throw new ArgumentException("Please provide Channels or ChannelGroups.");
283+
}
284+
string channel = (channels != null && channels.Length > 0) ? string.Join(",", channels.OrderBy(x => x).ToArray()) : ",";
282285

283286
List<string> url = new List<string>();
284287
url.Add("v2");
285288
url.Add("presence");
286289
url.Add("sub_key");
287290
url.Add(pubnubConfig.ContainsKey(pubnubInstanceId) ? pubnubConfig[pubnubInstanceId].SubscribeKey : "");
288-
if (!string.IsNullOrEmpty(channel))
289-
{
290-
url.Add("channel");
291-
url.Add(channel);
292-
}
291+
url.Add("channel");
292+
url.Add(channel);
293293

294294
int disableUUID = showUUIDList ? 0 : 1;
295295
int userState = includeUserState ? 1 : 0;

‎src/Api/PubnubApi/Properties/AssemblyInfo.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
[assembly: AssemblyProduct("Pubnub C# SDK")]
1212
[assembly: AssemblyCopyright("Copyright © 2021")]
1313
[assembly: AssemblyTrademark("")]
14-
[assembly: AssemblyVersion("6.19.0.0")]
15-
[assembly: AssemblyFileVersion("6.19.0.0")]
14+
[assembly: AssemblyVersion("6.19.1.0")]
15+
[assembly: AssemblyFileVersion("6.19.1.0")]
1616
// Setting ComVisible to false makes the types in this assembly not visible
1717
// to COM components. If you need to access a type in this assembly from
1818
// COM, set the ComVisible attribute to true on that type.

‎src/Api/PubnubApi/PubnubApi.csproj

+2-5
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,15 @@
1414

1515
<PropertyGroup>
1616
<PackageId>Pubnub</PackageId>
17-
<PackageVersion>6.19.0.0</PackageVersion>
17+
<PackageVersion>6.19.1.0</PackageVersion>
1818
<Title>PubNub C# .NET - Web Data Push API</Title>
1919
<Authors>Pandu Masabathula</Authors>
2020
<Owners>PubNub</Owners>
2121
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
2222
<PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
2323
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
2424
<RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
25-
<PackageReleaseNotes>Add crypto module that allows configure SDK to encrypt and decrypt messages.
26-
Improved security of crypto implementation by adding enhanced AES-CBC cryptor.
27-
Fixes Newtonsoft Json vulnerability with MaxDepth and upgrade to version for non-PCL.
28-
Add SubscribeKey validation for subscribe feature.</PackageReleaseNotes>
25+
<PackageReleaseNotes>Fixes issue of getting error when hereNow is called with channelGroups param only.</PackageReleaseNotes>
2926
<PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
3027
<!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games. This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
3128
<Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games. This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

‎src/Api/PubnubApiPCL/PubnubApiPCL.csproj

+2-5
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,15 @@
1515

1616
<PropertyGroup>
1717
<PackageId>PubnubPCL</PackageId>
18-
<PackageVersion>6.19.0.0</PackageVersion>
18+
<PackageVersion>6.19.1.0</PackageVersion>
1919
<Title>PubNub C# .NET - Web Data Push API</Title>
2020
<Authors>Pandu Masabathula</Authors>
2121
<Owners>PubNub</Owners>
2222
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
2323
<PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
2424
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
2525
<RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
26-
<PackageReleaseNotes>Add crypto module that allows configure SDK to encrypt and decrypt messages.
27-
Improved security of crypto implementation by adding enhanced AES-CBC cryptor.
28-
Fixes Newtonsoft Json vulnerability with MaxDepth and upgrade to version for non-PCL.
29-
Add SubscribeKey validation for subscribe feature.</PackageReleaseNotes>
26+
<PackageReleaseNotes>Fixes issue of getting error when hereNow is called with channelGroups param only.</PackageReleaseNotes>
3027
<PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
3128
<!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games. This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
3229
<Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games. This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

‎src/Api/PubnubApiUWP/PubnubApiUWP.csproj

+2-5
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,15 @@
1616

1717
<PropertyGroup>
1818
<PackageId>PubnubUWP</PackageId>
19-
<PackageVersion>6.19.0.0</PackageVersion>
19+
<PackageVersion>6.19.1.0</PackageVersion>
2020
<Title>PubNub C# .NET - Web Data Push API</Title>
2121
<Authors>Pandu Masabathula</Authors>
2222
<Owners>PubNub</Owners>
2323
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
2424
<PackageIconUrl>http://pubnub.s3.amazonaws.com/2011/powered-by-pubnub/pubnub-icon-600x600.png</PackageIconUrl>
2525
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
2626
<RepositoryUrl>https://github.com/pubnub/c-sharp/</RepositoryUrl>
27-
<PackageReleaseNotes>Add crypto module that allows configure SDK to encrypt and decrypt messages.
28-
Improved security of crypto implementation by adding enhanced AES-CBC cryptor.
29-
Fixes Newtonsoft Json vulnerability with MaxDepth and upgrade to version for non-PCL.
30-
Add SubscribeKey validation for subscribe feature.</PackageReleaseNotes>
27+
<PackageReleaseNotes>Fixes issue of getting error when hereNow is called with channelGroups param only.</PackageReleaseNotes>
3128
<PackageTags>Web Data Push Real-time Notifications ESB Message Broadcasting Distributed Computing</PackageTags>
3229
<!--<Summary>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games. This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Summary>-->
3330
<Description>PubNub is a Massively Scalable Web Push Service for Web and Mobile Games. This is a cloud-based service for broadcasting messages to thousands of web and mobile clients simultaneously</Description>

‎src/Api/PubnubApiUnity/PubnubApiUnity.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
<PropertyGroup>
1717
<PackageId>PubnubApiUnity</PackageId>
18-
<PackageVersion>6.19.0.0</PackageVersion>
18+
<PackageVersion>6.19.1.0</PackageVersion>
1919
<Title>PubNub C# .NET - Web Data Push API</Title>
2020
<Authors>Pandu Masabathula</Authors>
2121
<Owners>PubNub</Owners>

0 commit comments

Comments
 (0)