Fix aws-java-eks-minimal example #1281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Sep 13, 2022
| ctx.export("defaultVpcId", defaultVpcId); | ||
|
|
||
| // Find all the subnets in the default VPC. | ||
| final var allSubnetIds = Ec2Functions.getSubnets(GetSubnetsArgs.builder() |
There was a problem hiding this comment.
Perhaps we should provision the subnets instead of finding them in the default VPC, to make the example more self-contained.
t0yv0
commented
Sep 13, 2022
|
|
||
| // Find all the subnets in the default VPC. | ||
| final var allSubnetIds = Ec2Functions.getSubnets(GetSubnetsArgs.builder() | ||
| .filters(GetSubnetsFilterArgs.builder() |
There was a problem hiding this comment.
getSubnetIds returned deprecation warnings. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/subnets is recommended to be used instead. Its not obvious from the types but this is how it's to be used.
|
🍹 The Update for stack moolumi/k8s-ci-cluster/f78ad97862337c6ac91403773eaa5769db825b84-757 was successful. Resource Changes Name Type Operation
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
+ primary-node-pool gcp:container/nodePool:NodePool create
+ gke pulumi:providers:kubernetes create
+ k8s-ci-cluster-f78ad97862337c6ac91403773eaa5769db825b84-757 pulumi:pulumi:Stack create
+ multicloud pulumi-kubernetes:ci:GkeCluster create
|
|
🍹 The Destroy for stack moolumi/k8s-ci-cluster/f78ad97862337c6ac91403773eaa5769db825b84-757 was successful. Resource Changes Name Type Operation
- gke pulumi:providers:kubernetes delete
- primary-node-pool gcp:container/nodePool:NodePool delete
- password random:index/randomPassword:RandomPassword delete
- ephemeral-ci-cluster gcp:container/cluster:Cluster delete
|
This was referenced Sep 13, 2022
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.