Merge pull request #159 from danieldreier/refactor_tests_with_spec_facts

Refactor rspec-puppet tests

Author: zachfi

Gemfile

@@ -9,6 +9,7 @@ group :test do
   gem "puppet-syntax"
   gem "puppetlabs_spec_helper"
   gem "metadata-json-lint"
+  gem "puppet_spec_facts", '>= 0.2.1'
 end
 
 group :development do

spec/classes/agent_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 shared_examples 'agent examples' do
-  it { should contain_class('puppet::package') }
   it { should contain_class('puppet::agent') }
   it { should compile.with_all_deps }
   it { should contain_ini_setting('report_server').with_value('puppet_reports.example.com') }
@@ -10,97 +9,79 @@
   it { should contain_package('puppet') }
 end
 
-describe 'puppet::agent' do
-  describe "sample agent configuration from documentation" do
-    let(:params) {{
-      :server        => 'puppet.example.com',
-      :report_server => 'puppet_reports.example.com',
-      :method        => 'service',
-    }}
-    context 'CentOS, RedHat, Debian, Ubuntu' do
-      ['RedHat', 'CentOS', 'Debian', 'Ubuntu'].each do |operatingsystem|
+PuppetSpecFacts.facts_for_platform_by_name(["Debian_wheezy_7.7_amd64_3.7.2_structured", "CentOS_5.11_x86_64_3.7.1_structured", "FreeBSD_10.0-RELEASE_amd64_3.6.2_structured"]).each do |name, facthash|
+describe "puppet::agent" do
+    let(:facts) { facthash }
 
-        osfamily   = 'Redhat'  if ['RedHat', 'CentOS'].include? operatingsystem
-        osfamily ||= 'Debian'
+    context "running on #{name}" do
+      [true, false].each do |manage_repos|
 
-        let(:facts) {{
-          :osfamily        => osfamily,
-          :operatingsystem => operatingsystem,
-          :lsbdistid       => operatingsystem,
-          :lsbdistcodename => 'lolwut'
-        }}
-        context 'running as service' do
+        context "when manage_repos => #{manage_repos}" do
           let(:params) {{
             :server        => 'puppet.example.com',
             :report_server => 'puppet_reports.example.com',
-            :method        => 'service',
+            :manage_repos  => manage_repos,
           }}
-          it_behaves_like "agent examples"
-          it do
-            should contain_service('puppet_agent').with({
-              :ensure => "running"
-            })
-            should contain_cron('puppet agent')
-          end
-        end
-        context 'method => "only_service"' do
-          let(:params) {{
-            :server        => 'puppet.example.com',
-            :report_server => 'puppet_reports.example.com',
-            :method        => 'only_service',
-          }}
-          it_behaves_like "agent examples"
-          it do
-            should contain_service('puppet_agent').with({
-              :ensure => "running"
-            })
-            should_not contain_cron('puppet agent')
-          end
-        end
-        context 'method => "none"' do
-          let(:params) {{
-            :server        => 'puppet.example.com',
-            :report_server => 'puppet_reports.example.com',
-            :method        => 'only_service',
-          }}
-          it_behaves_like "agent examples"
-          it do
-            should contain_service('puppet_agent').with({
-              :ensure => "running"
-            })
-            should_not contain_cron('puppet agent')
-          end
-        end
-        context 'method => "cron"' do
-          let(:params) {{
-            :server        => 'puppet.example.com',
-            :report_server => 'puppet_reports.example.com',
-            :method        => 'cron',
-          }}
-          it_behaves_like "agent examples"
-          it do
-            should_not contain_service('puppet_agent').with({
-              :ensure => "running"
-            })
-            should contain_cron('puppet agent').with_command(/puppet agent/)
+
+          case facthash['osfamily']
+          when 'RedHat'
+            it_behaves_like "agent examples"
+            it {
+              is_expected.to contain_class('Puppet::Package::Repository') if manage_repos == true
+              is_expected.to contain_yumrepo('puppetlabs-products') if manage_repos == true
+              is_expected.to_not contain_yumrepo('puppetlabs-products') if manage_repos == false
+              is_expected.to_not contain_apt__source('puppetlabs')
+            }
+          when 'Debian'
+            it_behaves_like "agent examples"
+            it { is_expected.to contain_class('Puppet::Package::Repository') if manage_repos == true }
+            it { should_not contain_class('puppetlabs_yum') }
+            if manage_repos == true
+            it {
+              is_expected.to contain_class('puppetlabs_apt')
+              is_expected.to contain_apt__source('puppetlabs')
+            }
+            elsif manage_repos == false
+              it { is_expected.to_not contain_class('puppetlabs_apt') }
+            end
+          when 'FreeBSD'
+            if manage_repos == false
+              it {
+                is_expected.to_not contain_class('puppetlabs_apt')
+                is_expected.to_not contain_class('puppetlabs_yum')
+                is_expected.to compile.with_all_deps
+              }
+            end
           end
         end
-        context 'manage_repos => false' do
-          let(:params) {{
-            :server        => 'puppet.example.com',
-            :report_server => 'puppet_reports.example.com',
-            :manage_repos  => false,
-          }}
-          it_behaves_like "agent examples"
-          it do
-            should contain_service('puppet_agent')
-            should contain_cron('puppet agent').with_command(/puppet agent/)
-            should_not contain_yumrepo('puppetlabs-products')
-            should_not contain_apt__source('puppetlabs')
+      end
+      ['service','cron','only_service'].each do |agent_method|
+        manage_repos = false if facthash['osfamily'] == 'FreeBSD'
+        context "method => #{agent_method}" do
+          describe "agent configuration on #{facthash["osfamily"]}" do
+            let(:params) {{
+              :server        => 'puppet.example.com',
+              :report_server => 'puppet_reports.example.com',
+              :method        => agent_method,
+              :manage_repos  => manage_repos,
+            }}
+
+            it_behaves_like "agent examples"
+            case agent_method
+            when 'service'
+              it { should contain_service('puppet_agent').with({ :ensure => "running" }) }
+              it { should contain_cron('puppet agent') }
+            when 'cron'
+              it { should contain_service('puppet_agent').with({ :ensure => "stopped" }) }
+              it { should contain_cron('puppet agent') }
+            when 'only_service'
+              it { should contain_service('puppet_agent').with({ :ensure => "running" }) }
+              it { should_not contain_cron('puppet agent') }
+            end
           end
         end
-
       end
     end
   end
 end
+

spec/classes/puppet_spec.rb

@@ -1,28 +1,31 @@
 require 'spec_helper'
 
-describe 'puppet' do
-  context 'supported operating systems' do
-    ['Debian', 'RedHat', 'CentOS'].each do |operatingsystem|
-      describe "puppet class without any parameters on #{operatingsystem}" do
-        let(:params) {{ }}
-        let(:facts) {{
-          :operatingsystem => operatingsystem,
-        }}
+PuppetSpecFacts.facts_for_platform_by_name([
+  "Debian_wheezy_7.7_amd64_3.7.2_structured",
+  "Ubuntu_precise_12.04_amd64_PE-3.3.2_stringified",
+  "Ubuntu_trusty_14.04_amd64_PE-3.3.2_stringified"]).each do |name, facthash|
 
-        it { should compile.with_all_deps }
+  describe 'puppet' do
+    context 'supported operating systems' do
+      ['Debian', 'RedHat', 'CentOS'].each do |operatingsystem|
+        describe "puppet class without any parameters on #{operatingsystem}" do
+          let(:params) {{ }}
+          let(:facts) { facthash }
 
-        it { should contain_class('puppet::params') }
+          it { should compile.with_all_deps }
+          it { should contain_class('puppet::params') }
+        end
       end
     end
-  end
 
-  context 'unsupported operating system' do
-    describe 'puppet class without any parameters on OpenVMS' do
-      let(:facts) {{
-        :operatingsystem => 'OpenVMS',
-      }}
+    context 'unsupported operating system' do
+      describe 'puppet class without any parameters on OpenVMS' do
+        let(:facts) {{
+          :operatingsystem => 'OpenVMS',
+        }}
 
-      it { expect { should contain_package('puppet') }.to raise_error(Puppet::Error, /Sorry, OpenVMS is not supported/) }
+        it { expect { should contain_package('puppet') }.to raise_error(Puppet::Error, /Sorry, OpenVMS is not supported/) }
+      end
     end
   end
 end