Skip to content

Commit 3e4c072

Browse files
vine77vine77
committed
Migrate from Artifactory to npm
1 parent 985d79e commit 3e4c072

25 files changed

+13
-83
lines changed

Diff for: ‎.npmrc

-1
This file was deleted.

Diff for: ‎README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ Note: These steps must be completed while on the corporate network or VPN.
1515
To add the main package, `@puppet/react-components`, to an existing project:
1616

1717
```sh
18-
echo "@puppet:registry=https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/" > .npmrc
1918
npm install @puppet/react-components
2019
```
2120

@@ -24,7 +23,7 @@ npm install @puppet/react-components
2423
To try out the design system from scratch, generate a new project with uikit:
2524

2625
```sh
27-
npm install -g @puppet/uikit --registry=https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm/
26+
npm install -g @puppet/uikit
2827
uikit generate project my-project
2928
```
3029

Diff for: ‎getting-started.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ If you don't have a recent version of Node.js installed locally, install the lat
99
Install `uikit`:
1010

1111
```sh
12-
npm install -g @puppet/uikit --registry=https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm/
12+
npm install -g @puppet/uikit
1313
```
1414

1515
Generate a web app:

Diff for: ‎lerna.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
{
22
"packages": ["packages/*"],
3-
"version": "independent",
4-
"registry": "https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm/"
3+
"version": "independent"
54
}

Diff for: ‎package.json

-3
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,5 @@
1111
},
1212
"devDependencies": {
1313
"lerna": "^3.13.4"
14-
},
15-
"publishConfig": {
16-
"registry": "https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/"
1714
}
1815
}

Diff for: ‎packages/design-assets/.npmrc

-1
This file was deleted.

Diff for: ‎packages/design-assets/package.json

+1-4
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,5 @@
22
"name": "@puppet/design-assets",
33
"version": "1.0.0",
44
"author": "Puppet, Inc.",
5-
"license": "UNLICENSED",
6-
"publishConfig": {
7-
"registry": "https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/"
8-
}
5+
"license": "UNLICENSED"
96
}

Diff for: ‎packages/design-system-website/.npmrc

-1
This file was deleted.

Diff for: ‎packages/design-system-website/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
"start": "npm i && npx styleguidist server",
88
"styleguide:build": "npm i && npx styleguidist build"
99
},
10-
"publishConfig": {
11-
"registry": "https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/"
12-
},
1310
"devDependencies": {
1411
"@babel/core": "^7.4.5",
1512
"@babel/plugin-proposal-object-rest-spread": "^7.4.4",

Diff for: ‎packages/react-components/.npmrc

-1
This file was deleted.

Diff for: ‎packages/react-components/CONTRIBUTING.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ using [nvm](https://github.com/creationix/nvm).
2121
Once you've installed Node, install the dependencies for this project with:
2222

2323
```
24-
make setup
24+
npm install
2525
```
2626

2727
UI Components includes a styleguide that allows us to test components in
@@ -114,6 +114,11 @@ maintainers. Again, thank you for the contribution!
114114

115115
## Releasing a new version
116116

117+
New versions are currently released by maintainers using `lerna publish`. Please collaborate with the team in [#team-design-system](https://puppet.slack.com/messages/CFFECRQAY) to release a new version. (Note: This process will likely be replaced with automated releases on push to master.)
118+
119+
<!--
120+
## Releasing a new version
121+
117122
New versions of UI Components are built and published to Artifactory using
118123
[Puppet Pipelines](http://pipelines.puppet.com/). This happens whenever a commit
119124
is pushed to the master branch. Ideally, the only commits to master happen via a
@@ -143,6 +148,7 @@ that process:
143148
5. Upon approval your pull request will be merged by the reviewer. The reviewer
144149
is responsible for making sure the deployment goes out smoothly, and for
145150
rolling back otherwise.
151+
-->
146152

147153
## Reviewing pull requests
148154

Diff for: ‎packages/react-components/Makefile

-8
This file was deleted.

Diff for: ‎packages/react-components/README.md

-11
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,10 @@ Components are documented using React Styleguidist, which provides API docs alon
1414

1515
## Installation
1616

17-
This library is distributed as an npm package on [Artifactory](https://confluence.puppetlabs.com/display/SRE/Artifactory+Basics). As such, you should point to the Artifactory registry for `@puppet` scoped packages by adding and committing the following to an `.npmrc` file in your project.
18-
19-
```sh
20-
echo "@puppet:registry=https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/" > .npmrc
21-
```
22-
23-
You can then install `react-components` in your project with the following command:
24-
2517
```sh
2618
npm install @puppet/react-components
2719
```
2820

29-
If you run into issues while installing, please double check that you're either
30-
on the corporate WiFi or VPN.
31-
3221
## Setup
3322

3423
### Webpack (without Create React App)

Diff for: ‎packages/react-components/distelli-manifest.yml

-14
This file was deleted.

Diff for: ‎packages/react-components/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
"version": "5.6.0",
44
"description": "Collection of reusable React components",
55
"main": "build/library.js",
6-
"publishConfig": {
7-
"registry": "https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/"
8-
},
96
"scripts": {
107
"analyze": "webpack --config webpack.analyze.config.js",
118
"prebuild": "rimraf build",

Diff for: ‎packages/react-layouts/.npmrc

-1
This file was deleted.

Diff for: ‎packages/react-layouts/README.md

-11
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,10 @@ Puppet React Layouts is a collection of full pages and other reusable layouts ap
44

55
## Installation
66

7-
This library is distributed as an npm package on [Artifactory](https://confluence.puppetlabs.com/display/SRE/Artifactory+Basics). As such, you should point to the Artifactory registry for `@puppet` scoped packages by adding and committing the following to an `.npmrc` file in your project.
8-
9-
```sh
10-
echo "@puppet:registry=https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/" > .npmrc
11-
```
12-
13-
You can then install `react-layouts` in your project with the following command:
14-
157
```sh
168
npm install @puppet/react-layouts
179
```
1810

19-
If you run into issues while installing, please double check that you're either
20-
on the corporate WiFi or VPN.
21-
2211
## Setup
2312

2413
### Webpack (without Create React App)

Diff for: ‎packages/react-layouts/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
"test:watch": "jest --watch",
1818
"watch": "./scripts/watch"
1919
},
20-
"publishConfig": {
21-
"registry": "https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/"
22-
},
2320
"dependencies": {
2421
"@puppet/react-components": "^5.6.0",
2522
"@puppet/sass-variables": "^1.1.0",

Diff for: ‎packages/sass-variables/.npmrc

-1
This file was deleted.

Diff for: ‎packages/sass-variables/README.md

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
To use public Sass variables, add `@puppet/sass-variables` to your project:
44

55
```sh
6-
echo "@puppet:registry=https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/" > .npmrc
76
npm install @puppet/sass-variables
87
```
98

Diff for: ‎packages/sass-variables/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
"scripts": {
77
"format": "prettier --write **/*.scss && stylelint --fix **/*.scss"
88
},
9-
"publishConfig": {
10-
"registry": "https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/"
11-
},
129
"devDependencies": {
1310
"stylelint-config-prettier": "^5.2.0"
1411
}

Diff for: ‎packages/uikit/.npmrc

-1
This file was deleted.

Diff for: ‎packages/uikit/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ brew install node@10
1212

1313
## Installation
1414

15-
To install uikit (or update it to the latest version) globally from Artifactory, making the `uikit` command available in your shell:
15+
To install uikit (or update it to the latest version) globally, making the `uikit` command available in your shell:
1616

1717
```sh
18-
npm install -g @puppet/uikit --registry=https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm/
18+
npm install -g @puppet/uikit
1919
```
2020

2121
## Generators

Diff for: ‎packages/uikit/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
"test:coverage": "jest --collectCoverage",
1515
"test:watch": "jest --watch"
1616
},
17-
"publishConfig": {
18-
"registry": "https://artifactory.delivery.puppetlabs.net/artifactory/api/npm/npm__local/"
19-
},
2017
"files": [
2118
"*"
2219
],

Diff for: ‎packages/uikit/templates/library/.npmrc

-1
This file was deleted.

0 commit comments

Comments
 (0)