Commit 5a8b607
committed
Fix backup/rotation with multiple excluded databases
* When using multiple excluded databases, the list of databases
is filtered using `grep -v`.
i.e. `grep -v '^\(information_schema|performance_schema\)$`
* When using Basic vs Extended Regular Expressions, the characters
`(` and `|` lose their special meaning, the backslashed versions
have to be used.
For the group (`()`) the escaping has been done, however the
alternation is unescaped.
Leading to:
* All the excluded databases will be backed up.
* In case a database is not backuppable (which is why it had been
excluded), this leads to the cleanup not being run at all, as it
depends on the backup having been successful.
This MR aims to fix this issue, by revising the regular expression
and specifying that behaviour in the respective class spec.1 parent e69e11a commit 5a8b607
File tree
2 files changed
+3
-3
lines changed- spec/classes
- templates
2 files changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
| 87 | + | |
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| |||
0 commit comments