[s3] Add tests for initBucket + listBucket for s3 and minio

Author: lorandszakacs

aws-cloudfront/src/main/scala/busymachines/pureharm/aws/cloudfront/CloudfrontConfig.scala

@@ -21,7 +21,7 @@ object CloudfrontConfig extends ConfigLoader[CloudfrontConfig] {
     override val distributionDomain: CloudfrontDistributionDomain,
     override val keyPairID:          CloudfrontKeyPairID,
     override val urlExpirationTime:  CloudfrontURLExpiration,
-    val privateKeyFilePath:          CloudfrontPrivateKeyFilePath,
+    privateKeyFilePath:              CloudfrontPrivateKeyFilePath,
   ) extends CloudfrontConfig
 
   final case class WithPrivateKey(
@@ -37,7 +37,7 @@ object CloudfrontConfig extends ConfigLoader[CloudfrontConfig] {
     ConfigReader[String].emap(s =>
       CloudfrontPrivateKey(s).leftMap(an =>
         CannotConvert(
-          value   = s"CloudfrontPrivateKeyValue — truncated(10): ${s.take(20)}",
+          value   = s"CloudfrontPrivateKeyValue — truncated(20): ${s.take(20)}",
           toType  = "CloudfrontPrivateKey",
           because = an.toString,
         )

aws-s3/src/it/resources/application.conf

@@ -0,0 +1,29 @@
+test-live.pureharm.aws.s3 {
+  region = "eu-central-1"
+  region = ${?LIVE_TEST_PUREHARM_AWS_S3_REGION}
+
+  access-key-id = "access-key-not-committing-it-to-github-lol"
+  access-key-id = ${?LIVE_TEST_PUREHARM_AWS_S3_ACCESS_KEY_ID}
+
+  secret-access-key = "secret-access-key-not-committing-it-to-github-lol"
+  secret-access-key = ${?LIVE_TEST_PUREHARM_AWS_SECRET_ACCESS_KEY}
+
+  bucket = "pureharm_bucket"
+  bucket = ${?LIVE_TEST_PUREHARM_AWS_S3_BUCKET}
+
+  api-call-attempt-timeout = 2 seconds
+  api-call-attempt-timeout = ${?LIVE_TEST_PUREHARM_AWS_S3_API_CALL_ATTEMPT_TIMEOUT}
+
+  api-call-timeout = 10 seconds
+  api-call-timeout = ${?LIVE_TEST_PUREHARM_AWS_API_CALL_TIMEOUT}
+}
+
+test-live.pureharm.aws.s3.minio {
+  region = "eu-central-1"
+  access-key-id = "AKIAIOSFODOO3EXAMPLE" # taken from dockerfile, it's ok, it runs locally
+  secret-access-key = "wJalrXUtnFEMI/K7MDENG/bPxRACABEXAMPLEKEY" # taken from dockerfile, it's ok, it runs locally
+  bucket = "minio-bucket"
+  api-call-attempt-timeout = 2 seconds
+  api-call-timeout = 10 seconds
+  endpoint-override = "http://localhost:31312"
+}

aws-s3/src/it/scala/busymachines/pureharm/aws/s3/S3LiveTest.scala

@@ -55,6 +55,19 @@ final class S3LiveTest extends PureharmTestWithResource {
     "GOOGLE_MURRAY_BOOKCHIN".getBytes(java.nio.charset.StandardCharsets.UTF_8)
   )
 
+  test("s3 init bucket + list bucket") { case (config, client) =>
+    val newBucket = S3Bucket("testinitbucket")
+    for {
+      buckets <- client.listBuckets
+      _ = assert(buckets.contains(config.bucket))
+      att1: Attempt[Unit] <- client.initBucket(config.bucket).attempt
+      _ = assertSuccess(att1)(())
+      _ <- Resource.make(client.initBucket(newBucket))(_ => client.deleteBucket(newBucket).attempt.void).use { _ =>
+        client.listBuckets.map(bs => IO(assert(bs.contains(newBucket))))
+      }
+    } yield succeed
+  }
+
   test("s3 put + get + delete") { case (config, client) =>
     for {
       _   <- l.info(s"acquired client resource: ${client.toString}")

aws-s3/src/it/scala/busymachines/pureharm/aws/s3/S3MinIOTest.scala

@@ -44,7 +44,7 @@ final class S3MinIOTest extends PureharmTestWithResource {
     s3Client <- AmazonS3Client.resource[IO](config)
     _        <- Resource.liftF(l.info(s"creating minio bucket"))
     _        <- Resource.liftF(s3Client.deleteBucket(config.bucket).attempt.void) // just in case
-    _        <- Resource.make(s3Client.createBucket(config.bucket))(_ => s3Client.deleteBucket(config.bucket))
+    _        <- Resource.make(s3Client.initBucket(config.bucket))(_ => s3Client.deleteBucket(config.bucket))
     _        <- Resource.liftF(l.info(s"created minio bucket"))
   } yield (config, s3Client)
 
@@ -58,6 +58,19 @@ final class S3MinIOTest extends PureharmTestWithResource {
     "GOOGLE_MURRAY_BOOKCHIN".getBytes(java.nio.charset.StandardCharsets.UTF_8)
   )
 
+  test("minio init bucket + list bucket") { case (config, client) =>
+    val newBucket = S3Bucket("testinitbucket")
+    for {
+      buckets <- client.listBuckets
+      _ = assert(buckets.contains(config.bucket))
+      att1: Attempt[Unit] <- client.initBucket(config.bucket).attempt
+      _ = assertSuccess(att1)(())
+      _ <- Resource.make(client.initBucket(newBucket))(_ => client.deleteBucket(newBucket).attempt.void).use { _ =>
+        client.listBuckets.map(bs => IO(assert(bs.contains(newBucket))))
+      }
+    } yield succeed
+  }
+
   test("minio put + get + delete") { case (config, client) =>
     for {
       _   <- l.info(s"acquired client resource: ${client.toString}")