don't try to reach into home dirs in tests

Author: pvsr

qbpm/operations.py

@@ -30,7 +30,7 @@ def from_session(
 def launch(
     profile: Profile, create: bool, foreground: bool, qb_args: tuple[str, ...]
 ) -> bool:
-    if not profiles.ensure_profile_exists(profile, create):
+    if not profiles.ensure_profile_exists(profile, create, desktop_file=True):
         return False
 
     args = profile.cmdline() + list(qb_args)

qbpm/profiles.py

@@ -57,12 +57,14 @@ def create_desktop_file(profile: Profile) -> None:
     desktop.write()
 
 
-def ensure_profile_exists(profile: Profile, create: bool = True) -> bool:
+def ensure_profile_exists(
+    profile: Profile, create: bool = True, desktop_file: bool = False
+) -> bool:
     if profile.root.exists() and not profile.root.is_dir():
         error(f"{profile.root} is not a directory")
         return False
     if not profile.root.exists() and create:
-        return new_profile(profile)
+        return new_profile(profile, desktop_file=desktop_file)
     if not profile.root.exists():
         error(f"{profile.root} does not exist")
         return False

tests/test_main.py

@@ -5,12 +5,14 @@
 
 from qbpm.main import main
 
+no_desktop = "--no-desktop-file"
+
 
 def test_profile_dir_option(tmp_path: Path):
     (tmp_path / "config.py").touch()
     runner = CliRunner()
     result = runner.invoke(
-        main, ["-C", str(tmp_path), "-P", str(tmp_path), "new", "test"]
+        main, ["-C", str(tmp_path), "-P", str(tmp_path), "new", no_desktop, "test"]
     )
     assert result.exit_code == 0
     assert result.output.strip() == str(tmp_path / "test")
@@ -21,7 +23,7 @@ def test_profile_dir_env(tmp_path: Path):
     environ["QBPM_PROFILE_DIR"] = str(tmp_path)
     (tmp_path / "config.py").touch()
     runner = CliRunner()
-    result = runner.invoke(main, ["-C", str(tmp_path), "new", "test"])
+    result = runner.invoke(main, ["-C", str(tmp_path), "new", no_desktop, "test"])
     assert result.exit_code == 0
     assert result.output.strip() == str(tmp_path / "test")
     assert tmp_path / "test" in list(tmp_path.iterdir())
@@ -32,7 +34,7 @@ def test_config_dir_option(tmp_path: Path):
     config = tmp_path / "config.py"
     config.touch()
     runner = CliRunner()
-    result = runner.invoke(main, ["-C", str(tmp_path), "new", "test"])
+    result = runner.invoke(main, ["-C", str(tmp_path), "new", no_desktop, "test"])
     assert result.exit_code == 0
     assert str(config) in (tmp_path / "test/config/config.py").read_text()
 
@@ -43,7 +45,7 @@ def test_relative_config_dir(tmp_path: Path):
     config.touch()
     chdir(tmp_path)
     runner = CliRunner()
-    result = runner.invoke(main, ["-C", ".", "new", "test"])
+    result = runner.invoke(main, ["-C", ".", "new", no_desktop, "test"])
     assert result.exit_code == 0
     assert str(config) in (tmp_path / "test/config/config.py").read_text()
 
@@ -54,7 +56,9 @@ def test_from_session(tmp_path: Path):
     session = tmp_path / "test.yml"
     session.write_text("windows:\n")
     runner = CliRunner()
-    result = runner.invoke(main, ["-C", str(tmp_path), "from-session", str(session)])
+    result = runner.invoke(
+        main, ["-C", str(tmp_path), "from-session", no_desktop, str(session)]
+    )
     assert result.exit_code == 0
     assert result.output.strip() == str(tmp_path / "test")
     assert (tmp_path / "test/data/sessions/_autosave.yml").read_text() == ("windows:\n")

tests/test_profiles.py

@@ -106,5 +106,5 @@ def test_ensure_profile_exists_create(tmp_path: Path):
 def test_new_profile(tmp_path: Path):
     (tmp_path / "config.py").touch()
     profile = Profile("test", tmp_path / "test", tmp_path)
-    assert profiles.new_profile(profile)
+    assert profiles.new_profile(profile, desktop_file=False)
     check_new_profile(profile)