make desktop file application name configurable

Author: pvsr

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.1
+  - `config.toml` supports `application_name` for generated XDG desktop files
+    - defaults to `{profile_name} (qutebrowser profile)`, you may want just `{profile_name}`
+    - `qbpm desktop` can be used to replace existing desktop files
+
 # 2.0
 ## config
 qbpm now reads configuration options from `$XDG_CONFIG_HOME/qbpm/config.toml`!

src/qbpm/config.py

@@ -20,6 +20,7 @@ class Config:
     qutebrowser_config_directory: Path | None = None
     profile_directory: Path = field(default_factory=paths.default_profile_dir)
     generate_desktop_file: bool = platform.system() == "Linux"
+    application_name: str = "{profile_name} (qutebrowser profile)"
     desktop_file_directory: Path = field(
         default_factory=paths.default_qbpm_application_dir
     )

src/qbpm/config.toml

@@ -17,11 +17,15 @@ config.load_autoconfig()
 # location of the qutebrowser config to inherit from
 # qutebrowser_config_directory = "~/.config/qutebrowser"
 
-# when creating a profile also generate an XDG desktop entry that launches the profile
+# when creating a profile also generate an XDG desktop file that launches the profile
 # defaults to true on linux
 # generate_desktop_file = false
 # desktop_file_directory = "~/.local/share/applications/qbpm"
 
+# application name in XDG desktop file (replace existing with `qbpm desktop PROFILE_NAME`) 
+# supported placeholders: {profile_name}
+# application_name = "{profile_name} (qutebrowser profile)"
+
 # profile selection menu for `qbpm choose`
 # when not set, qbpm will try to find a menu program on your $PATH
 # run `qbpm choose --help` for a list of known menu programs

src/qbpm/desktop.py

@@ -18,10 +18,13 @@
 ]
 
 
-def create_desktop_file(profile: Profile, application_dir: Path) -> None:
+def create_desktop_file(
+    profile: Profile, application_dir: Path, application_name: str
+) -> None:
+    application_name = application_name.format(profile_name=profile.name)
     text = textwrap.dedent(f"""\
         [Desktop Entry]
-        Name={profile.name} (qutebrowser profile)
+        Name={application_name}
         StartupWMClass=qutebrowser
         GenericName={profile.name}
         Icon=qutebrowser

src/qbpm/main.py

@@ -284,7 +284,9 @@ def desktop(
     profile = Profile(profile_name, config.profile_directory)
     exists = profiles.check(profile)
     if exists:
-        create_desktop_file(profile, config.desktop_file_directory)
+        create_desktop_file(
+            profile, config.desktop_file_directory, config.application_name
+        )
     exit_with(exists)
 
 

src/qbpm/profiles.py

@@ -123,7 +123,9 @@ def new_profile(
         if config.symlink_autoconfig:
             link_autoconfig(profile, qb_config_dir, overwrite)
         if config.generate_desktop_file:
-            create_desktop_file(profile, config.desktop_file_directory)
+            create_desktop_file(
+                profile, config.desktop_file_directory, config.application_name
+            )
         print(profile.root)
         return True
     return False

tests/test_desktop.py

@@ -1,6 +1,7 @@
 from pathlib import Path
 
 from qbpm import Profile
+from qbpm.config import Config
 from qbpm.desktop import create_desktop_file
 
 TEST_DIR = Path(__file__).resolve().parent
@@ -10,7 +11,15 @@ def test_create_desktop_file(tmp_path: Path):
     application_path = tmp_path / "applications"
     application_path.mkdir()
     profile = Profile("test", tmp_path)
-    create_desktop_file(profile, application_path)
+    create_desktop_file(profile, application_path, Config.load(None).application_name)
     assert (application_path / "test.desktop").read_text() == (
         TEST_DIR / "test.desktop"
     ).read_text().replace("{qbpm}", " ".join(profile.cmdline()))
+
+
+def test_custom_name(tmp_path: Path):
+    application_path = tmp_path / "applications"
+    application_path.mkdir()
+    profile = Profile("test", tmp_path)
+    create_desktop_file(profile, application_path, "test")
+    assert "Name=test\n" in (application_path / "test.desktop").read_text()