Expand idempotency flags on operations & operation tests.

Author: Fizzadar

pyinfra/operations/apt.py

@@ -325,7 +325,7 @@ def update(cache_time=None, touch_periodic=False, state=None, host=None):
 _update = update  # noqa: E305
 
 
-@operation
+@operation(is_idempotent=False)
 def upgrade(state, host):
     '''
     Upgrades all apt packages.

pyinfra/operations/mysql.py

@@ -19,7 +19,7 @@
 from pyinfra.facts.mysql import make_execute_mysql_command, make_mysql_command
 
 
-@operation
+@operation(is_idempotent=False)
 def sql(
     sql,
     database=None,
@@ -511,7 +511,7 @@ def privileges(
 _privileges = privileges  # noqa: E305 (for use where kwarg is the same)
 
 
-@operation
+@operation(is_idempotent=False)
 def dump(
     dest, database=None,
     # Details for speaking to MySQL via `mysql` CLI
@@ -547,7 +547,7 @@ def dump(
     ), dest)
 
 
-@operation
+@operation(is_idempotent=False)
 def load(
     src, database=None,
     # Details for speaking to MySQL via `mysql` CLI

pyinfra/operations/postgresql.py

@@ -17,7 +17,7 @@
 from pyinfra.facts.postgresql import make_execute_psql_command, make_psql_command
 
 
-@operation
+@operation(is_idempotent=False)
 def sql(
     sql,
     database=None,
@@ -235,7 +235,7 @@ def database(
         host.noop('postgresql database {0} exists'.format(database))
 
 
-@operation
+@operation(is_idempotent=False)
 def dump(
     dest, database=None,
     # Details for speaking to PostgreSQL via `psql` CLI
@@ -273,7 +273,7 @@ def dump(
     ), '>', dest)
 
 
-@operation
+@operation(is_idempotent=False)
 def load(
     src, database=None,
     # Details for speaking to PostgreSQL via `psql` CLI

pyinfra/operations/server.py

@@ -49,7 +49,7 @@
 from .util.files import chmod, sed_replace
 
 
-@operation
+@operation(is_idempotent=False)
 def reboot(delay=10, interval=1, reboot_timeout=300, state=None, host=None):
     '''
     Reboot the server and wait for reconnection.
@@ -102,7 +102,7 @@ def wait_and_reconnect(state, host):  # pragma: no cover
     yield FunctionCommand(wait_and_reconnect, (), {})
 
 
-@operation
+@operation(is_idempotent=False)
 def wait(port=None, state=None, host=None):
     '''
     Waits for a port to come active on the target machine. Requires netstat, checks every
@@ -128,7 +128,7 @@ def wait(port=None, state=None, host=None):
     '''.format(port)
 
 
-@operation
+@operation(is_idempotent=False)
 def shell(commands, state=None, host=None):
     '''
     Run raw shell code on server during a deploy. If the command would
@@ -155,7 +155,7 @@ def shell(commands, state=None, host=None):
         yield command
 
 
-@operation
+@operation(is_idempotent=False)
 def script(src, state=None, host=None):
     '''
     Upload and execute a local script on the remote host.
@@ -180,7 +180,7 @@ def script(src, state=None, host=None):
     yield temp_file
 
 
-@operation
+@operation(is_idempotent=False)
 def script_template(src, state=None, host=None, **data):
     '''
     Generate, upload and execute a local script template on the remote host.

pyinfra/operations/ssh.py

@@ -68,7 +68,7 @@ def _user_or_ssh_user(user, ssh_user):
     return user or ssh_user
 
 
-@operation
+@operation(is_idempotent=False)
 def command(hostname, command, user=None, port=22, ssh_user=None, state=None, host=None):
     '''
     Execute commands on other servers over SSH.
@@ -102,7 +102,7 @@ def command(hostname, command, user=None, port=22, ssh_user=None, state=None, ho
     yield 'ssh -p {0} {1} {2}'.format(port, connection_target, command)
 
 
-@operation
+@operation(is_idempotent=False)
 def upload(
     hostname, filename,
     remote_filename=None,

pyinfra/operations/yum.py

@@ -112,7 +112,7 @@ def rpm(src, present=True, state=None, host=None):
     yield ensure_rpm(state, host, files, src, present, 'yum')
 
 
-@operation
+@operation(is_idempotent=False)
 def update(state=None, host=None):
     '''
     Updates all yum packages.

tests/operations/apk.packages/upgrade_packages.json

@@ -9,5 +9,6 @@
     "commands": [
         "apk add curl"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/apk.packages/upgrade_update.json

@@ -13,5 +13,6 @@
         "apk update",
         "apk upgrade"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/apt.packages/update_upgrade.json

@@ -10,5 +10,6 @@
         "apt-get update",
         "DEBIAN_FRONTEND=noninteractive apt-get -y -o Dpkg::Options::=\"--force-confdef\" -o Dpkg::Options::=\"--force-confold\" upgrade"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/apt.packages/upgrade_packages.json

@@ -12,5 +12,6 @@
         "DEBIAN_FRONTEND=noninteractive apt-get -y -o Dpkg::Options::=\"--force-confdef\" -o Dpkg::Options::=\"--force-confold\" install another",
         "DEBIAN_FRONTEND=noninteractive apt-get -y -o Dpkg::Options::=\"--force-confdef\" -o Dpkg::Options::=\"--force-confold\" install git"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/brew.casks/add_casks_upgrade.json

@@ -11,5 +11,6 @@
         "brew cask upgrade",
         "brew cask install keepassxc"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/brew.packages/upgrade_packages.json

@@ -12,5 +12,6 @@
     "second_output_commands": [
         "brew upgrade php"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/brew.packages/upgrade_update.json

@@ -13,5 +13,6 @@
         "brew update",
         "brew upgrade"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/dnf.packages/update_clean.json

@@ -11,5 +11,6 @@
         "dnf clean all",
         "dnf update -y"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/pacman.packages/upgrade_update.json

@@ -16,5 +16,6 @@
         "pacman -Sy",
         "pacman --noconfirm -Su"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/pip.packages/install_requirements.json

@@ -6,5 +6,6 @@
     "commands": [
         "pip install -r requirements.txt"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "pip package requirements are always executed"
 }

tests/operations/pip.packages/install_virtualenv_requirements.json

@@ -11,5 +11,6 @@
     "commands": [
         "testdir/bin/pip install -r requirements.pip"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "pip package requirements are always executed"
 }

tests/operations/pip.packages/uninstall_requirements.json

@@ -7,5 +7,6 @@
     "commands": [
         "pip uninstall --yes -r requirements.txt"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "pip package requirements are always executed"
 }

tests/operations/puppet.agent/run_agent.json

@@ -6,5 +6,6 @@
     "commands": [
         "puppet agent -t --server=my-server.net --masterport=3006"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "puppet agent is always executed"
 }

tests/operations/python.call/call_func.json

@@ -6,5 +6,6 @@
     "commands": [
         ["__func__", ["arg1", "arg2"], {"hello": "world"}]
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "python callbacks are always executed"
 }

tests/operations/python.raise_exception/call_func.json

@@ -3,5 +3,6 @@
     "commands": [
         ["raise_exc", ["arg1", "arg2"], {}]
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "python callbacks are always executed"
 }

tests/operations/xbps.packages/upgrade_update.json

@@ -13,5 +13,6 @@
         "xbps-install -S",
         "xbps-install -y -u"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/yum.packages/update_clean.json

@@ -11,5 +11,6 @@
         "yum clean all",
         "yum update -y"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }

tests/operations/zypper.packages/update_clean.json

@@ -10,5 +10,6 @@
         "zypper clean --all",
         "zypper update -y"
     ],
-    "idempotent": false
+    "idempotent": false,
+    "disable_itempotent_warning_reason": "package upgrades are always executed"
 }