Fix visit_assign and visit_subscript to handle dictionary assignments #10053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 174882d |
|
Hi @chitvs, thanks for your contribution. Would you have the opportunity to look into the failing tests? Also, a regression test is required. You can browse recent PRs or the contributing docs for some pointers, and feel free to ask questions. |
Sure, I will. |
|
I looked at tests and my edits can't solve the issue, so I'm easily going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR addresses the handling of unsupported item assignments in nested dictionaries within the
visit_assignandvisit_subscriptmethods. It ensures that the code can handle cases where dictionaries are assigned to keys properly, preventing potential errors.Closes #10050