fix: address review findings from node constructor cleanup

1. FSCollector: fix double _imply_path call that would produce duplicate
   deprecation warnings when fspath is used. Now __init__ skips the
   _imply_path call when path is already resolved (by from_parent),
   using _check_path for consistency validation instead.

2. Function: remove dead keywords/fixtureinfo parameters from __init__
   since from_parent now pops them before calling super. Replace with
   **kw for forward-compatibility with additional kwargs.

Co-authored-by: Cursor AI <ai@cursor.sh>
Co-authored-by: Anthropic Claude <claude@anthropic.com>

Author: 3 people

src/_pytest/nodes.py

@@ -594,7 +594,13 @@ def __init__(
                 assert path is None
                 path = path_or_parent
 
-        path = _imply_path(type(self), path, fspath=fspath)
+        if path is not None:
+            # Path was already resolved (typically by from_parent); skip
+            # _imply_path to avoid a duplicate deprecation warning for fspath.
+            if fspath is not None:
+                _check_path(path, fspath)
+        else:
+            path = _imply_path(type(self), path, fspath=fspath)
         if name is None:
             name = self._derive_name(path, parent)
         self.path = path

src/_pytest/python.py

@@ -1580,12 +1580,11 @@ def __init__(
         config: Config | None = None,
         callspec: CallSpec2 | None = None,
         callobj=NOTSET,
-        keywords: Mapping[str, Any] | None = None,
         session: Session | None = None,
-        fixtureinfo: FuncFixtureInfo | None = None,
         originalname: str | None = None,
+        **kw,
     ) -> None:
-        super().__init__(name, parent, config=config, session=session)
+        super().__init__(name, parent, config=config, session=session, **kw)
 
         if callobj is not NOTSET:
             self._obj = callobj