Why OutcomeException is derived from BaseException (instead of Exception)?

[wangshangsam]

Hi,

I'm wondering why OutcomeException is derived from BaseException (instead of Exception)? Is it only because that any error derived from OutcomeException is not meant to be catched in try: ... except ...:, or is there any runtime-related or architectural reason that it has to be BaseException?

The reason why I'm asking this question is the following:

• I have been writting some tests to test a piece of Pulumi IaC code.
• In Pulumi, the language server drives a piece of Pulumi code (i.e., the self.program), which, in the case of the tests that I'm writing, contains pytest.raises(...).
• The language server catches all Exceptions (note: NOT BaseException which is a parent class of Exception) raised in the self.program and reports them.
• In the event where pytest.raises(...) is expecting an error but no error is raised in the code wrapped by pytest.raises(...), fail(self.message) is called and raises Failed
• Because Failed is a child class of OutcomeException which is a child class of BaseException, Pulumi's language server (which catches Exception as mentioned) isn't able to catch this error, which leads to Pulumi's automation runtime thinking self.program is fine even though it's not, which then leads to a deadlock.

Thanks!

[RonnyPfannschmidt]

Those are indeed derived from base exceptions to prevent accidental shallowing and catching

[wangshangsam]

Thanks a lot for the quick answer!

[The-Compiler]

See #580 (where this change was originally made) and #12235

[wangshangsam]

Really appreciate the references!