doctests failing when called without "file_or_dir"

[ThomasLecocq]

Hi all,

We are using pytest for a number of years for obspy, the tests are usually called by an entry-point script "obspy-runtests" that calls pytest.main() (with additional pytest-json-report too).

Between mid july and now, there must have been a change "somewhere" that makes all our CIs go 🔴 for the doctests.

The failed tests all concern doctests' outputs, which don't respect the numpy.set_printoptions(legacy="1.13") stated in the conftest.py and which is well applied and passed to the tests.

The obspy-runtests changes directory to the library root/obspy, so the following commads are run there too:

checking if core\__init__.py doctest pass:

• python -m pytest --doctest-modules --json-report 🔴
• python -m pytest core\ --doctest-modules --json-report ✅
• pytest.exe --doctest-modules 🔴
• pytest.exe core/ --doctest-modules ✅

So the error comes between calling pytest WITH or WITHOUT a target directory.

I tried downgrading pytest to 7.4.4, pytest-json-report & numpy & scipy etc... no avail. Same errors. So I believe it's indeed not a pyest error but I'm hoping someone would have encountered a similar issue and could help?

Thanks for any input!

Thomas

(ref: obspy/obspy#3600)

[ThomasLecocq]

Edit, trying some more stuff:

for core\__init__.py , this works:

python -m pytest core\ --doctest-modules --json-report

but using the same command, the \core\utils\obspy_types.py fails for doctest, while it passes using

python -m pytest core\utils --doctest-modules --json-report

From this, it looks like the numpy legacy stuff is not passed "to subfolders" ? uh?

[ThomasLecocq]

edit again, sorry for the noise, it's probably an obspy-obspy issue, the doctest issues are only with obspy objects __str__ and __repr__ methods, which seemingly don't inherit the legacy printing...

[ThomasLecocq]

Final solution: as it was linked to how chunking of the tests (either using directories, or using xdist), I started to search in dependencies... and found the culprit in pyshp 3.0 :

doctest.NORMALIZE_WHITESPACE = 1
https://github.com/GeospatialPython/pyshp/blob/master/src/shapefile.py#L55-L56

Which, I guess, gets defined everywhere & for everything. Will report.

[ThomasLecocq]

if anyone has an idea how to re-set the default value after that import, that would be useful, I believe ...