Prevent readline from bugging out when the editline backend is used
#12961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous history:
It would probably reintroduce the |
Yeah I was thinking the same. We shouldn't expect Should we investigate on why we get this failure with the |
|
It might be worth having a minimal reproducer so this could be reported to CPython or libedit - other than that, if the workaround works, I think it's fine to use it as-is and close the issue with it. Seems harmless enough to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12888.
Seems like having
readline(orrlcompleter, which importsreadline) imported at the root of thepdbmodule (as it is on 3.13) introduces the issue, but I'm not sure why. Perhaps thelibeditbackend tries to read something from stdin on startup? (Because runningpytest -sworks).