add eager_start to create_task

Author: graingert

Lib/asyncio/base_events.py

@@ -458,24 +458,26 @@ def create_future(self):
         """Create a Future object attached to the loop."""
         return futures.Future(loop=self)
 
-    def create_task(self, coro, *, name=None, context=None):
+    def create_task(self, coro, *, name=None, context=None, eager=None):
         """Schedule a coroutine object.
 
         Return a task object.
         """
         self._check_closed()
         if self._task_factory is None:
-            task = tasks.Task(coro, loop=self, name=name, context=context)
+            task = tasks.Task(coro, loop=self, name=name, context=context, eager_start=eager_start)
             if task._source_traceback:
                 del task._source_traceback[-1]
         else:
-            if context is None:
+            if context is None and eager_start is None:
                 # Use legacy API if context is not needed
                 task = self._task_factory(self, coro)
-            else:
+                task.set_name(name)
+            elif eager_start is None:
                 task = self._task_factory(self, coro, context=context)
-
-            task.set_name(name)
+                task.set_name(name)
+            else:
+                task = self._task_factory(self, coro, context=context, eager=eager_start, name=name)
 
         return task
 

Lib/asyncio/taskgroups.py

@@ -178,7 +178,7 @@ async def _aexit(self, et, exc):
                 exc = None
 
 
-    def create_task(self, coro, *, name=None, context=None):
+    def create_task(self, coro, *, name=None, context=None, eager_start=None):
         """Create a new task in this group and return it.
 
         Similar to `asyncio.create_task`.
@@ -192,10 +192,12 @@ def create_task(self, coro, *, name=None, context=None):
         if self._aborting:
             coro.close()
             raise RuntimeError(f"TaskGroup {self!r} is shutting down")
-        if context is None:
+        if context is None and eager_start is None:
             task = self._loop.create_task(coro, name=name)
-        else:
+        elif eager_start is None:
             task = self._loop.create_task(coro, name=name, context=context)
+        else:
+            task = self._loop.create_task(coro, name=name, context=context, eager_start=eager_start)
 
         # optimization: Immediately call the done callback if the task is
         # already done (e.g. if the coro was able to complete eagerly),

Lib/asyncio/tasks.py

@@ -384,7 +384,7 @@ def __wakeup(self, future):
     Task = _CTask = _asyncio.Task
 
 
-def create_task(coro, *, name=None, context=None):
+def create_task(coro, *, name=None, context=None, eager_start=None):
     """Schedule the execution of a coroutine object in a spawn task.
 
     Return a Task object.
@@ -393,8 +393,10 @@ def create_task(coro, *, name=None, context=None):
     if context is None:
         # Use legacy API if context is not needed
         task = loop.create_task(coro, name=name)
-    else:
+    elif eager_start is None:
         task = loop.create_task(coro, name=name, context=context)
+    else:
+        task = loop.create_task(coro, name=name, context=context, eager_start)
 
     return task
 
@@ -1008,9 +1010,11 @@ def create_eager_task_factory(custom_task_constructor):
         used. E.g. `loop.set_task_factory(asyncio.eager_task_factory)`.
         """
 
-    def factory(loop, coro, *, name=None, context=None):
+    def factory(loop, coro, *, name=None, context=None, eager_start=None):
+        if eager_start is None:
+            eager_start = True
         return custom_task_constructor(
-            coro, loop=loop, name=name, context=context, eager_start=True)
+            coro, loop=loop, name=name, context=context, eager_start=eager_start)
 
     return factory