-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 750 -- Template Strings #275
Comments
Hi, just checking -- is everything "in order" as far as what we needed to do on this submission? |
We haven't gotten to this one yet, it is next up on our schedule for us to discuss internally next week. |
We have posted a pre-acceptance message here: https://discuss.python.org/t/pep750-template-strings-new-updates/71594/118 |
Thank you all for your patience. As discussed, before we can grant final acceptance, we request the following specific changes to the PEP: 1. Clarify Iteration Order for Template PartsPlease enhance the section on 2. Add to Rejected Ideas SectionIn the "Rejected Ideas" section under "Enable Full Reconstruction of Original Template Literal," please clarify better (with some more examples) that reconstructing the original string is also difficult because the transformation is not 1-to-1 from source to AST. This additional point will help explain why perfect roundtripping is not feasible. 3. Specify Module LocationWe've decided that the 4. Use Fully Spelled Out Attribute NamesPlease rename the abbreviated attributes in the We believe these changes will improve the clarity and usability of the PEP and its implementation. Once these modifications are made, we will be happy to grant final acceptance. You can make these changes in parallel to the implementation (so don't wait until the PEP is modified and is officially approved to propose and iterate over the PR). But landing the PR requires the PEP approved. |
Thanks @pablogsal for the update! And: understood on all changes. I'll make a first pass at all of these this upcoming week and will mention it here on the PR. Exciting! |
Thanks @pablogsal and SC for the thoughtful feedback.
Should we also rename |
@pablogsal We opened a new PEP 750 PR today. It attempts to address all four requests. Thanks to @AA-Turner for the quick review! We'd love the Steering Council's feedback on it, too. 🎉 (PS: In addition, the pep750 examples repo has been updated to match the latest version of the PEP.) |
The Steering Council reviewed today python/peps#4351 and we are happy with the changes so we are formally approving the PEP. Congratulations yet again! :) |
Please consider PEP 750 -- Template Strings
https://peps.python.org/pep-0750/
Post-History
headerPost-History
)SIG-specific:
A few related expressions of support for this PEP:
Alyssa Coughlin: "The proposal in PEP 750 covers the use cases that PEP 501 set out to cover. Where there are differences in the scope and technical details, they are well justified in PEP 750’s favour (hence the withdrawal of PEP 501 during the PEP 750 discussions).”
Phil Jones: "I’d like to express my support as I would like to use template strings to build SQL queries and I’ve recently written SQL-tString in anticipation.”
Nicholas Tollervey: “The capabilities PEP 750 brings would be wonderful for PyScript, and I want to make sure Damien has a heads up so MicroPython and Pyodide have some sort of parity.” (Note: a core PyScript implementer has been working with us on a template language.)
The authors also had meetings with Barry Warsaw (flufl.i18n), David Lord (Jinja), and Andreas Pelme (htpy).
Thanks again for your time & consideration! :-)
The text was updated successfully, but these errors were encountered: