-
Notifications
You must be signed in to change notification settings - Fork 4
do videos and votes #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Lateef, thanks for merging those commits earlier!! :) I was looking at our code and was a little confused about what we're actually returning at the end of those classmethods. Can you help me re-write the tests in RTCtest.py to see if they are returning the clips specific to the floor videos? |
I hadn't finished writing the test code I hadn't finished figuring out how that get_bill was going to work. The test code in RTCTest.py didn't really give me an idea of what we needed to validate. I was going to make a list of required params and validate they existed in the result set. What fields do you think we should validate get returned? Any other suggestions of things we should assert based on the get_by_bill? (FYI I miss clicked on closing the issue) |
Lateef, Here is something that we probably need to check for: We query set of house video's based on a bill_id mentioned in those long 10 hour videos. They contain multiple clips (which just specify the time offsets). The query for the bill_id is specific to the house videos, not the clips.
ie: we don't want to return a clip that has nothing to do with the bill |
Yeah I added that filter will push this morning.
|
No description provided.
The text was updated successfully, but these errors were encountered: