Skip to content

do videos and votes #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlaviuSim opened this issue Sep 20, 2011 · 4 comments
Open

do videos and votes #8

FlaviuSim opened this issue Sep 20, 2011 · 4 comments
Assignees
Milestone

Comments

@FlaviuSim
Copy link
Member

No description provided.

@ghost ghost assigned lateefj Sep 20, 2011
@mhjohnson
Copy link
Member

Lateef, thanks for merging those commits earlier!! :) I was looking at our code and was a little confused about what we're actually returning at the end of those classmethods. Can you help me re-write the tests in RTCtest.py to see if they are returning the clips specific to the floor videos?

@lateefj lateefj closed this as completed Sep 21, 2011
@lateefj lateefj reopened this Sep 21, 2011
@lateefj
Copy link
Member

lateefj commented Sep 21, 2011

I hadn't finished writing the test code I hadn't finished figuring out how that get_bill was going to work. The test code in RTCTest.py didn't really give me an idea of what we needed to validate. I was going to make a list of required params and validate they existed in the result set. What fields do you think we should validate get returned? Any other suggestions of things we should assert based on the get_by_bill? (FYI I miss clicked on closing the issue)

@mhjohnson
Copy link
Member

Lateef,

Here is something that we probably need to check for: We query set of house video's based on a bill_id mentioned in those long 10 hour videos. They contain multiple clips (which just specify the time offsets). The query for the bill_id is specific to the house videos, not the clips.

  1. There are multiple clips in each video; some of those clips do not relate to the bill_id that was queried.
  2. We have to filter out the clips that do not related to the bill_id from each video object
  3. Therefore, we need to test are final result: the bill_id must appear in the array for each clip

ie: we don't want to return a clip that has nothing to do with the bill

@lateefj
Copy link
Member

lateefj commented Sep 22, 2011

Yeah I added that filter will push this morning.
On Sep 22, 2011 1:31 AM, "Matthew Johnson" <
[email protected]>
wrote:

Lateef,

Here is something that we probably need to check for: We query set of
house video's based on a bill_id mentioned in those long 10 hour videos.
They contain multiple clips (which just specify the time offsets). The query
for the bill_id is specific to the house videos, not the clips.

  1. There are multiple clips in each video; some of those clips do not
    relate to the bill_id that was queried.
  2. We have to filter out the clips that do not related to the bill_id from
    each video object
  3. Therefore, we need to test are final result: the bill_id must appear in
    the array for each clip

ie: we don't want to return a clip that has nothing to do with the bill

Reply to this email directly or view it on GitHub:

#8 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants