fix: structured inputs for CudaGraphsTorchTensorRTModule #3407
+105
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: api [Python]
keehyuna
force-pushed
the
kwargs_cudagraphs
branch
from
ebaacff to
15df89f
Compare
keehyuna
requested review from
narendasan,
peri044 and
cehongwang
and removed request for
gs-olive
narendasan
reviewed
Feb 28, 2025
keehyuna
commented
Mar 2, 2025
| @@ -290,10 +291,6 @@ def test_weight_streaming_cudagraphs(self, _, use_python_runtime): | |||
| ("cpp_runtime", False), | |||
| ] | |||
| ) | |||
| @unittest.skipIf( | |||
There was a problem hiding this comment.
this test took 80sec on rtx4080
There was a problem hiding this comment.
Feel free to create a new runner instance for tests like these if you feel its taking too long
There was a problem hiding this comment.
I think it looks fine. according to log, it was running under Test torch compile backend test, which took 12 minutes.
|
@keehyuna can you resolve the conflict then we can merge? |
keehyuna
force-pushed
the
kwargs_cudagraphs
branch
from
16d3ac8 to
9ec010a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for structured inputs in CudaGraphsTorchTensorRTModule using torch's tree utilities to properly handle both args and kwargs input
Fixes #3406
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: