Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking removal of the set_inductor_config argument from quantize_ #1715

Open
vkuzo opened this issue Feb 14, 2025 · 0 comments
Open

tracking removal of the set_inductor_config argument from quantize_ #1715

vkuzo opened this issue Feb 14, 2025 · 0 comments
Assignees

Comments

@vkuzo
Copy link
Contributor

vkuzo commented Feb 14, 2025

summary

We are migrating the set_inductor_config argument of quantize_ to individual workflows. Motivation:

  1. this functionality was intended for inference, and we don't want to expose it to future training workflows that we plan to add to quantize_.
  2. higher level, this flag couples torchao workflows with torch.compile, which is not ideal. We would rather keep these systems decoupled at the quantize_ API level, with individual workflows opting in as needed.

API changes

# torchao v0.8.x
def quantize_(
    ...,
    set_inductor_config: bool = True,
    ...,
): ...

# torchao v.0.9.0
def quantize_(
    ...,
    set_inductor_config: Optional[bool] = None,
    ...,
):
    # if set_inductor_config != None, throw a deprecation warning
    # if set_inductor_config == None, set it to True to stay consistent with old behavior

# torchao v TBD (a future release)
def quantize_(
    ...,
):
    # set_inductor_config is removed from quantize_ and moved to relevant individual workflows
@vkuzo vkuzo self-assigned this Feb 14, 2025
vkuzo added a commit that referenced this issue Feb 14, 2025
…tion

Summary:

We want to migrate this to individual workflows, see #1715 for migration plan.

This PR is step 1 where we enable distinguishing whether the user
specified this argument or not.  After this PR, we can control the
behavior per-workflow, such as setting this functionality to False for
future training workflows.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:
vkuzo added a commit that referenced this issue Feb 14, 2025
…tion

Summary:

We want to migrate this to individual workflows, see #1715 for migration plan.

This PR is step 1 where we enable distinguishing whether the user
specified this argument or not.  After this PR, we can control the
behavior per-workflow, such as setting this functionality to False for
future training workflows.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:
vkuzo added a commit that referenced this issue Feb 14, 2025
…tion

Summary:

We want to migrate this to individual workflows, see #1715 for migration plan.

This PR is step 1 where we enable distinguishing whether the user
specified this argument or not.  After this PR, we can control the
behavior per-workflow, such as setting this functionality to False for
future training workflows.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:
vkuzo added a commit that referenced this issue Feb 14, 2025
make quantize_.set_inductor_config None by default for future deprecation

Summary:

We want to migrate this to individual workflows, see #1715 for migration plan.

This PR is step 1 where we enable distinguishing whether the user
specified this argument or not.  After this PR, we can control the
behavior per-workflow, such as setting this functionality to False for
future training workflows.

Test Plan: CI

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant