Skip to content

Commit dc8a31a

Browse files
committed
Target link tokenizers library
1 parent 173308e commit dc8a31a

File tree

2 files changed

+13
-34
lines changed

2 files changed

+13
-34
lines changed

examples/models/llama/runner/CMakeLists.txt

+12-33
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,6 @@ target_include_directories(
4141
extension_module INTERFACE ${_common_include_directories}
4242
)
4343

44-
list(
45-
APPEND _llama_runner__srcs
46-
${EXECUTORCH_ROOT}/extension/llm/tokenizers/src/tiktoken.cpp
47-
)
48-
list(APPEND _llama_runner__srcs
49-
${CMAKE_CURRENT_SOURCE_DIR}/../tokenizer/llama_tiktoken.cpp
50-
)
51-
5244
if(CMAKE_TOOLCHAIN_IOS
5345
OR ANDROID
5446
OR APPLE
@@ -60,32 +52,8 @@ else()
6052
add_library(llama_runner SHARED ${_llama_runner__srcs})
6153
endif()
6254

63-
# find RE2 for tokenizer, build tiktoken
64-
set(ABSL_ENABLE_INSTALL ON)
65-
set(ABSL_PROPAGATE_CXX_STD ON)
66-
set(_pic_flag ${CMAKE_POSITION_INDEPENDENT_CODE})
67-
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
68-
add_subdirectory(
69-
${EXECUTORCH_ROOT}/extension/llm/tokenizers/third-party/abseil-cpp
70-
${CMAKE_CURRENT_BINARY_DIR}/abseil-cpp
71-
)
72-
add_subdirectory(
73-
${EXECUTORCH_ROOT}/extension/llm/tokenizers/third-party/re2
74-
${CMAKE_CURRENT_BINARY_DIR}/re2
75-
)
76-
add_subdirectory(
77-
${EXECUTORCH_ROOT}/extension/llm/tokenizers/third-party/json
78-
${CMAKE_CURRENT_BINARY_DIR}/json
79-
)
80-
target_include_directories(llama_runner
81-
PRIVATE ${CMAKE_INSTALL_PREFIX}/include
82-
${EXECUTORCH_ROOT}/extension/llm/tokenizers/third-party/llama.cpp-unicode/include
83-
${EXECUTORCH_ROOT}/extension/llm/tokenizers/third-party/llama.cpp-unicode/src
84-
)
85-
set(CMAKE_POSITION_INDEPENDENT_CODE ${_pic_flag})
86-
8755
set(llama_runner_deps executorch extension_data_loader extension_module
88-
extension_tensor re2::re2 nlohmann_json::nlohmann_json
56+
extension_tensor
8957
)
9058

9159
target_link_libraries(llama_runner PUBLIC ${llama_runner_deps})
@@ -94,6 +62,17 @@ target_include_directories(
9462
llama_runner
9563
INTERFACE ${_common_include_directories}
9664
)
65+
66+
# Include tokenizers dependency
67+
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
68+
add_subdirectory(
69+
${EXECUTORCH_ROOT}/extension/llm/tokenizers
70+
${CMAKE_CURRENT_BINARY_DIR}/tokenizers
71+
)
72+
target_link_libraries(
73+
llama_runner PUBLIC tokenizers
74+
)
75+
9776
target_include_directories(
9877
llama_runner
9978
PUBLIC ${EXECUTORCH_ROOT}/extension/llm/tokenizers/include

extension/llm/runner/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,4 @@ target_include_directories(
5959
target_include_directories(
6060
extension_llm_runner INTERFACE ${_common_include_directories}
6161
${EXECUTORCH_ROOT}/extension/llm/tokenizers/include
62-
)
62+
)

0 commit comments

Comments
 (0)