Skip to content

Commit 0c8ede0

Browse files
scottsmeta-codesync[bot]
authored andcommitted
remove the rocprofiler early exit hack (#1329)
Summary: Pull Request resolved: #1329 Remove the early exit hack because it seems to be doing more harm than good. Reviewed By: joebos Differential Revision: D98163400 fbshipit-source-id: 0520833b4b743a403f23297eb3dbba837cca029f
1 parent 4826a43 commit 0c8ede0

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

libkineto/src/RocprofLogger.cpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -271,13 +271,6 @@ GlobalContext& getGlobalContext() {
271271
return instance;
272272
}
273273

274-
// FIXME: This is a hack to skip rocprofiler-sdk's atexit cleanup. It sometimes
275-
// crashes due to accessing unmapped library memory. This is likely a bug in
276-
// rocprofiler-sdk.
277-
static void earlyExit() {
278-
_exit(0);
279-
}
280-
281274
std::vector<rocprofiler_agent_v0_t> get_gpu_device_agents() {
282275
std::vector<rocprofiler_agent_v0_t> agents;
283276

@@ -440,10 +433,6 @@ int RocprofLogger::toolInit(
440433
}
441434
rocprofiler_stop_context(globalContext.context);
442435

443-
// Register a special callback that forces an early exit to avoid
444-
// calling rocprofiler-sdk's exit handler as it sometimes segfaults.
445-
std::atexit(earlyExit);
446-
447436
return 0;
448437
}
449438

0 commit comments

Comments
 (0)