Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [REQUEST] - Port TorchRL "Coding a DDPG loss" from pytorch.org/rl to pytorch.org/tutorials #2351

Closed
vmoens opened this issue May 26, 2023 · 2 comments · Fixed by #2413
Closed
Assignees
Labels
docathon-h1-2023 A label for the docathon in H1 2023 medium rl Issues related to reinforcement learning tutorial, DQN, and so on

Comments

@vmoens
Copy link
Contributor

vmoens commented May 26, 2023

🚀 Descirbe the improvement or the new tutorial

For historical reasons, TorchRL privately hosts a bunch of tutorials.
We'd like to bring the most significant ones to pytorch tutorials for more visibility.

Here is the tutorial.
TorchRL splits down what is commonly referred to as Agents in other frameworks into various pieces that echo what can be found in other domains: data collection, datasets, transforms and losses. A dedicated class named LossModule covers this last functionality. We have a tutorial that instructs users on how to build and use such classes, you can help us port it to pytorch tutorials!

Steps:

  1. Port the tutorial from the RL repo to the tutorials repo.
  2. Fix any formatting issues or typos.
  3. Make sure the tutorial follows the tutorial template (template_tutorial.py)
  4. Preserve the original author

Existing tutorials on this topic

No response

Additional context

The tutorial should not require extra dependencies beyond those already present in requirements.txt

cc @nairbv

@svekars svekars added rl Issues related to reinforcement learning tutorial, DQN, and so on medium docathon-h1-2023 A label for the docathon in H1 2023 labels May 30, 2023
nairbv added a commit to nairbv/tutorials that referenced this issue Jun 2, 2023
Port existing tutorial from torchrl to pytorch.org.

pytorch#2351
@svekars
Copy link
Contributor

svekars commented Jun 2, 2023

@nairbv Can you please assign this issue to yourself as described in #2350

@nairbv
Copy link
Contributor

nairbv commented Jun 2, 2023

/assigntome

nairbv added a commit to nairbv/tutorials that referenced this issue Jun 5, 2023
Port existing tutorial from torchrl to pytorch.org.

pytorch#2351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docathon-h1-2023 A label for the docathon in H1 2023 medium rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants