Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge symbol advanced "buffer extents" and "buffer settings" options #60010

Open
DelazJ opened this issue Dec 24, 2024 · 3 comments
Open

Merge symbol advanced "buffer extents" and "buffer settings" options #60010

DelazJ opened this issue Dec 24, 2024 · 3 comments
Labels
Feature Request Symbology Related to vector layer symbology or renderers

Comments

@DelazJ
Copy link
Contributor

DelazJ commented Dec 24, 2024

Feature description

#58228 introduced in 3.40 ability to add buffer to marker symbols.
#59630 is introducing (in 3.42) ability to set an extent buffer per symbol.
Both features are available through the "Advanced" drop down menu of a symbol layer, opening a dedicated dialog when you click on the entry
buffers

I know these are two separate features but can we consider merging both in a single "Buffer settings" entry? I find it puzzling to have two entries for buffer, there.

@nyalldawson @JuhoErvasti ?

Additional context

No response

@DelazJ DelazJ added Symbology Related to vector layer symbology or renderers Feature Request labels Dec 24, 2024
@nyalldawson
Copy link
Collaborator

They both do COMPLETELY different things. One is a visible buffer akin to label buffers, the other is about filtering feature. I think the second should be renamed if there's confusion.

@baswein
Copy link
Contributor

baswein commented Jan 3, 2025

I also think this might cause some confusion with my students. Buffer is how we are getting the expanded extent but the larger extent is the important part.

Ideas for Extent Buffer...:
Render Inclusion Extent...
Feature Inclusion Distance...
Feature Render Buffer...
Map Extent Buffer...
Render Extent...

Ideas for Buffer Settings...:
Marker Buffer...
Symbol Halo...

@JuhoErvasti
Copy link
Contributor

JuhoErvasti commented Jan 8, 2025

In my opinion it doesn't make sense to group them in the same menu since they do entirely different things, but I think that renaming the extent buffer to something else is a good idea if it causes confusion.

One point about @baswein's suggestions, I think if the name is to be changed the new name should convey (as some of the suggestions do) that it is specifically a buffer to the existing map extent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Symbology Related to vector layer symbology or renderers
Projects
None yet
Development

No branches or pull requests

4 participants