Add missing checks in expect

Author: david-pl

Project.toml

@@ -1,6 +1,6 @@
 name = "QuantumOpticsBase"
 uuid = "4f57444f-1401-5e15-980d-4471b28d5678"
-version = "v0.2.5"
+version = "v0.2.6"
 
 [deps]
 FFTW = "7a1cc6ca-52ef-59f5-83cd-3a7055c09341"

src/operators_dense.jl

@@ -152,6 +152,7 @@ function expect(op::DataOperator{B,B}, state::Ket{B}) where B<:Basis
 end
 
 function expect(op::DataOperator{B1,B2}, state::DataOperator{B2,B2}) where {B1<:Basis,B2<:Basis}
+    check_samebases(op, state)
     result = zero(promote_type(eltype(op),eltype(state)))
     @inbounds for i=1:size(op.data, 1), j=1:size(op.data,2)
         result += op.data[i,j]*state.data[j,i]

src/operators_sparse.jl

@@ -40,6 +40,7 @@ function ptrace(op::SparseOpPureType, indices::Vector{Int})
 end
 
 function expect(op::SparseOpPureType{B1,B2}, state::Operator{B2,B2}) where {B1<:Basis,B2<:Basis}
+    check_samebases(op, state)
     result = zero(promote_type(eltype(op),eltype(state)))
     @inbounds for colindex = 1:op.data.n
         for i=op.data.colptr[colindex]:op.data.colptr[colindex+1]-1

test/test_operators_dense.jl

@@ -249,6 +249,8 @@ state = randoperator(b_l)
 @test expect(2, op2, state) ≈ expect(op2, ptrace(state, [1, 3]))
 @test expect(3, op3, state) ≈ expect(op3, ptrace(state, [1, 2]))
 
+@test_throws QuantumOpticsBase.IncompatibleBases expect(op2, op1)
+
 # Permute systems
 op1 = randoperator(b1a, b1b)
 op2 = randoperator(b2a, b2b)

test/test_operators_sparse.jl

@@ -150,6 +150,7 @@ state = randstate(b_l)
 state = randoperator(b_l)
 @test expect(op123, state) ≈ expect(op123_, state)
 
+@test_throws QuantumOpticsBase.IncompatibleBases expect(op1, op2)
 
 # Tensor product
 # ==============