Skip to content

Commit 2f54d93

Browse files
committed
do not use virtual threads when a SecurityManager is set
When running with a SecurityManager set, virtual threads have no permissions (https://openjdk.org/jeps/444). => Virtual threads must not be used otherwise AccessControlExceptions will be raised during file manipulations. 09:50:57,825 |-ERROR in c.q.l.core.rolling.TimeBasedRollingPolicy@1645547422 - Unexpected exception while waiting for compression job to finish java.util.concurrent.ExecutionException: java.security.AccessControlException: access denied ("java.io.FilePermission" "/path/to/logs/business.2024-06-12-0949.log8596119935863.tmp" "read") at java.util.concurrent.ExecutionException: java.security.AccessControlException: access denied ("java.io.FilePermission" "/path/to/logs/business.2024-06-12-0949.log8596119935863.tmp" "read") at at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122) at at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:205) at at ch.qos.logback.core.rolling.TimeBasedRollingPolicy.waitForAsynchronousJobToStop(TimeBasedRollingPolicy.java:140) at at ch.qos.logback.core.rolling.TimeBasedRollingPolicy.stop(TimeBasedRollingPolicy.java:132) at at ch.qos.logback.core.rolling.RollingFileAppender.stop(RollingFileAppender.java:159) at at ch.qos.logback.core.spi.AppenderAttachableImpl.detachAndStopAllAppenders(AppenderAttachableImpl.java:107) at at ch.qos.logback.classic.Logger.detachAndStopAllAppenders(Logger.java:209) at at ch.qos.logback.classic.Logger.recursiveReset(Logger.java:333) at at ch.qos.logback.classic.Logger.recursiveReset(Logger.java:340) at at ch.qos.logback.classic.LoggerContext.reset(LoggerContext.java:363) at at ch.qos.logback.classic.LoggerContext.stop(LoggerContext.java:343) at at org.springframework.boot.logging.logback.LogbackLoggingSystem.lambda$getShutdownHandler$2(LogbackLoggingSystem.java:391) at at java.base/java.lang.Iterable.forEach(Iterable.java:75) at at org.springframework.boot.SpringApplicationShutdownHook.run(SpringApplicationShutdownHook.java:116) at at java.base/java.lang.Thread.run(Thread.java:1583) Caused by: java.security.AccessControlException: access denied ("java.io.FilePermission" "/path/to/logs/business.2024-06-12-0949.log8596119935863.tmp" "read") at at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:488) at at java.base/java.security.AccessController.checkPermission(AccessController.java:1071) at at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:411) at at java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:742) at at java.base/java.io.File.exists(File.java:831) at at ch.qos.logback.core.rolling.helper.Compressor.gzCompress(Compressor.java:148) at at ch.qos.logback.core.rolling.helper.Compressor.compress(Compressor.java:57) at at ch.qos.logback.core.rolling.helper.Compressor$CompressionRunnable.run(Compressor.java:246) at at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572) at at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) at at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) at at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) at at java.base/java.lang.VirtualThread.run(VirtualThread.java:309)
1 parent 7812a55 commit 2f54d93

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

logback-core/src/main/java21/ch/qos/logback/core/util/ExecutorServiceUtil.java

+17-5
Original file line numberDiff line numberDiff line change
@@ -34,20 +34,28 @@
3434
* @author Mikhail Mazursky
3535
*/
3636
public class ExecutorServiceUtil {
37+
38+
private static final boolean NO_SECURITY_MANAGER = System.getSecurityManager() == null;
39+
3740
private static final ThreadFactory THREAD_FACTORY_FOR_SCHEDULED_EXECUTION_SERVICE = new ThreadFactory() {
3841

3942
private final AtomicInteger threadNumber = new AtomicInteger(1);
4043

4144
private final ThreadFactory defaultFactory = makeThreadFactory();
4245

4346
/**
44-
* A thread factory which may be a virtual thread factory the JDK supports it.
47+
* A thread factory which may be a virtual thread factory if the JDK supports it
48+
* and there is no security manager.
4549
*
4650
* @return
4751
*/
4852
private ThreadFactory makeThreadFactory() {
49-
ThreadFactory tf = Thread.ofVirtual().factory();
50-
return tf;
53+
if (NO_SECURITY_MANAGER) {
54+
ThreadFactory tf = Thread.ofVirtual().factory();
55+
return tf;
56+
}
57+
58+
return Executors.defaultThreadFactory();
5159
}
5260

5361
@Override
@@ -99,11 +107,15 @@ static public void shutdown(ExecutorService executorService) {
99107

100108
/**
101109
* An alternate implementation of {@linl #newThreadPoolExecutor} which returns a virtual thread per task executor
102-
* when available.
110+
* if the JDK supports it and there is no security manager.
103111
*
104112
* @since 1.3.12/1.4.12
105113
*/
106114
static public ExecutorService newAlternateThreadPoolExecutor() {
107-
return Executors.newVirtualThreadPerTaskExecutor();
115+
if (NO_SECURITY_MANAGER) {
116+
return Executors.newVirtualThreadPerTaskExecutor();
117+
}
118+
119+
return newThreadPoolExecutor();
108120
}
109121
}

0 commit comments

Comments
 (0)