Skip to content

Commit 411ae6d

Browse files
jrpricemibrunin
authored andcommitted
[Backport] Security bug 378725734 (1/2)
Cherry-pick of patch originally reviewed on https://dawn-review.googlesource.com/c/dawn/+/214754: Validate layout constraints for all address spaces The WGSL spec has a non-normative note that the layout constraints should be validated for all non-host-shareable address spaces, using the same constraints as for storage. See linked bug for details of why this is important. Bug: 378725734 Change-Id: I3fb02506d8ded000dc3510bdc1b4a24a95089281 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/214754 Reviewed-by: David Neto <[email protected]> Commit-Queue: James Price <[email protected]> Reviewed-by: dan sinclair <[email protected]> Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/609219 Reviewed-by: Anu Aliyas <[email protected]>
1 parent a352967 commit 411ae6d

File tree

1 file changed

+0
-4
lines changed
  • chromium/third_party/dawn/src/tint/lang/wgsl/resolver

1 file changed

+0
-4
lines changed

chromium/third_party/dawn/src/tint/lang/wgsl/resolver/validator.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -493,10 +493,6 @@ bool Validator::AddressSpaceLayout(const core::type::Type* store_ty,
493493
return true;
494494
}
495495

496-
if (!core::IsHostShareable(address_space)) {
497-
return true;
498-
}
499-
500496
auto note_usage = [&] {
501497
AddNote("'" + store_ty->FriendlyName() + "' used in address space '" +
502498
tint::ToString(address_space) + "' here",

0 commit comments

Comments
 (0)