Skip to content

Commit 8122be0

Browse files
authored
Small clean ups in the tests (#8323)
Remove unnecessary imports from `setup_code` statements for `assert_equivalent_repr` and `assert_implements_consistent_protocols`. Also remove a few leftover debugging print-outs. No change in the effective code.
1 parent d11efbd commit 8122be0

9 files changed

Lines changed: 11 additions & 28 deletions

File tree

‎cirq-core/cirq/circuits/text_diagram_drawer_test.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -316,8 +316,6 @@ def test_drawer_stack() -> None:
316316

317317
d.force_vertical_padding_after(0, 0)
318318
with pytest.raises(ValueError):
319-
print(d.vertical_padding)
320-
print(dd.vertical_padding)
321319
TextDiagramDrawer.hstack((d, dd))
322320

323321
dd.force_vertical_padding_after(0, 0)

‎cirq-core/cirq/ops/clifford_gate_test.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -997,7 +997,6 @@ def test_cxswap_czswap() -> None:
997997

998998
# cirq unitary for CNOT then SWAP (big endian)
999999
cxswap_expected = np.asarray([[1, 0, 0, 0], [0, 0, 0, 1], [0, 1, 0, 0], [0, 0, 1, 0]])
1000-
print(cirq.unitary(cirq.CXSWAP))
10011000
assert np.allclose(cirq.unitary(cirq.CXSWAP), cxswap_expected)
10021001

10031002
czswap_expected = np.asarray([[1, 0, 0, 0], [0, 0, 1, 0], [0, 1, 0, 0], [0, 0, 0, -1]])

‎cirq-core/cirq/study/sweeps_test.py‎

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -324,17 +324,10 @@ def test_equality() -> None:
324324

325325

326326
def test_repr() -> None:
327+
cirq.testing.assert_equivalent_repr(cirq.study.sweeps.Product(cirq.UnitSweep))
328+
cirq.testing.assert_equivalent_repr(cirq.study.sweeps.Zip(cirq.UnitSweep))
327329
cirq.testing.assert_equivalent_repr(
328-
cirq.study.sweeps.Product(cirq.UnitSweep),
329-
setup_code='import cirq\nfrom collections import OrderedDict',
330-
)
331-
cirq.testing.assert_equivalent_repr(
332-
cirq.study.sweeps.Zip(cirq.UnitSweep),
333-
setup_code='import cirq\nfrom collections import OrderedDict',
334-
)
335-
cirq.testing.assert_equivalent_repr(
336-
cirq.ListSweep(cirq.Linspace('a', start=0, stop=3, length=4)),
337-
setup_code='import cirq\nfrom collections import OrderedDict',
330+
cirq.ListSweep(cirq.Linspace('a', start=0, stop=3, length=4))
338331
)
339332
cirq.testing.assert_equivalent_repr(cirq.Points('zero&pi', [0, 3.14159]))
340333
cirq.testing.assert_equivalent_repr(cirq.Linspace('I/10', 0, 1, 10))

‎cirq-google/cirq_google/devices/google_noise_properties_test.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,7 @@ def sample_noise_properties(
8080
def test_consistent_repr():
8181
q0, q1 = cirq.LineQubit.range(2)
8282
test_props = sample_noise_properties([q0, q1], [(q0, q1), (q1, q0)])
83-
cirq.testing.assert_equivalent_repr(
84-
test_props, setup_code="import cirq, cirq_google\nimport numpy as np"
85-
)
83+
cirq.testing.assert_equivalent_repr(test_props, setup_code="import cirq, cirq_google")
8684

8785

8886
def test_equals():

‎cirq-google/cirq_google/experimental/ops/coupler_pulse_test.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_consistent_protocols():
2727
)
2828
cirq.testing.assert_implements_consistent_protocols(
2929
gate,
30-
setup_code='import cirq\nimport numpy as np\nimport sympy\nimport cirq_google',
30+
setup_code='import cirq\nimport cirq_google',
3131
qubit_count=2,
3232
ignore_decompose_to_default_gateset=True,
3333
)

‎cirq-google/cirq_google/ops/no_sync_tag_test.py‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,22 +56,20 @@ def test_invalid_args() -> None:
5656
def test_str_repr() -> None:
5757
assert str(cirq_google.NoSyncTag()) == 'NoSyncTag()'
5858
assert repr(cirq_google.NoSyncTag()) == 'cirq_google.NoSyncTag()'
59-
cirq.testing.assert_equivalent_repr(
60-
cirq_google.NoSyncTag(), setup_code='import cirq\nimport cirq_google\n'
61-
)
59+
cirq.testing.assert_equivalent_repr(cirq_google.NoSyncTag(), setup_code='import cirq_google')
6260

6361
tag = cirq_google.NoSyncTag(reverse=2, forward=1)
6462
assert str(tag) == 'NoSyncTag(reverse=2, forward=1)'
6563
assert repr(tag) == 'cirq_google.NoSyncTag(reverse=2, forward=1)'
66-
cirq.testing.assert_equivalent_repr(tag, setup_code='import cirq\nimport cirq_google\n')
64+
cirq.testing.assert_equivalent_repr(tag, setup_code='import cirq_google')
6765

6866
tag_bool = cirq_google.NoSyncTag(remove_all_syncs_before=True, remove_all_syncs_after=True)
6967
assert str(tag_bool) == 'NoSyncTag(remove_all_syncs_before=True, remove_all_syncs_after=True)'
7068
assert (
7169
repr(tag_bool)
7270
== 'cirq_google.NoSyncTag(remove_all_syncs_before=True, remove_all_syncs_after=True)'
7371
)
74-
cirq.testing.assert_equivalent_repr(tag_bool, setup_code='import cirq\nimport cirq_google\n')
72+
cirq.testing.assert_equivalent_repr(tag_bool, setup_code='import cirq_google')
7573

7674

7775
def test_proto() -> None:

‎cirq-google/cirq_google/ops/sycamore_gate_test.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
def test_consistent_protocols(gate_type, qubit_count):
3333
cirq.testing.assert_implements_consistent_protocols(
3434
gate_type,
35-
setup_code='import cirq\nimport numpy as np\nimport sympy\nimport cirq_google',
35+
setup_code='import cirq\nimport sympy\nimport cirq_google',
3636
qubit_count=qubit_count,
3737
)
3838

‎cirq-google/cirq_google/ops/willow_gate_test.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222

2323
def test_consistent_protocols():
2424
cirq.testing.assert_implements_consistent_protocols(
25-
cg.WILLOW,
26-
setup_code='import cirq\nimport numpy as np\nimport sympy\nimport cirq_google',
27-
qubit_count=2,
25+
cg.WILLOW, setup_code='import cirq\nimport sympy\nimport cirq_google', qubit_count=2
2826
)
2927

3028

‎cirq-google/cirq_google/study/finite_random_variable_test.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,8 @@ def test_repr():
140140
sweep = cirq_google.study.FiniteRandomVariable(
141141
key=KEY, distribution=DIST, seed=SEED, length=LENGTH, metadata={'data': 1}
142142
)
143-
print(repr(sweep))
144143
# cirq.testing.assert_equivalent_repr evaluates the repr and checks equality
145-
cirq.testing.assert_equivalent_repr(sweep, setup_code='import sympy\nimport cirq_google')
144+
cirq.testing.assert_equivalent_repr(sweep, setup_code='import cirq_google')
146145

147146

148147
def test_json_serialization():

0 commit comments

Comments
 (0)