-
-
Notifications
You must be signed in to change notification settings - Fork 92
bug: some icons in the quickemu dark theme have incorrect contrast #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I just installed quickgui and went to enable dark mode (the correct mode), but found that the option is disabled. The reason was not completely clear until I found this issue and the associated commit. It may be better to remove the option rather than disabling it, to avoid similar confusion. (the best approach would be to improve the colours or whatever else is required here; and then to follow the system light/dark preference). |
I use QuickGUI regularly and was wondering why the dark mode switch wasn’t working. I saw this issue and would like to work on it. I'm new to open-source contributions—can I go ahead and fix this and open a PR? Let me know if there's anything specific I should keep in mind! |
P.S. the dark theme in quickemu cannot be deactivated, the button simply doesn't move. |
Fixed via #264 |
The colours for the dark theme need some improvements, so the active and inactive state is clearly communicated.
The text was updated successfully, but these errors were encountered: