Skip to content

bug: some icons in the quickemu dark theme have incorrect contrast #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flexiondotorg opened this issue Jun 27, 2024 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@flexiondotorg
Copy link
Member

The colours for the dark theme need some improvements, so the active and inactive state is clearly communicated.

@andypiper
Copy link

I just installed quickgui and went to enable dark mode (the correct mode), but found that the option is disabled. The reason was not completely clear until I found this issue and the associated commit. It may be better to remove the option rather than disabling it, to avoid similar confusion.

(the best approach would be to improve the colours or whatever else is required here; and then to follow the system light/dark preference).

@ivoheck
Copy link
Contributor

ivoheck commented Mar 24, 2025

I use QuickGUI regularly and was wondering why the dark mode switch wasn’t working. I saw this issue and would like to work on it. I'm new to open-source contributions—can I go ahead and fix this and open a PR? Let me know if there's anything specific I should keep in mind!

@boustanihani
Copy link

Same issue here, some icons are not visible at all. I'm using Gnome on Nix 24.11 (dark theme).

Image

@boustanihani
Copy link

P.S. the dark theme in quickemu cannot be deactivated, the button simply doesn't move.

@flexiondotorg
Copy link
Member Author

Fixed via #264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants