Rename retention to retention_ms

Author: gwaramadze

quixstreams/state/rocksdb/timestamped.py

@@ -42,7 +42,7 @@ def get_last(
         self,
         timestamp: int,
         prefix: Any,
-        retention: int = DAYS_7,
+        retention_ms: int = DAYS_7,
         cf_name: str = "default",
     ) -> Optional[Any]:
         """Get the latest value for a prefix up to a given timestamp.
@@ -56,7 +56,7 @@ def get_last(
 
         :param timestamp: The upper bound timestamp (inclusive) in milliseconds.
         :param prefix: The key prefix.
-        :param retention: The retention period in milliseconds.
+        :param retention_ms: The retention period in milliseconds.
         :param cf_name: The column family name.
         :return: The deserialized value if found, otherwise None.
         """
@@ -65,7 +65,7 @@ def get_last(
         prefix = self._ensure_bytes(prefix)
 
         # Negative retention is not allowed
-        lower_bound_timestamp = max(timestamp - retention, 0)
+        lower_bound_timestamp = max(timestamp - retention_ms, 0)
         lower_bound = self._serialize_key(lower_bound_timestamp, prefix)
         # +1 because upper bound is exclusive
         upper_bound = self._serialize_key(timestamp + 1, prefix)

tests/test_quixstreams/test_state/test_rocksdb/test_timestamped.py

@@ -117,8 +117,8 @@ def test_get_last_from_cache_with_retention(
     with transaction() as tx:
         tx.set(timestamp=5, value="value", prefix=b"key")
         assert tx.get_last(timestamp=10, prefix=b"key") == "value"
-        assert tx.get_last(timestamp=10, prefix=b"key", retention=5) == "value"
-        assert tx.get_last(timestamp=10, prefix=b"key", retention=4) == None
+        assert tx.get_last(timestamp=10, prefix=b"key", retention_ms=5) == "value"
+        assert tx.get_last(timestamp=10, prefix=b"key", retention_ms=4) == None
 
 
 def test_get_last_from_store_with_retention(
@@ -129,8 +129,8 @@ def test_get_last_from_store_with_retention(
 
     with transaction() as tx:
         assert tx.get_last(timestamp=10, prefix=b"key") == "value"
-        assert tx.get_last(timestamp=10, prefix=b"key", retention=5) == "value"
-        assert tx.get_last(timestamp=10, prefix=b"key", retention=4) == None
+        assert tx.get_last(timestamp=10, prefix=b"key", retention_ms=5) == "value"
+        assert tx.get_last(timestamp=10, prefix=b"key", retention_ms=4) == None
 
 
 @mock.patch("quixstreams.state.rocksdb.timestamped.EXPIRATION_COUNTER", 1000)
@@ -146,7 +146,7 @@ def test_get_last_from_cache_with_expire_call(
         # Expiration counter is exhausted for this `get_last` call
         # `_expire` method is called with `lower_bound_timestamp` = 10 - 4 = 6
         # Everything below timestamp 6 gets expired.
-        assert tx.get_last(timestamp=10, prefix=b"key", retention=4) == None
+        assert tx.get_last(timestamp=10, prefix=b"key", retention_ms=4) == None
         assert tx._update_cache.get_updates_for_prefix(prefix=b"key") == {}
 
 
@@ -166,7 +166,7 @@ def test_get_last_from_store_with_expire_call(
         # Expiration counter is exhausted for this `get_last` call
         # `_expire` method is called with `lower_bound_timestamp` = 10 - 4 = 6
         # Everything belowe timestamp 6 gets expired.
-        assert tx.get_last(timestamp=10, prefix=b"key", retention=4) == None
+        assert tx.get_last(timestamp=10, prefix=b"key", retention_ms=4) == None
         assert key in tx._update_cache.get_deletes()
 
     with transaction() as tx: