more thorough transformer testing

Author: lorenzwalthert

R/style-guides.R

@@ -178,7 +178,7 @@ tidyverse_style <- function(scope = "tokens",
       # remove_space_before_closing_paren = c("')'", "']'"),
       # remove_space_before_opening_paren = c("'('", "'['", "LBB"),
       add_space_after_for_if_while = c("IF", "WHILE", "FOR"),
-      add_space_before_brace = "'{'",
+      # remove_space_before_comma = "','",
       set_space_between_eq_sub_and_comma = "EQ_SUB",
       style_space_around_math_token = c(
         math_token_spacing$zero,
@@ -222,7 +222,7 @@ tidyverse_style <- function(scope = "tokens",
     )
   )
 
-  if (getRversion() >= 3.6) {
+  if (getRversion() < 3.6) {
     transformers_drop$token$force_assignment_op <- NULL
   }
 

tests/testthat/test-transformers-drop.R

@@ -45,6 +45,61 @@ test_that("transformers are removed if they are unused", {
   expect_equal(t_fun, t_manual)
 })
 
+test_that("tidyverse transformers are correctly dropped", {
+  t_style <- tidyverse_style()
+
+  t_fun <- transformers_drop(
+    "x", t_style
+  )
+  # test that all dropping rules match an actual rule in the style guide
+  scopes <- intersect(
+    names(t_fun$transformers_drop),
+    names(t_fun)
+  )
+  purrr::map2(t_fun$transformers_drop, t_style[scopes], function(x, y) {
+    # all x must be in y. select the x that are not in y
+    diff <- setdiff(names(x),names(y))
+    if (length(diff) > 0) {
+      rlang::abort(paste(
+        "transformer_dropping specifies exclusion rules for transformers that ",
+        "are not in the style guilde. Please add the rule to the style guide ",
+        "or remove the dropping rules:", paste(diff, collapse = ", "))
+      )
+    }
+  })
+  names_line_break <- c(
+    "set_line_break_around_comma_and_or",
+    "set_line_break_after_assignment",
+    "set_line_break_after_opening_if_call_is_multi_line",
+    "set_line_break_before_closing_call",
+    "remove_line_break_in_fun_call",
+    "set_linebreak_after_ggplot2_plus"
+  )
+  expect_setequal(names(t_fun$line_break), names_line_break)
+
+  names_spaces <- c(
+    "remove_space_before_closing_paren",
+    "remove_space_before_opening_paren",
+    "remove_space_before_comma",
+    "spacing_around_op",
+    "remove_space_after_opening_paren",
+    "set_space_between_levels"
+  )
+
+  expect_setequal(names(t_fun$space), names_spaces)
+
+  names_indention <- c("indent_braces", "indent_op", "indent_without_paren")
+  expect_setequal(names(t_fun$indention), names_indention)
+
+  names_tokens <- c(
+    "fix_quotes",
+    if (getRversion() < 3.6) "force_assignment_op",
+    "remove_terminal_token_before_and_after"
+  )
+  expect_setequal(names(t_fun$token), names_tokens)
+
+})
+
 
 test_that("if no transformers_drop is specified, no transformer is removed and no error issued", {
   t_fun <- transformers_drop(