Skip to content

Commit bd7fd1a

Browse files
committed
Remove approval block to run tests, lint, and annotations
These steps are designed so any code executed from the workspace happens inside an unprivileged docker container. We would get faster feedback on PRs if these run instantly.
1 parent 13b395c commit bd7fd1a

File tree

1 file changed

+28
-14
lines changed

1 file changed

+28
-14
lines changed

pipelines/buildkite-config/initial.yml

+28-14
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,6 @@
44
# This config is intended for running the rails/buildkite-config CI.
55

66
steps:
7-
- block: "Review Build Script"
8-
branches: "!main"
9-
prompt: |
10-
Our CI scripts run outside the docker containers, which are a necessary security layer.
11-
12-
Approving a build here is equivalent to copy & pasting it into a production ssh window.
13-
14-
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
15-
16-
- @matthewd
177
- group:
188
label: ":pipeline: buildkite-config meta-ci"
199
key: "meta"
@@ -92,7 +82,13 @@ steps:
9282
prompt: |
9383
Are you sure you want to trigger a build of Rails CI pipeline for the main branch with this config?
9484
95-
We have a finite number of CI resources, so we want to avoid unnecessary builds.
85+
Our CI scripts run outside the docker containers, which are a necessary security layer.
86+
87+
Approving a build here is equivalent to copy & pasting it into a production ssh window.
88+
89+
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
90+
91+
- @matthewd
9692
- trigger: "rails-ci"
9793
label: ":pipeline: Build Rails main with new config"
9894
depends_on: block-rails-ci-main
@@ -108,7 +104,13 @@ steps:
108104
prompt: |
109105
Are you sure you want to trigger a build of Rails CI pipeline for the stable branch with this config?
110106
111-
We have a finite number of CI resources, so we want to avoid unnecessary builds.
107+
Our CI scripts run outside the docker containers, which are a necessary security layer.
108+
109+
Approving a build here is equivalent to copy & pasting it into a production ssh window.
110+
111+
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
112+
113+
- @matthewd
112114
- trigger: "rails-ci"
113115
label: ":pipeline: Build Rails 6-1-stable with new config"
114116
depends_on: block-rails-ci-stable
@@ -124,7 +126,13 @@ steps:
124126
prompt: |
125127
Are you sure you want to trigger a build of Rails CI Nightly pipeline for the main branch with this config?
126128
127-
We have a finite number of CI resources, so we want to avoid unnecessary builds.
129+
Our CI scripts run outside the docker containers, which are a necessary security layer.
130+
131+
Approving a build here is equivalent to copy & pasting it into a production ssh window.
132+
133+
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
134+
135+
- @matthewd
128136
- trigger: "rails-ci-nightly"
129137
label: ":pipeline: Build Rails main with new nightly config"
130138
depends_on: block-rails-ci-nightly-main
@@ -140,7 +148,13 @@ steps:
140148
prompt: |
141149
Are you sure you want to trigger a build of Rails CI Nightly pipeline for the stable branch with this config?
142150
143-
We have a finite number of CI resources, so we want to avoid unnecessary builds.
151+
Our CI scripts run outside the docker containers, which are a necessary security layer.
152+
153+
Approving a build here is equivalent to copy & pasting it into a production ssh window.
154+
155+
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
156+
157+
- @matthewd
144158
- trigger: "rails-ci-nightly"
145159
label: ":pipeline: Build Rails 6-1-stable with new nightly config"
146160
depends_on: block-rails-ci-nightly-stable

0 commit comments

Comments
 (0)