Skip to content

Commit 094eb3a

Browse files
committedOct 25, 2024
Fix version check
1 parent 723b1eb commit 094eb3a

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed
 

‎lib/generators/release.rb

+3-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ def initialize(tag, basedir)
1414

1515
def before_generation
1616
if version_number == '4.2.10'
17+
log "rm Gemfile.lock"
1718
# There is a dependency on json that doesn't play well with the following downgrade.
1819
FileUtils.rm_f('Gemfile.lock')
1920

@@ -27,7 +28,8 @@ def before_generation
2728
# generated. See https://github.com/rails/rails/issues/29865.
2829
contents.sub(/^\s+name: Profiling Rails Applications[^-]+-\n/, '')
2930
end
30-
elsif Gem::Version.new(version_number) >= Gem::Version.new('6.1.7.9') && version_number < '7.0.0'
31+
elsif version_number >= '6.1.7.9' && version_number < '7.0.0'
32+
log "rm Gemfile.lock"
3133
# There is a dependency on nokogiri that doesn't play well with sqlite3
3234
FileUtils.rm_f('Gemfile.lock')
3335
elsif version_number >= '6.1.7.5' && version_number < '7.0.0'

‎test/version_number_test.rb

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ def test_diamond_with_string
2727
assert VersionNumber.new('4') < '4.0.0.1'
2828
assert VersionNumber.new('4.2') < '4.10'
2929
assert VersionNumber.new('4.2.1') < '4.2.2'
30+
assert VersionNumber.new('4.2.6.10') >= '4.2.6.9'
3031
end
3132

3233
def assert_version(expected_parts, version)

0 commit comments

Comments
 (0)