-
Notifications
You must be signed in to change notification settings - Fork 85
/
Copy pathsanitizer_test.rb
1288 lines (1059 loc) · 45.5 KB
/
sanitizer_test.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# frozen_string_literal: true
require "minitest/autorun"
require "rails-html-sanitizer"
puts "nokogiri version info: #{Nokogiri::VERSION_INFO}"
puts "html5 support: #{Rails::HTML::Sanitizer.html5_support?}"
#
# NOTE that many of these tests contain multiple acceptable results.
#
# In some cases, this is because of how the HTML4 parser's recovery behavior changed in libxml2
# 2.9.14 and 2.10.0. For more details, see:
#
# - https://github.com/sparklemotion/nokogiri/releases/tag/v1.13.5
# - https://gitlab.gnome.org/GNOME/libxml2/-/issues/380
#
# In other cases, multiple acceptable results are provided because Nokogiri's vendored libxml2 is
# patched to entity-escape server-side includes (aks "SSI", aka `<!-- #directive param=value -->`).
#
# In many other cases, it's because the parser used by Nokogiri on JRuby (xerces+nekohtml) parses
# slightly differently than libxml2 in edge cases.
#
module SanitizerTests
def self.loofah_html5_support?
Loofah.respond_to?(:html5_support?) && Loofah.html5_support?
end
class BaseSanitizerTest < Minitest::Test
class XpathRemovalTestSanitizer < Rails::HTML::Sanitizer
def sanitize(html, options = {})
fragment = Loofah.fragment(html)
remove_xpaths(fragment, options[:xpaths]).to_s
end
end
def test_sanitizer_sanitize_raises_not_implemented_error
assert_raises NotImplementedError do
Rails::HTML::Sanitizer.new.sanitize("asdf")
end
end
def test_remove_xpaths_removes_an_xpath
html = %(<h1>hello <script>code!</script></h1>)
assert_equal %(<h1>hello </h1>), xpath_sanitize(html, xpaths: %w(.//script))
end
def test_remove_xpaths_removes_all_occurrences_of_xpath
html = %(<section><header><script>code!</script></header><p>hello <script>code!</script></p></section>)
assert_equal %(<section><header></header><p>hello </p></section>), xpath_sanitize(html, xpaths: %w(.//script))
end
def test_remove_xpaths_called_with_faulty_xpath
assert_raises Nokogiri::XML::XPath::SyntaxError do
xpath_sanitize("<h1>hello<h1>", xpaths: %w(..faulty_xpath))
end
end
def test_remove_xpaths_called_with_xpath_string
assert_equal "", xpath_sanitize("<a></a>", xpaths: ".//a")
end
def test_remove_xpaths_called_with_enumerable_xpaths
assert_equal "", xpath_sanitize("<a><span></span></a>", xpaths: %w(.//a .//span))
end
protected
def xpath_sanitize(input, options = {})
XpathRemovalTestSanitizer.new.sanitize(input, options)
end
end
module ModuleUnderTest
def module_under_test
self.class.instance_variable_get(:@module_under_test)
end
end
module FullSanitizerTest
include ModuleUnderTest
def test_strip_tags_with_quote
input = '<" <img src="trollface.gif" onload="alert(1)"> hi'
result = full_sanitize(input)
acceptable_results = [
# libxml2 >= 2.9.14 and xerces+neko
%{<" hi},
# other libxml2
%{ hi},
]
assert_includes(acceptable_results, result)
end
def test_strip_invalid_html
assert_equal "<<", full_sanitize("<<<bad html")
end
def test_strip_nested_tags
expected = "Wei<a onclick='alert(document.cookie);'/>rdos"
input = "Wei<<a>a onclick='alert(document.cookie);'</a>/>rdos"
assert_equal expected, full_sanitize(input)
end
def test_strip_tags_multiline
expected = %{This is a test.\n\n\n\nIt no longer contains any HTML.\n}
input = %{<h1>This is <b>a <a href="" target="_blank">test</a></b>.</h1>\n\n<!-- it has a comment -->\n\n<p>It no <b>longer <strong>contains <em>any <strike>HTML</strike></em>.</strong></b></p>\n}
assert_equal expected, full_sanitize(input)
end
def test_remove_unclosed_tags
input = "This is <-- not\n a comment here."
result = full_sanitize(input)
acceptable_results = [
# libxml2 >= 2.9.14 and xerces+neko
%{This is <-- not\n a comment here.},
# other libxml2
%{This is },
]
assert_includes(acceptable_results, result)
end
def test_strip_cdata
input = "This has a <![CDATA[<section>]]> here."
result = full_sanitize(input)
acceptable_results = [
# libxml2 = 2.9.14
%{This has a <![CDATA[]]> here.},
# other libxml2
%{This has a ]]> here.},
# xerces+neko
%{This has a here.},
]
assert_includes(acceptable_results, result)
end
def test_strip_blank_string
assert_nil full_sanitize(nil)
assert_equal "", full_sanitize("")
assert_equal " ", full_sanitize(" ")
end
def test_strip_tags_with_plaintext
assert_equal "Don't touch me", full_sanitize("Don't touch me")
end
def test_strip_tags_with_tags
assert_equal "This is a test.", full_sanitize("<p>This <u>is<u> a <a href='test.html'><strong>test</strong></a>.</p>")
end
def test_escape_tags_with_many_open_quotes
assert_equal "<<", full_sanitize("<<<bad html>")
end
def test_strip_tags_with_sentence
assert_equal "This is a test.", full_sanitize("This is a test.")
end
def test_strip_tags_with_comment
assert_equal "This has a here.", full_sanitize("This has a <!-- comment --> here.")
end
def test_strip_tags_with_frozen_string
assert_equal "Frozen string with no tags", full_sanitize("Frozen string with no tags")
end
def test_full_sanitize_respect_html_escaping_of_the_given_string
assert_equal 'test\r\nstring', full_sanitize('test\r\nstring')
assert_equal "&", full_sanitize("&")
assert_equal "&", full_sanitize("&")
assert_equal "&amp;", full_sanitize("&amp;")
assert_equal "omg <script>BOM</script>", full_sanitize("omg <script>BOM</script>")
end
def test_sanitize_ascii_8bit_string
full_sanitize("<div><a>hello</a></div>".encode("ASCII-8BIT")).tap do |sanitized|
assert_equal "hello", sanitized
assert_equal Encoding::UTF_8, sanitized.encoding
end
end
protected
def full_sanitize(input, options = {})
module_under_test::FullSanitizer.new.sanitize(input, options)
end
end
class HTML4FullSanitizerTest < Minitest::Test
@module_under_test = Rails::HTML4
include FullSanitizerTest
end
class HTML5FullSanitizerTest < Minitest::Test
@module_under_test = Rails::HTML5
include FullSanitizerTest
end if loofah_html5_support?
module LinkSanitizerTest
include ModuleUnderTest
def test_strip_links_with_tags_in_tags
expected = "<a href='hello'>all <b>day</b> long</a>"
input = "<<a>a href='hello'>all <b>day</b> long<</A>/a>"
assert_equal expected, link_sanitize(input)
end
def test_strip_links_with_unclosed_tags
assert_equal "", link_sanitize("<a<a")
end
def test_strip_links_with_plaintext
assert_equal "Don't touch me", link_sanitize("Don't touch me")
end
def test_strip_links_with_line_feed_and_uppercase_tag
assert_equal "on my mind\nall day long", link_sanitize("<a href='almost'>on my mind</a>\n<A href='almost'>all day long</A>")
end
def test_strip_links_leaves_nonlink_tags
assert_equal "My mind\nall <b>day</b> long", link_sanitize("<a href='almost'>My mind</a>\n<A href='almost'>all <b>day</b> long</A>")
end
def test_strip_links_with_links
assert_equal "0wn3d", link_sanitize("<a href='http://www.rubyonrails.com/'><a href='http://www.rubyonrails.com/' onlclick='steal()'>0wn3d</a></a>")
end
def test_strip_links_with_linkception
assert_equal "Magic", link_sanitize("<a href='http://www.rubyonrails.com/'>Mag<a href='http://www.ruby-lang.org/'>ic")
end
def test_sanitize_ascii_8bit_string
link_sanitize("<div><a>hello</a></div>".encode("ASCII-8BIT")).tap do |sanitized|
assert_equal "<div>hello</div>", sanitized
assert_equal Encoding::UTF_8, sanitized.encoding
end
end
protected
def link_sanitize(input, options = {})
module_under_test::LinkSanitizer.new.sanitize(input, options)
end
end
class HTML4LinkSanitizerTest < Minitest::Test
@module_under_test = Rails::HTML4
include LinkSanitizerTest
end
class HTML5LinkSanitizerTest < Minitest::Test
@module_under_test = Rails::HTML5
include LinkSanitizerTest
end if loofah_html5_support?
module SafeListSanitizerTest
include ModuleUnderTest
def test_sanitize_nested_script
assert_equal '<script>alert("XSS");</script>', safe_list_sanitize('<script><script></script>alert("XSS");<script><</script>/</script><script>script></script>', tags: %w(em))
end
def test_sanitize_nested_script_in_style
input = '<style><script></style>alert("XSS");<style><</style>/</style><style>script></style>'
result = safe_list_sanitize(input, tags: %w(em))
acceptable_results = [
# libxml2
%{<script>alert("XSS");</script>},
# xerces+neko. unavoidable double-escaping, see loofah/docs/2022-10-decision-on-cdata-nodes.md
%{&lt;script&gt;alert(\"XSS\");&lt;&lt;/style&gt;/script&gt;},
]
assert_includes(acceptable_results, result)
end
def test_strip_unclosed_cdata
input = "This has an unclosed <![CDATA[<section>]] here..."
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2 = 2.9.14
%{This has an unclosed <![CDATA[]] here...},
# other libxml2
%{This has an unclosed ]] here...},
# xerces+neko
%{This has an unclosed }
]
assert_includes(acceptable_results, result)
end
def test_sanitize_form
assert_sanitized "<form action=\"/foo/bar\" method=\"post\"><input></form>", ""
end
def test_sanitize_plaintext
# note that the `plaintext` tag has been deprecated since HTML 2
# https://developer.mozilla.org/en-US/docs/Web/HTML/Element/plaintext
input = "<plaintext><span>foo</span></plaintext>"
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2
"<span>foo</span>",
# xerces+nekohtml-unit
"<span>foo</span></plaintext>",
# xerces+cyberneko
"<span>foo</span>"
]
assert_includes(acceptable_results, result)
end
def test_sanitize_script
assert_sanitized "a b c<script language=\"Javascript\">blah blah blah</script>d e f", "a b cblah blah blahd e f"
end
def test_sanitize_js_handlers
raw = %{onthis="do that" <a href="#" onclick="hello" name="foo" onbogus="remove me">hello</a>}
assert_sanitized raw, %{onthis="do that" <a href="#" name="foo">hello</a>}
end
def test_sanitize_javascript_href
raw = %{href="javascript:bang" <a href="javascript:bang" name="hello">foo</a>, <span href="javascript:bang">bar</span>}
assert_sanitized raw, %{href="javascript:bang" <a name="hello">foo</a>, <span>bar</span>}
end
def test_sanitize_image_src
raw = %{src="javascript:bang" <img src="javascript:bang" width="5">foo</img>, <span src="javascript:bang">bar</span>}
assert_sanitized raw, %{src="javascript:bang" <img width="5">foo, <span>bar</span>}
end
def test_should_allow_anchors
assert_sanitized %(<a href="foo" onclick="bar"><script>baz</script></a>), %(<a href=\"foo\">baz</a>)
end
def test_video_poster_sanitization
scope_allowed_tags(%w(video)) do
scope_allowed_attributes %w(src poster) do
expected = if RUBY_PLATFORM == "java"
# xerces+nekohtml alphabetizes the attributes! FML.
%(<video poster="posterimage.jpg" src="videofile.ogg"></video>)
else
%(<video src="videofile.ogg" poster="posterimage.jpg"></video>)
end
assert_sanitized(
%(<video src="videofile.ogg" autoplay poster="posterimage.jpg"></video>),
expected,
)
assert_sanitized(
%(<video src="videofile.ogg" poster=javascript:alert(1)></video>),
%(<video src="videofile.ogg"></video>),
)
end
end
end
# RFC 3986, sec 4.2
def test_allow_colons_in_path_component
assert_sanitized "<a href=\"./this:that\">foo</a>"
end
%w(src width height alt).each do |img_attr|
define_method "test_should_allow_image_#{img_attr}_attribute" do
assert_sanitized %(<img #{img_attr}="foo" onclick="bar" />), %(<img #{img_attr}="foo">)
end
end
def test_lang_and_xml_lang
# https://html.spec.whatwg.org/multipage/dom.html#the-lang-and-xml:lang-attributes
#
# 3.2.6.2 The lang and xml:lang attributes
#
# ... Authors must not use the lang attribute in the XML namespace on HTML elements in HTML
# documents. To ease migration to and from XML, authors may specify an attribute in no namespace
# with no prefix and with the literal localname "xml:lang" on HTML elements in HTML documents,
# but such attributes must only be specified if a lang attribute in no namespace is also
# specified, and both attributes must have the same value when compared in an ASCII
# case-insensitive manner.
input = expected = "<div lang=\"en\" xml:lang=\"en\">foo</div>"
assert_sanitized(input, expected)
end
def test_should_handle_non_html
assert_sanitized "abc"
end
def test_should_handle_blank_text
assert_nil(safe_list_sanitize(nil))
assert_equal("", safe_list_sanitize(""))
assert_equal(" ", safe_list_sanitize(" "))
end
def test_setting_allowed_tags_affects_sanitization
scope_allowed_tags %w(u) do |sanitizer|
assert_equal "<u></u>", sanitizer.sanitize("<a><u></u></a>")
end
end
def test_setting_allowed_attributes_affects_sanitization
scope_allowed_attributes %w(foo) do |sanitizer|
input = '<a foo="hello" bar="world"></a>'
assert_equal '<a foo="hello"></a>', sanitizer.sanitize(input)
end
end
def test_custom_tags_overrides_allowed_tags
scope_allowed_tags %(u) do |sanitizer|
input = "<a><u></u></a>"
assert_equal "<a></a>", sanitizer.sanitize(input, tags: %w(a))
end
end
def test_custom_attributes_overrides_allowed_attributes
scope_allowed_attributes %(foo) do |sanitizer|
input = '<a foo="hello" bar="world"></a>'
assert_equal '<a bar="world"></a>', sanitizer.sanitize(input, attributes: %w(bar))
end
end
def test_should_allow_prune
sanitizer = module_under_test::SafeListSanitizer.new(prune: true)
text = "<u>leave me <b>now</b></u>"
assert_equal "<u>leave me </u>", sanitizer.sanitize(text, tags: %w(u))
end
def test_should_allow_custom_tags
text = "<u>foo</u>"
assert_equal text, safe_list_sanitize(text, tags: %w(u))
end
def test_should_allow_only_custom_tags
text = "<u>foo</u> with <i>bar</i>"
assert_equal "<u>foo</u> with bar", safe_list_sanitize(text, tags: %w(u))
end
def test_should_allow_custom_tags_with_attributes
text = %(<blockquote cite="http://example.com/">foo</blockquote>)
assert_equal text, safe_list_sanitize(text)
end
def test_should_allow_custom_tags_with_custom_attributes
text = %(<blockquote foo="bar">Lorem ipsum</blockquote>)
assert_equal text, safe_list_sanitize(text, attributes: ["foo"])
end
def test_scrub_style_if_style_attribute_option_is_passed
input = '<p style="color: #000; background-image: url(http://www.ragingplatypus.com/i/cam-full.jpg);"></p>'
actual = safe_list_sanitize(input, attributes: %w(style))
assert_includes(['<p style="color: #000;"></p>', '<p style="color:#000;"></p>'], actual)
end
def test_should_raise_argument_error_if_tags_is_not_enumerable
assert_raises ArgumentError do
safe_list_sanitize("<a>some html</a>", tags: "foo")
end
end
def test_should_raise_argument_error_if_attributes_is_not_enumerable
assert_raises ArgumentError do
safe_list_sanitize("<a>some html</a>", attributes: "foo")
end
end
def test_should_not_accept_non_loofah_inheriting_scrubber
scrubber = Object.new
def scrubber.scrub(node); node.name = "h1"; end
assert_raises Loofah::ScrubberNotFound do
safe_list_sanitize("<a>some html</a>", scrubber: scrubber)
end
end
def test_should_accept_loofah_inheriting_scrubber
scrubber = Loofah::Scrubber.new
def scrubber.scrub(node); node.replace("<h1>#{node.inner_html}</h1>"); end
html = "<script>hello!</script>"
assert_equal "<h1>hello!</h1>", safe_list_sanitize(html, scrubber: scrubber)
end
def test_should_accept_loofah_scrubber_that_wraps_a_block
scrubber = Loofah::Scrubber.new { |node| node.replace("<h1>#{node.inner_html}</h1>") }
html = "<script>hello!</script>"
assert_equal "<h1>hello!</h1>", safe_list_sanitize(html, scrubber: scrubber)
end
def test_custom_scrubber_takes_precedence_over_other_options
scrubber = Loofah::Scrubber.new { |node| node.replace("<h1>#{node.inner_html}</h1>") }
html = "<script>hello!</script>"
assert_equal "<h1>hello!</h1>", safe_list_sanitize(html, scrubber: scrubber, tags: ["foo"])
end
def test_should_strip_src_attribute_in_img_with_bad_protocols
assert_sanitized %(<img src="javascript:bang" title="1">), %(<img title="1">)
end
def test_should_strip_href_attribute_in_a_with_bad_protocols
assert_sanitized %(<a href="javascript:bang" title="1">boo</a>), %(<a title="1">boo</a>)
end
def test_should_block_script_tag
assert_sanitized %(<SCRIPT\nSRC=http://ha.ckers.org/xss.js></SCRIPT>), ""
end
def test_should_not_fall_for_xss_image_hack_with_uppercase_tags
assert_sanitized %(<IMG """><SCRIPT>alert("XSS")</SCRIPT>">), %(<img>alert("XSS")">)
end
[%(<IMG SRC="javascript:alert('XSS');">),
%(<IMG SRC=javascript:alert('XSS')>),
%(<IMG SRC=JaVaScRiPt:alert('XSS')>),
%(<IMG SRC=javascript:alert("XSS")>),
%(<IMG SRC=javascript:alert(String.fromCharCode(88,83,83))>),
%(<IMG SRC=javascript:alert('XSS')>),
%(<IMG SRC=javascript:alert('XSS')>),
%(<IMG SRC=javascript:alert('XSS')>),
%(<IMG SRC="jav\tascript:alert('XSS');">),
%(<IMG SRC="jav	ascript:alert('XSS');">),
%(<IMG SRC="jav
ascript:alert('XSS');">),
%(<IMG SRC="jav
ascript:alert('XSS');">),
%(<IMG SRC="  javascript:alert('XSS');">),
%(<IMG SRC="javascript:alert('XSS');">),
%(<IMG SRC=`javascript:alert("RSnake says, 'XSS'")`>)].each do |img_hack|
define_method "test_should_not_fall_for_xss_image_hack_#{img_hack}" do
assert_sanitized img_hack, "<img>"
end
end
def test_should_sanitize_tag_broken_up_by_null
input = %(<SCR\0IPT>alert(\"XSS\")</SCR\0IPT>)
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2
"",
# xerces+neko
'alert("XSS")',
]
assert_includes(acceptable_results, result)
end
def test_should_sanitize_invalid_script_tag
assert_sanitized %(<SCRIPT/XSS SRC="http://ha.ckers.org/xss.js"></SCRIPT>), ""
end
def test_should_sanitize_script_tag_with_multiple_open_brackets
assert_sanitized %(<<SCRIPT>alert("XSS");//<</SCRIPT>), "<alert(\"XSS\");//<"
end
def test_should_sanitize_script_tag_with_multiple_open_brackets_2
input = %(<iframe src=http://ha.ckers.org/scriptlet.html\n<a)
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2
"",
# xerces+neko
"<a",
]
assert_includes(acceptable_results, result)
end
def test_should_sanitize_unclosed_script
assert_sanitized %(<SCRIPT SRC=http://ha.ckers.org/xss.js?<B>), ""
end
def test_should_sanitize_half_open_scripts
input = %(<IMG SRC="javascript:alert('XSS')")
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2
"<img>",
# libgumbo
"",
]
assert_includes(acceptable_results, result)
end
def test_should_not_fall_for_ridiculous_hack
img_hack = %(<IMG\nSRC\n=\n"\nj\na\nv\na\ns\nc\nr\ni\np\nt\n:\na\nl\ne\nr\nt\n(\n'\nX\nS\nS\n'\n)\n"\n>)
assert_sanitized img_hack, "<img>"
end
def test_should_sanitize_attributes
input = %(<SPAN title="'><script>alert()</script>">blah</SPAN>)
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2
%(<span title="'><script>alert()</script>">blah</span>),
# libgumbo
# this looks scary, but it's fine. for a more detailed analysis check out:
# https://github.com/discourse/discourse/pull/21522#issuecomment-1545697968
%(<span title="'><script>alert()</script>">blah</span>)
]
assert_includes(acceptable_results, result)
end
def test_should_sanitize_invalid_tag_names
assert_sanitized(%(a b c<script/XSS src="http://ha.ckers.org/xss.js"></script>d e f), "a b cd e f")
end
def test_should_sanitize_non_alpha_and_non_digit_characters_in_tags
assert_sanitized('<a onclick!#$%&()*~+-_.,:;?@[/|\]^`=alert("XSS")>foo</a>', "<a>foo</a>")
end
def test_should_sanitize_invalid_tag_names_in_single_tags
input = %(<img/src="http://ha.ckers.org/xss.js"/>)
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2
"<img>",
# libgumbo
%(<img src="http://ha.ckers.org/xss.js">),
]
assert_includes(acceptable_results, result)
end
def test_should_sanitize_img_dynsrc_lowsrc
assert_sanitized(%(<img lowsrc="javascript:alert('XSS')" />), "<img>")
end
def test_should_sanitize_img_vbscript
assert_sanitized %(<img src='vbscript:msgbox("XSS")' />), "<img>"
end
def test_should_sanitize_cdata_section
input = "<![CDATA[<span>section</span>]]>"
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2 = 2.9.14
%{<![CDATA[<span>section</span>]]>},
# other libxml2
%{section]]>},
# xerces+neko
"",
]
assert_includes(acceptable_results, result)
end
def test_should_sanitize_unterminated_cdata_section
input = "<![CDATA[<span>neverending..."
result = safe_list_sanitize(input)
acceptable_results = [
# libxml2 = 2.9.14
%{<![CDATA[<span>neverending...</span>},
# other libxml2
%{neverending...},
# xerces+neko
""
]
assert_includes(acceptable_results, result)
end
def test_should_not_mangle_urls_with_ampersand
assert_sanitized %{<a href=\"http://www.domain.com?var1=1&var2=2\">my link</a>}
end
def test_should_sanitize_neverending_attribute
# note that assert_dom_equal chokes in this case! so avoid using assert_sanitized
assert_equal("<span class=\"\\\"></span>", safe_list_sanitize("<span class=\"\\\">"))
end
[
%(<a href="javascript:alert('XSS');">),
%(<a href="javascript:alert('XSS');">),
%(<a href="javascript:alert('XSS');">),
%(<a href="javascript:alert('XSS');">)
].each_with_index do |enc_hack, i|
define_method "test_x03a_handling_#{i + 1}" do
assert_sanitized enc_hack, "<a></a>"
end
end
def test_x03a_legitimate
assert_sanitized %(<a href="http://legit">asdf</a>), %(<a href="http://legit">asdf</a>)
assert_sanitized %(<a href="http://legit">asdf</a>), %(<a href="http://legit">asdf</a>)
end
def test_sanitize_ascii_8bit_string
safe_list_sanitize("<div><a>hello</a></div>".encode("ASCII-8BIT")).tap do |sanitized|
assert_equal "<div><a>hello</a></div>", sanitized
assert_equal Encoding::UTF_8, sanitized.encoding
end
end
def test_sanitize_data_attributes
assert_sanitized %(<a href="/blah" data-method="post">foo</a>), %(<a href="/blah">foo</a>)
assert_sanitized %(<a data-remote="true" data-type="script" data-method="get" data-cross-domain="true" href="attack.js">Launch the missiles</a>), %(<a href="attack.js">Launch the missiles</a>)
end
def test_allow_data_attribute_if_requested
text = %(<a data-foo="foo">foo</a>)
assert_equal %(<a data-foo="foo">foo</a>), safe_list_sanitize(text, attributes: ["data-foo"])
end
# https://developer.mozilla.org/en-US/docs/Glossary/Void_element
VOID_ELEMENTS = %w[area base br col embed hr img input keygen link meta param source track wbr]
%w(strong em b i p code pre tt samp kbd var sub
sup dfn cite big small address hr br div span h1 h2 h3 h4 h5 h6 ul ol li dl dt dd abbr
acronym a img blockquote del ins time).each do |tag_name|
define_method "test_default_safelist_should_allow_#{tag_name}" do
if VOID_ELEMENTS.include?(tag_name)
assert_sanitized("<#{tag_name}>")
else
assert_sanitized("<#{tag_name}>foo</#{tag_name}>")
end
end
end
def test_datetime_attribute
assert_sanitized("<time datetime=\"2023-01-01\">Today</time>")
end
def test_abbr_attribute
scope_allowed_tags(%w(table tr th td)) do
assert_sanitized(%(<table><tr><td abbr="UK">United Kingdom</td></tr></table>))
end
end
def test_uri_escaping_of_href_attr_in_a_tag_in_safe_list_sanitizer
html = %{<a href='examp<!--" unsafeattr=foo()>-->le.com'>test</a>}
text = safe_list_sanitize(html)
acceptable_results = [
# nokogiri's vendored+patched libxml2 (0002-Update-entities-to-remove-handling-of-ssi.patch)
%{<a href="examp<!--%22%20unsafeattr=foo()>-->le.com">test</a>},
# system libxml2
%{<a href="examp<!--%22%20unsafeattr=foo()>-->le.com">test</a>},
# xerces+neko
%{<a href="examp<!--%22 unsafeattr=foo()>-->le.com">test</a>}
]
assert_includes(acceptable_results, text)
end
def test_uri_escaping_of_src_attr_in_a_tag_in_safe_list_sanitizer
html = %{<a src='examp<!--" unsafeattr=foo()>-->le.com'>test</a>}
text = safe_list_sanitize(html)
acceptable_results = [
# nokogiri's vendored+patched libxml2 (0002-Update-entities-to-remove-handling-of-ssi.patch)
%{<a src="examp<!--%22%20unsafeattr=foo()>-->le.com">test</a>},
# system libxml2
%{<a src="examp<!--%22%20unsafeattr=foo()>-->le.com">test</a>},
# xerces+neko
%{<a src="examp<!--%22 unsafeattr=foo()>-->le.com">test</a>}
]
assert_includes(acceptable_results, text)
end
def test_uri_escaping_of_name_attr_in_a_tag_in_safe_list_sanitizer
html = %{<a name='examp<!--" unsafeattr=foo()>-->le.com'>test</a>}
text = safe_list_sanitize(html)
acceptable_results = [
# nokogiri's vendored+patched libxml2 (0002-Update-entities-to-remove-handling-of-ssi.patch)
%{<a name="examp<!--%22%20unsafeattr=foo()>-->le.com">test</a>},
# system libxml2
%{<a name="examp<!--%22%20unsafeattr=foo()>-->le.com">test</a>},
# xerces+neko
%{<a name="examp<!--%22 unsafeattr=foo()>-->le.com">test</a>}
]
assert_includes(acceptable_results, text)
end
def test_uri_escaping_of_name_action_in_a_tag_in_safe_list_sanitizer
html = %{<a action='examp<!--" unsafeattr=foo()>-->le.com'>test</a>}
text = safe_list_sanitize(html, attributes: ["action"])
acceptable_results = [
# nokogiri's vendored+patched libxml2 (0002-Update-entities-to-remove-handling-of-ssi.patch)
%{<a action="examp<!--%22%20unsafeattr=foo()>-->le.com">test</a>},
# system libxml2
%{<a action="examp<!--%22%20unsafeattr=foo()>-->le.com">test</a>},
# xerces+neko
%{<a action="examp<!--%22 unsafeattr=foo()>-->le.com">test</a>},
]
assert_includes(acceptable_results, text)
end
def test_exclude_node_type_processing_instructions
input = "<div>text</div><?div content><b>text</b>"
result = safe_list_sanitize(input)
acceptable_results = [
# jruby cyberneko (nokogiri < 1.14.0)
"<div>text</div>",
# everything else
"<div>text</div><b>text</b>",
]
assert_includes(acceptable_results, result)
end
def test_exclude_node_type_comment
assert_equal("<div>text</div><b>text</b>", safe_list_sanitize("<div>text</div><!-- comment --><b>text</b>"))
end
%w[text/plain text/css image/png image/gif image/jpeg].each do |mediatype|
define_method "test_mediatype_#{mediatype}_allowed" do
input = %Q(<img src="data:#{mediatype};base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4=">)
expected = input
actual = safe_list_sanitize(input)
assert_equal(expected, actual)
input = %Q(<img src="DATA:#{mediatype};base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4=">)
expected = input
actual = safe_list_sanitize(input)
assert_equal(expected, actual)
end
end
def test_mediatype_text_html_disallowed
input = '<img src="data:text/html;base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4=">'
expected = "<img>"
actual = safe_list_sanitize(input)
assert_equal(expected, actual)
input = '<img src="DATA:text/html;base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4=">'
expected = "<img>"
actual = safe_list_sanitize(input)
assert_equal(expected, actual)
end
def test_mediatype_image_svg_xml_disallowed
input = '<img src="data:image/svg+xml;base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4=">'
expected = "<img>"
actual = safe_list_sanitize(input)
assert_equal(expected, actual)
input = '<img src="DATA:image/svg+xml;base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4=">'
expected = "<img>"
actual = safe_list_sanitize(input)
assert_equal(expected, actual)
end
def test_mediatype_other_disallowed
input = '<a href="data:foo;base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4=">foo</a>'
expected = "<a>foo</a>"
actual = safe_list_sanitize(input)
assert_equal(expected, actual)
input = '<a href="DATA:foo;base64,PHNjcmlwdD5hbGVydCgnWFNTJyk8L3NjcmlwdD4=">foo</a>'
expected = "<a>foo</a>"
actual = safe_list_sanitize(input)
assert_equal(expected, actual)
end
def test_scrubbing_svg_attr_values_that_allow_ref
input = '<div fill="yellow url(http://bad.com/) #fff">hey</div>'
expected = '<div fill="yellow #fff">hey</div>'
actual = scope_allowed_attributes %w(fill) do
safe_list_sanitize(input)
end
assert_equal(expected, actual)
end
def test_style_with_css_payload
input, tags = "<style>div > span { background: \"red\"; }</style>", ["style"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<style>div > span { background: \"red\"; }</style>",
# libgumbo
"<style>div > span { background: \"red\"; }</style>",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_select_and_style_with_css_payload
input, tags = "<select><style>div > span { background: \"red\"; }</style></select>", ["select", "style"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<select><style>div > span { background: \"red\"; }</style></select>",
# libgumbo
"<select>div > span { background: \"red\"; }</select>",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_select_and_style_with_script_payload
input, tags = "<select><style><script>alert(1)</script></style></select>", ["select", "style"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<select><style><script>alert(1)</script></style></select>",
# libgumbo
"<select>alert(1)</select>",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_svg_and_style_with_script_payload
input, tags = "<svg><style><script>alert(1)</script></style></svg>", ["svg", "style"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<svg><style><script>alert(1)</script></style></svg>",
# libgumbo
"<svg><style></style></svg>",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_math_and_style_with_img_payload
input, tags = "<math><style><img src=x onerror=alert(1)></style></math>", ["math", "style"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<math><style><img src=x onerror=alert(1)></style></math>",
# libgumbo
"<math><style></style></math>",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_math_and_style_with_img_payload_2
input, tags = "<math><style><img src=x onerror=alert(1)></style></math>", ["math", "style", "img"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<math><style><img src=x onerror=alert(1)></style></math>",
# libgumbo
"<math><style></style></math><img src=\"x\">",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_svg_and_style_with_img_payload
input, tags = "<svg><style><img src=x onerror=alert(1)></style></svg>", ["svg", "style"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<svg><style><img src=x onerror=alert(1)></style></svg>",
# libgumbo
"<svg><style></style></svg>",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_svg_and_style_with_img_payload_2
input, tags = "<svg><style><img src=x onerror=alert(1)></style></svg>", ["svg", "style", "img"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<svg><style><img src=x onerror=alert(1)></style></svg>",
# libgumbo
"<svg><style></style></svg><img src=\"x\">",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_svg_and_style_with_escaped_img_payload
# https://hackerone.com/reports/2503220
input, tags = "<svg><style><img src onerror=alert(1)>", ["svg", "style"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<svg><style>&lt;img src onerror=alert(1)></style></svg>",
# libgumbo
"<svg><style><img src onerror=alert(1)></style></svg>",
]
assert_includes(acceptable_results, actual)
end
def test_combination_of_math_and_style_with_escaped_img_payload
# https://hackerone.com/reports/2503220
input, tags = "<math><style><img src onerror=alert(1)>", ["math", "style"]
actual = safe_list_sanitize(input, tags: tags)
acceptable_results = [
# libxml2
"<math><style>&lt;img src onerror=alert(1)></style></math>",
# libgumbo