-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Expected to find a manifest file"...but I don't have any asset #448
Comments
How is your engine using sprockets? Without a manifest the engine should not be working with sprockets 4. |
https://github.com/sferik/rails_admin apparently it doesn't have one. does this mean the engine should lock onto |
It seems Rails admin is configuring sprcokets using the I'm torn about removing this check. If we remove, people upgrading to sprockets 4 will silently have their apps not compiling the assets they were expecting, but in case like yours, you really don't need a manifest. I wonder if it would be sufficient if we had a configuration to disable this check. |
(Preface: I use Sprockets in all of my Rails apps, and I greatly appreciate all the work that has gone into it.) I recently encountered two use cases for disabling this check.
|
I think a configuration to disable this check would be sufficient. |
That is not an minimal dummy Rails app. This is and would not have that problem ## test/test_helper.rb
require "rails"
require "active_model/railtie"
require "active_job/railtie"
require "action_controller/railtie"
require "action_view/railtie"
module Dummy
class Application < Rails::Application
config.root = File.join(__dir__, "dummy")
config.load_defaults Rails::VERSION::STRING.to_f
config.eager_load = false
end
end
Rails.application.initialize! |
@rafaelfranca are you going to add configuration to disable this check? If yes, could you please provide an issue number so I can follow when it's done. Thanks in advance |
Thanks for this suggestion! I had a similar problem (spec suite in gem which should not have a manifest.js file, but does set up a dummy rails app). Changing away from the full I think a config option might still make sense, but until then, this might help gem authors with dummy apps sort it out. |
I think #446 would fix this issue, since it allows to specify a custom path for the Dummy app manifest, as we would do in Solidus if it gets merged. |
Still no way to disable this? |
This fixed my issue. For an API only heroku app I removed all my assets and
|
This error is raised when the manifest file is not present. See also #444 .
Our use case is different: our app doesn't contain any sprockets assets, and uses webpacker to manage everything, but an engine that is mounted needs Sprockets. So basically:
Proposed solution: remove this check.
I am willing to hear alternative solution and/or open a PR to fix this.
The text was updated successfully, but these errors were encountered: