Rename from ActiveForm to ActionForm

As suggested by @dhh

> BTW, as far as "action" vs "active" goes, I'd like us to stick with this split: Action is for stuff that touches or talks to the user. Active is for internal.
> So imo, it should be ActionForm vs, say, ActiveModel

Author: claudiob

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_form (0.0.1)
+    actionform (0.0.1)
       rails (~> 4.1)
 
 GEM
@@ -74,7 +74,7 @@ GEM
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.2.2)
+    sprockets-rails (2.2.4)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (>= 2.8, < 4.0)
@@ -89,7 +89,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  active_form!
+  actionform!
   jquery-rails
   rake (~> 10.3.2)
   simple_form

README.md

@@ -1,23 +1,23 @@
-# Active Form
+# Action Form
 
 [![Build Status](https://api.travis-ci.org/rails/activeform.svg?branch=master)](https://travis-ci.org/rails/activeform)
 
-Set your models free from the `accepts_nested_attributes_for` helper. Active Form provides an object-oriented approach to represent your forms by building a form object, rather than relying on Active Record internals for doing this. Form objects provide an API to describe the models involved in the form, their attributes and validations. A form object deals with create/update actions of nested objects in a more seamless way.
+Set your models free from the `accepts_nested_attributes_for` helper. Action Form provides an object-oriented approach to represent your forms by building a form object, rather than relying on Active Record internals for doing this. Form objects provide an API to describe the models involved in the form, their attributes and validations. A form object deals with create/update actions of nested objects in a more seamless way.
 
 ## Installation
 
 Add this line to your `Gemfile`:
 
 ```ruby
-gem 'active_form'
+gem 'actionform'
 ```
 
 ## Defining Forms
 
 Consider an example where you want to create/update a conference that can have many speakers which can present a single presentation with one form submission. You start by defining a form to represent the root model, `Conference`:
 
 ```ruby
-class ConferenceForm < ActiveForm::Base
+class ConferenceForm < ActionForm::Base
   self.main_model = :conference
 
   attributes :name, :city
@@ -26,7 +26,7 @@ class ConferenceForm < ActiveForm::Base
 end
 ```
 
-Your form object has to subclass `ActiveForm::Base` in order to gain the necessary API. When defining the form, you have to specify the main_model the form represents with the following line:
+Your form object has to subclass `ActionForm::Base` in order to gain the necessary API. When defining the form, you have to specify the main_model the form represents with the following line:
 
 ```ruby
 self.main_model = :conference
@@ -35,14 +35,14 @@ self.main_model = :conference
 To add fields to the form, use the `attributes` or `attribute` class method. The form can also define validation rules for the model it represents. For the `presence` validation rule there is a short inline syntax:
 
 ```ruby
-class ConferenceForm < ActiveForm::Base
+class ConferenceForm < ActionForm::Base
   attributes :name, :city, required: true
 end
 ```
 
 ## The API
 
-The `ActiveForm::Base` class provides a simple API with only a few instance/class methods. Below are listed the instance methods:
+The `ActionForm::Base` class provides a simple API with only a few instance/class methods. Below are listed the instance methods:
 
 1. `initialize(model)` accepts an instance of the model that the form represents.
 2. `submit(params)` updates the main form's model and nested models with the posted parameters. The models are not saved/updated until you call `save`.
@@ -80,10 +80,10 @@ class ConferencesController
 end
 ```
 
-Active Form will read property values from the model in setup. Given the following form class.
+Action Form will read property values from the model in setup. Given the following form class.
 
 ```ruby
-class ConferenceForm < ActiveForm::Base
+class ConferenceForm < ActionForm::Base
   attribute :name
 end
 ```
@@ -101,7 +101,7 @@ Your `@conference_form` is now ready to be rendered, either do it yourself or us
 <% end %>
 ```
 
-Nested forms and collections can be easily rendered with `fields_for`, etc. Just use Active Form as if it would be an Active Model instance in the view layer.
+Nested forms and collections can be easily rendered with `fields_for`, etc. Just use Action Form as if it would be an Active Model instance in the view layer.
 
 ## Syncing Back
 
@@ -143,7 +143,7 @@ If the `save` method returns false due to validation errors defined on the form,
 
 ## Nesting Forms: 1-n Relations
 
-Active Form also gives you nested collections.
+Action Form also gives you nested collections.
 
 Let's define the `has_many :speakers` collection association on the `Conference` model.
 
@@ -157,7 +157,7 @@ end
 The form should look like this.
 
 ```ruby
-class ConferenceForm < ActiveForm::Base
+class ConferenceForm < ActionForm::Base
   attributes :name, :city, required: true
 
   association :speakers do
@@ -172,7 +172,7 @@ This basically works like a nested `property` that iterates over a collection of
 
 ### has_many: Rendering
 
-Active Form will expose the collection using the `speakers` method.
+Action Form will expose the collection using the `speakers` method.
 
 ```erb
 <%= form_for @conference_form |f| %>
@@ -201,7 +201,7 @@ end
 The full form should look like this:
 
 ```ruby
-class ConferenceForm < ActiveForm::Base
+class ConferenceForm < ActionForm::Base
   attributes :name, :city, required: true
 
   association :speakers do
@@ -237,12 +237,12 @@ Use `fields_for` in a Rails environment to correctly setup the structure of para
 
 ## Dynamically Adding/Removing Nested Objects
 
-Active Form comes with two helpers to deal with this functionality:
+Action Form comes with two helpers to deal with this functionality:
 
 1. `link_to_add_association` will display a link that renders fields to create a new object.
 2. `link_to_remove_association` will display a link to remove a existing/dynamic object.
 
-In order to use it you have to insert this line: `//= require active_form` to your `app/assets/javascript/application.js` file.
+In order to use it you have to insert this line: `//= require action_form` to your `app/assets/javascript/application.js` file.
 
 In our `ConferenceForm` we can dynamically create/remove `Speaker` objects. To do that we would write in the `app/views/conferences/_form.html.erb` partial:
 
@@ -324,7 +324,7 @@ And `app/views/conferences/_presentation_fields.html.erb` would be:
 
 ## Plain Old Ruby Object Forms
 
-ActiveForm also can accept `ActiveModel::Model` instances as a model.
+ActionForm also can accept `ActiveModel::Model` instances as a model.
 
 ```ruby
 class Feedback
@@ -341,7 +341,7 @@ end
 The form should look like this.
 
 ```ruby
-class FeedbackForm < ActiveForm::Base
+class FeedbackForm < ActionForm::Base
   attributes :name, :body, :email, required: true
 end
 ```

Rakefile

@@ -8,7 +8,7 @@ require 'rdoc/task'
 
 RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ActiveForm'
+  rdoc.title    = 'ActionForm'
   rdoc.options << '--line-numbers'
   rdoc.rdoc_files.include('README.rdoc')
   rdoc.rdoc_files.include('lib/**/*.rb')

active_form.gemspec renamed to actionform.gemspec

@@ -1,13 +1,13 @@
 $:.push File.expand_path('../lib', __FILE__)
 
-require 'active_form/version'
+require 'action_form/version'
 
 Gem::Specification.new do |s|
-  s.name        = 'active_form'
-  s.version     = ActiveForm::VERSION
+  s.name        = 'actionform'
+  s.version     = ActionForm::VERSION
   s.authors     = ['Petros Markou']
   s.email       = ['[email protected]']
-  s.homepage    = 'https://github.com/m-Peter/activeform'
+  s.homepage    = 'https://github.com/rails/actionform'
   s.summary     = 'Create nested forms with ease.'
   s.description = 'An alternative layer to accepts_nested_attributes_for by using Form Models.'
   s.license     = 'MIT'

app/assets/javascripts/active_form.js renamed to app/assets/javascripts/action_form.js

@@ -0,0 +1,17 @@
+module ActionForm
+  autoload :Base, 'action_form/base'
+  autoload :Form, 'action_form/form'
+  autoload :FormCollection, 'action_form/form_collection'
+  autoload :FormDefinition, 'action_form/form_definition'
+  autoload :TooManyRecords, 'action_form/too_many_records'
+  autoload :ViewHelpers, 'action_form/view_helpers'
+  autoload :FormHelpers, 'action_form/form_helpers'
+
+  class Engine < ::Rails::Engine
+    initializer "action_form.initialize" do |app|
+      ActiveSupport.on_load :action_view do
+        include ActionForm::ViewHelpers
+      end
+    end
+  end
+end

lib/action_form.rb

@@ -1,4 +1,4 @@
-module ActiveForm
+module ActionForm
   class Base
     include ActiveModel::Model
     include FormHelpers

lib/active_form/base.rb renamed to lib/action_form/base.rb

@@ -1,4 +1,4 @@
-module ActiveForm
+module ActionForm
   class Form
     include ActiveModel::Validations
     include FormHelpers

lib/active_form/form.rb renamed to lib/action_form/form.rb

@@ -1,4 +1,4 @@
-module ActiveForm
+module ActionForm
   class FormCollection
     include ActiveModel::Validations
 

lib/active_form/form_collection.rb renamed to lib/action_form/form_collection.rb

@@ -1,4 +1,4 @@
-module ActiveForm
+module ActionForm
   class FormDefinition
     attr_accessor :assoc_name, :proc, :parent, :records
 

lib/active_form/form_definition.rb renamed to lib/action_form/form_definition.rb

@@ -1,4 +1,4 @@
-module ActiveForm
+module ActionForm
   module FormHelpers
     ATTRIBUTES_KEY_REGEXP = /^(.+)_attributes$/
 

lib/active_form/form_helpers.rb renamed to lib/action_form/form_helpers.rb

@@ -1,4 +1,4 @@
-module ActiveForm
+module ActionForm
   class TooManyRecords < RuntimeError
   end
 end

lib/active_form/too_many_records.rb renamed to lib/action_form/too_many_records.rb

@@ -1,3 +1,3 @@
-module ActiveForm
+module ActionForm
   VERSION = "0.0.1"
 end

lib/active_form/version.rb renamed to lib/action_form/version.rb

@@ -1,4 +1,4 @@
-module ActiveForm
+module ActionForm
   module ViewHelpers
 
     def link_to_remove_association(name, f, html_options={})

lib/active_form/view_helpers.rb renamed to lib/action_form/view_helpers.rb

@@ -4,7 +4,7 @@
 module Rails
   module Generators # :nodoc:
     class FormGenerator < Rails::Generators::NamedBase # :nodoc:
-      desc 'This generator creates an active form file at app/forms'
+      desc 'This generator creates an action form file at app/forms'
 
       check_class_collision suffix: 'Form'
 

lib/active_form.rb

@@ -20,7 +20,7 @@ def create_forms_test_directory
       end
 
       def include_js_file
-        insert_into_file "app/assets/javascripts/application.js", "//= require active_form", :before => "//= require_tree ."
+        insert_into_file "app/assets/javascripts/application.js", "//= require action_form", :before => "//= require_tree ."
       end
     end
   end

lib/rails/generators/form/form_generator.rb

@@ -1,5 +1,5 @@
 <% module_namespacing do -%>
-class <%= class_name %>Form < ActiveForm::Base
+class <%= class_name %>Form < ActionForm::Base
 <%- if attributes.present? -%>
   attributes <%= attributes.map {|a| ":#{a.name}" }.join(", ") %>
 <%- else -%>

lib/rails/generators/form/form_install_generator.rb

@@ -1,4 +1,4 @@
 # desc "Explaining what the task does"
-# task :active_form do
+# task :action_form do
 #   # Task goes here
 # end

lib/rails/generators/form/templates/form.rb

@@ -0,0 +1,7 @@
+require 'test_helper'
+
+class ActionFormTest < ActiveSupport::TestCase
+  test "truth" do
+    assert_kind_of Module, ActionForm
+  end
+end

lib/tasks/active_form_tasks.rake renamed to lib/tasks/action_form_tasks.rake

@@ -12,5 +12,5 @@
 //
 //= require jquery
 //= require jquery_ujs
-//= require active_form
+//= require action_form
 //= require_tree .

test/action_form_test.rb

@@ -1,4 +1,4 @@
-class AssignmentForm < ActiveForm::Base
+class AssignmentForm < ActionForm::Base
   self.main_model = :assignment
 
   attribute :name, required: true

test/active_form_test.rb

@@ -1,4 +1,4 @@
-class ConferenceForm < ActiveForm::Base
+class ConferenceForm < ActionForm::Base
   attributes :name, :city, required: true
   attributes :photo
 

test/dummy/app/assets/javascripts/application.js

@@ -1,4 +1,4 @@
-class ProjectForm < ActiveForm::Base
+class ProjectForm < ActionForm::Base
   attributes :name, :description, :owner_id
 
   association :tasks do

test/dummy/app/forms/assignment_form.rb

@@ -1,4 +1,4 @@
-class SongForm < ActiveForm::Base
+class SongForm < ActionForm::Base
   attributes :title, :length, required: true
 
   association :artist do

test/dummy/app/forms/conference_form.rb

@@ -1,4 +1,4 @@
-class SurveyForm < ActiveForm::Base
+class SurveyForm < ActionForm::Base
   attribute :name, required: true
 
   association :questions do

test/dummy/app/forms/project_form.rb

@@ -1,4 +1,4 @@
-class UserForm < ActiveForm::Base
+class UserForm < ActionForm::Base
   self.main_model = :user
   attributes :name, :age, :gender, required: true
 

test/dummy/app/forms/song_form.rb

@@ -1,13 +1,13 @@
 <!DOCTYPE html>
 <html>
   <head>
-    <title>Active Form Demo (using Simple Form)</title>
+    <title>Action Form Demo (using Simple Form)</title>
     <%= stylesheet_link_tag    'application', media: 'all' %>
     <%= javascript_include_tag 'application' %>
     <%= csrf_meta_tags %>
   </head>
   <body>
-    <h1><%= link_to 'Active Form Demo', '#' %></h1>
+    <h1><%= link_to 'Action Form Demo', '#' %></h1>
 
     <div class="container">
       <%= yield %>

test/dummy/app/forms/survey_form.rb

@@ -3,7 +3,7 @@
 require 'rails/all'
 
 Bundler.require(*Rails.groups)
-require "active_form"
+require "action_form"
 
 module Dummy
   class Application < Rails::Application