Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation of delete option #10

Open
ScriptRaccoon opened this issue Nov 1, 2021 · 2 comments
Open

German translation of delete option #10

ScriptRaccoon opened this issue Nov 1, 2021 · 2 comments

Comments

@ScriptRaccoon
Copy link

I use the mobile app in German language. When I want to delete an item, it says "Verschieben an papierkorb". It should say "In den Papierkorb verschieben" or simply "Entfernen" (this is what it says in the Desktop version).
screenshot-delete

@ScriptRaccoon
Copy link
Author

I looked a bit into the code. I am afraid there is no easy fix without a completely different solution of the translations. The relevant line here is:

return _.capitalize(t.s('move'))+' '+t.s('to')+' '+t.s('defaultCollection--99').toLowerCase()

from remove.js. In English this composition of single words might work, but in many languages it does not. For example, in German it is "In den Papierkorb verschieben", so first the location, then the object, then the action. Now, in this case, it would help to translate "to" in German to "in den", but this does not fit then to the line

t.s('add') + ' ' + t.s('to') + ' ' + t.s('favorites').toLowerCase()

in actions.js, where it would become "Hinzufügen in den Favoriten" - it should be "Zu Favoriten hinzufügen".

There are many other places like this. For example, the line

removeTags: t.s('remove')+' '+t.s('tags').toLowerCase()

in working.js leads to the wrong translation "entfernen tags", it should "Tags entfernen".

It seems that the reduction of translations to single words does not work. We would need a translation key for every simple text in the app.

@herrherrmann
Copy link

It seems that the reduction of translations to single words does not work. We would need a translation key for every simple text in the app.

Yes, it would be great if the translation keys could be migrated to this methodology (i.e. using specific keys for full messages instead of splitting them by word). Otherwise, it’ll be impossible to properly translate the apps to German (and probably many other languages). It also doesn’t have to be a big bang migration – even a small transition key for key would be helpful and a step into the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants