Skip to content

Commit 16fc44a

Browse files
chore: Update RSDKUtils version to 5.1.0 for cocoaPod and SPM (RMCCX-8311)
1 parent 755280b commit 16fc44a

File tree

9 files changed

+37
-37
lines changed

9 files changed

+37
-37
lines changed

Package.resolved

+8-8
Original file line numberDiff line numberDiff line change
@@ -5,35 +5,35 @@
55
"kind" : "remoteSourceControl",
66
"location" : "https://github.com/mattgallagher/CwlCatchException.git",
77
"state" : {
8-
"revision" : "35f9e770f54ce62dd8526470f14c6e137cef3eea",
9-
"version" : "2.1.1"
8+
"revision" : "07b2ba21d361c223e25e3c1e924288742923f08c",
9+
"version" : "2.2.1"
1010
}
1111
},
1212
{
1313
"identity" : "cwlpreconditiontesting",
1414
"kind" : "remoteSourceControl",
1515
"location" : "https://github.com/mattgallagher/CwlPreconditionTesting.git",
1616
"state" : {
17-
"revision" : "c21f7bab5ca8eee0a9998bbd17ca1d0eb45d4688",
18-
"version" : "2.1.0"
17+
"revision" : "0139c665ebb45e6a9fbdb68aabfd7c39f3fe0071",
18+
"version" : "2.2.2"
1919
}
2020
},
2121
{
2222
"identity" : "ios-sdkutils",
2323
"kind" : "remoteSourceControl",
2424
"location" : "https://github.com/rakutentech/ios-sdkutils.git",
2525
"state" : {
26-
"revision" : "dedb314c2b8b5cfa2887fdbf7d0e18bf44c0cb26",
27-
"version" : "4.2.0"
26+
"revision" : "73792aaee286bbc0bede335513845deb2ffefbf7",
27+
"version" : "5.1.0"
2828
}
2929
},
3030
{
3131
"identity" : "nimble",
3232
"kind" : "remoteSourceControl",
3333
"location" : "https://github.com/Quick/Nimble.git",
3434
"state" : {
35-
"revision" : "c93f16c25af5770f0d3e6af27c9634640946b068",
36-
"version" : "9.2.1"
35+
"revision" : "831000dd1939bc2096df572c5fd156f41d858bfa",
36+
"version" : "12.1.0"
3737
}
3838
}
3939
],

Package.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ let package = Package(
1515
targets: ["RInAppMessaging"])
1616
],
1717
dependencies: [
18-
.package(url: "https://github.com/rakutentech/ios-sdkutils.git", .upToNextMajor(from: "4.2.0"))
18+
.package(url: "https://github.com/rakutentech/ios-sdkutils.git", .upToNextMajor(from: "5.1.0"))
1919
],
2020
targets: [
2121
.target(

Podfile

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use_frameworks!
2-
platform :ios, '12.0'
2+
platform :ios, '14.0'
33

44
secrets = ["RIAM_CONFIG_URL", "RIAM_APP_SUBSCRIPTION_KEY"]
55

@@ -8,12 +8,12 @@ project 'RInAppMessaging', 'UITests' => :debug
88
target 'RInAppMessaging_Example' do
99
pod 'RInAppMessaging', :path => '.'
1010
pod 'SwiftLint', '~> 0.50'
11-
pod 'RSDKUtils', '~> 4.2.0', :testspecs => ['Nimble', 'TestHelpers']
11+
pod 'RSDKUtils', '~> 5.1.0', :testspecs => ['Nimble', 'TestHelpers']
1212
pod 'Shock', '~> 6.1.2'
1313

1414
abstract_target 'Tests-Common' do
1515
pod 'Quick', '~> 5.0'
16-
pod 'Nimble'
16+
pod 'Nimble','~> 12.1.0'
1717

1818
target 'Tests'
1919

Podfile.lock

+17-17
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,19 @@ PODS:
66
- CNIOLinux (2.40.0)
77
- CNIOWindows (2.40.0)
88
- GRMustache.swift (4.0.1)
9-
- Nimble (10.0.0)
9+
- Nimble (12.1.0)
1010
- Quick (5.0.1)
1111
- RInAppMessaging (9.0.0):
12-
- RSDKUtils (~> 4.0)
13-
- RSDKUtils (4.2.0):
14-
- RSDKUtils/Main (= 4.2.0)
15-
- RSDKUtils/Main (4.2.0):
12+
- RSDKUtils (~> 5.1.0)
13+
- RSDKUtils (5.1.0):
14+
- RSDKUtils/Main (= 5.1.0)
15+
- RSDKUtils/Main (5.1.0):
1616
- RSDKUtils/RLogger
17-
- RSDKUtils/Nimble (4.2.0):
17+
- RSDKUtils/Nimble (5.1.0):
1818
- Nimble
1919
- RSDKUtils/Main
20-
- RSDKUtils/RLogger (4.2.0)
21-
- RSDKUtils/TestHelpers (4.2.0):
20+
- RSDKUtils/RLogger (5.1.0)
21+
- RSDKUtils/TestHelpers (5.1.0):
2222
- RSDKUtils/Main
2323
- Shock (6.1.3):
2424
- GRMustache.swift (~> 4.0.1)
@@ -68,12 +68,12 @@ PODS:
6868
- SwiftNIOCore (= 2.40.0)
6969

7070
DEPENDENCIES:
71-
- Nimble
71+
- Nimble (~> 12.1.0)
7272
- Quick (~> 5.0)
7373
- RInAppMessaging (from `.`)
74-
- RSDKUtils (~> 4.2.0)
75-
- RSDKUtils/Nimble (~> 4.2.0)
76-
- RSDKUtils/TestHelpers (~> 4.2.0)
74+
- RSDKUtils (~> 5.1.0)
75+
- RSDKUtils/Nimble (~> 5.1.0)
76+
- RSDKUtils/TestHelpers (~> 5.1.0)
7777
- Shock (~> 6.1.2)
7878
- SwiftLint (~> 0.50)
7979

@@ -110,10 +110,10 @@ SPEC CHECKSUMS:
110110
CNIOLinux: 62e3505f50de558c393dc2f273dde71dcce518da
111111
CNIOWindows: 3047f2d8165848a3936a0a755fee27c6b5ee479b
112112
GRMustache.swift: a6436504284b22b4b05daf5f46f77bd3fe00a9a2
113-
Nimble: 5316ef81a170ce87baf72dd961f22f89a602ff84
113+
Nimble: 7badc051fbff5e14e3798e2392b9389de67f75ea
114114
Quick: 749aa754fd1e7d984f2000fe051e18a3a9809179
115-
RInAppMessaging: e67e3d3db5792201041fcba320f981c40ed763ec
116-
RSDKUtils: 4ef7a283108a78e879f335c788d78bbd5699f907
115+
RInAppMessaging: 57adabd73a205a69e3ffd19daee4fe55fcea027c
116+
RSDKUtils: 6ae357662b44e390f026edd3431f57ad23fcaf97
117117
Shock: 34def30d5e729f6c1eea2a5b5c2d024b875af86c
118118
SwiftLint: 1cc5cd61ba9bacb2194e340aeb47a2a37fda00b3
119119
SwiftNIO: 829958aab300642625091f82fc2f49cb7cf4ef24
@@ -123,6 +123,6 @@ SPEC CHECKSUMS:
123123
SwiftNIOHTTP1: ef56706550a1dc135ea69d65215b9941e643c23b
124124
SwiftNIOPosix: b49af4bdbecaadfadd5c93dfe28594d6722b75e4
125125

126-
PODFILE CHECKSUM: d93126c6ae225ff9f7bcfc59f0e4ced878216e9b
126+
PODFILE CHECKSUM: 8c42d97c4f173f1dd3f1d8bf6600f2261b1abddc
127127

128-
COCOAPODS: 1.15.2
128+
COCOAPODS: 1.16.2

RInAppMessaging.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Pod::Spec.new do |s|
99
s.ios.deployment_target = '14.0'
1010
s.swift_versions = ['5.7.1']
1111
s.resources = ['Sources/RInAppMessaging/Resources/PrivacyInfo.xcprivacy']
12-
s.dependency 'RSDKUtils', '~> 4.0'
12+
s.dependency 'RSDKUtils', '~> 5.1.0'
1313
s.source_files = 'Sources/RInAppMessaging/**/*.swift'
1414
s.resource_bundles = { 'RInAppMessagingResources' => ['Sources/RInAppMessaging/Resources/*'] }
1515
end

SampleSPM/SampleSPM.xcodeproj/project.pbxproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -1530,15 +1530,15 @@
15301530
repositoryURL = "https://github.com/Quick/Nimble.git";
15311531
requirement = {
15321532
kind = upToNextMajorVersion;
1533-
minimumVersion = 9.0.0;
1533+
minimumVersion = 12.1.0;
15341534
};
15351535
};
15361536
45FA8FF3272C2C09005166FD /* XCRemoteSwiftPackageReference "ios-sdkutils" */ = {
15371537
isa = XCRemoteSwiftPackageReference;
15381538
repositoryURL = "https://github.com/rakutentech/ios-sdkutils.git";
15391539
requirement = {
15401540
kind = upToNextMajorVersion;
1541-
minimumVersion = 4.0.0;
1541+
minimumVersion = 5.1.0;
15421542
};
15431543
};
15441544
45FA9002272C2C5C005166FD /* XCRemoteSwiftPackageReference "Shock" */ = {

Sources/RInAppMessaging/Views/CarouselCell.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ final class CarouselCell: UICollectionViewCell {
5050

5151
func configure(with image: UIImage?, altText: String?, cellBgColor: UIColor) {
5252
let hasImage = (image != nil)
53-
backgroundColor = hasImage ? cellBgColor : .clear
53+
backgroundColor = hasImage ? cellBgColor : .white
5454
imageView.isHidden = !hasImage
5555
imageView.image = image
5656
textLabel.isHidden = hasImage

Sources/RInAppMessaging/Views/CarouselView.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ extension CarouselView: UICollectionViewDataSource, UICollectionViewDelegateFlow
8383
return UICollectionViewCell()
8484
}
8585

86-
collectionView.backgroundColor = (carouselData[indexPath.item].image != nil) ? carouselBgColor : .clear
86+
collectionView.backgroundColor = carouselBgColor
8787
cell.configure(with: carouselData[indexPath.item].image,
8888
altText: carouselData[indexPath.item].altText,
8989
cellBgColor: carouselBgColor)

Tests/Tests/CarouselCellSpec.swift

+3-3
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class CarouselCellSpec: QuickSpec {
5858
expect(cell.imageView.image).to(beNil())
5959
expect(cell.textLabel.isHidden).to(beFalse())
6060
expect(cell.textLabel.text).to(equal("Alt Text"))
61-
expect(cell.backgroundColor).to(equal(.clear))
61+
expect(cell.backgroundColor).to(equal(.white))
6262
}
6363
}
6464

@@ -68,7 +68,7 @@ class CarouselCellSpec: QuickSpec {
6868

6969
expect(cell.textLabel.text).to(equal(""))
7070
expect(cell.textLabel.isHidden).to(beFalse())
71-
expect(cell.backgroundColor).to(equal(.clear))
71+
expect(cell.backgroundColor).to(equal(.white))
7272
}
7373
}
7474

@@ -78,7 +78,7 @@ class CarouselCellSpec: QuickSpec {
7878

7979
expect(cell.textLabel.text).to(equal("carousel_image_load_error".localized))
8080
expect(cell.textLabel.isHidden).to(beFalse())
81-
expect(cell.backgroundColor).to(equal(.clear))
81+
expect(cell.backgroundColor).to(equal(.white))
8282
}
8383
}
8484

0 commit comments

Comments
 (0)