Skip to content

Commit 1e3b7b5

Browse files
committed
drm/vc4: plane: Ensure fetch_count is sufficient for hw in SAND mode
It has been observed that under some situations the HVS stalls totally when asked to apply a source crop to a P030/SAND128 image. Investigation showed that it was always when the start offset was on component 22 in the range 0-23. Increasing the fetch_count by 1 under these conditions fixes the problem, so implement that in the driver. Signed-off-by: Dave Stevenson <[email protected]>
1 parent 3262957 commit 1e3b7b5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/vc4/vc4_plane.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1943,7 +1943,7 @@ static int vc6_plane_mode_set(struct drm_plane *plane,
19431943

19441944
components_per_word = fb->format->format == DRM_FORMAT_P030 ? 24 : 32;
19451945
starting_offset = src_x % components_per_word;
1946-
fetch_count = (width + starting_offset + components_per_word - 1) /
1946+
fetch_count = (width + starting_offset + components_per_word) /
19471947
components_per_word;
19481948

19491949
/* Adjust the base pointer to the first pixel to be scanned

0 commit comments

Comments
 (0)