Skip to content

CI test linux://python/ray/tests:test_job is flaky #51738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
can-anyscale opened this issue Mar 27, 2025 · 20 comments · Fixed by #51765
Closed

CI test linux://python/ray/tests:test_job is flaky #51738

can-anyscale opened this issue Mar 27, 2025 · 20 comments · Fixed by #51765
Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases

Comments

@can-anyscale
Copy link
Collaborator

CI test linux://python/ray/tests:test_job is consistently_failing. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/9155#0195d534-485f-4665-ae08-54d07342ee34
- https://buildkite.com/ray-project/postmerge/builds/9155#0195d4eb-0746-4d88-acf2-2031f6adb822
- https://buildkite.com/ray-project/postmerge/builds/9143#0195d450-f32f-4248-b353-5df3b5e1ced5
- https://buildkite.com/ray-project/postmerge/builds/9143#0195d410-6d53-47c9-a686-535d956b8be9

DataCaseName-linux://python/ray/tests:test_job-END
Managed by OSS Test Policy
@can-anyscale can-anyscale added bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases labels Mar 27, 2025
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9160#0195d5fe-6e7b-4b8a-8f25-d24748b9804a

@can-anyscale can-anyscale changed the title CI test linux://python/ray/tests:test_job is consistently_failing CI test linux://python/ray/tests:test_job is flaky Mar 27, 2025
@can-anyscale can-anyscale reopened this Mar 27, 2025
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/tests:test_job is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/9155#0195d534-485f-4665-ae08-54d07342ee34
- https://buildkite.com/ray-project/postmerge/builds/9155#0195d4eb-0746-4d88-acf2-2031f6adb822
- https://buildkite.com/ray-project/postmerge/builds/9143#0195d450-f32f-4248-b353-5df3b5e1ced5
- https://buildkite.com/ray-project/postmerge/builds/9143#0195d410-6d53-47c9-a686-535d956b8be9

DataCaseName-linux://python/ray/tests:test_job-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9165#0195d85d-d0e6-48fc-ab5d-09db352c5f09

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9170#0195d93b-b994-409f-9ba9-47c5fe0820aa

@can-anyscale can-anyscale reopened this Mar 27, 2025
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/tests:test_job is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/9170#0195d93b-b998-4b11-bf55-5044f0a4e4e9
- https://buildkite.com/ray-project/postmerge/builds/9165#0195d89f-5e8e-4310-ac8f-34426a1e7edf
- https://buildkite.com/ray-project/postmerge/builds/9165#0195d85d-d0e4-4bdc-97fa-527b39bc2291
- https://buildkite.com/ray-project/postmerge/builds/9160#0195d653-4843-4b82-81a4-5008109b4ca3
- https://buildkite.com/ray-project/postmerge/builds/9160#0195d5fe-6e7d-4baf-878e-36cbd34f0843

DataCaseName-linux://python/ray/tests:test_job-END
Managed by OSS Test Policy

@kevin85421
Copy link
Member

I am on the issue.

@kevin85421 kevin85421 mentioned this issue Mar 28, 2025
Merged
8 tasks
@kevin85421
Copy link
Member

#51765 is out.

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9202#0195dee3-ef1b-4013-99de-2c2f2ee1fcf3

@can-anyscale can-anyscale reopened this Mar 28, 2025
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/tests:test_job is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/9170#0195d93b-b998-4b11-bf55-5044f0a4e4e9
- https://buildkite.com/ray-project/postmerge/builds/9165#0195d89f-5e8e-4310-ac8f-34426a1e7edf
- https://buildkite.com/ray-project/postmerge/builds/9165#0195d85d-d0e4-4bdc-97fa-527b39bc2291
- https://buildkite.com/ray-project/postmerge/builds/9160#0195d653-4843-4b82-81a4-5008109b4ca3
- https://buildkite.com/ray-project/postmerge/builds/9160#0195d5fe-6e7d-4baf-878e-36cbd34f0843

DataCaseName-linux://python/ray/tests:test_job-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9206#0195df38-9ca7-41cc-bda6-a30149b3e562

@can-anyscale can-anyscale reopened this Mar 29, 2025
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/tests:test_job is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/9202#0195dee3-ef1d-404a-a1c7-d7389a518ed5
- https://buildkite.com/ray-project/postmerge/builds/9170#0195d93b-b998-4b11-bf55-5044f0a4e4e9
- https://buildkite.com/ray-project/postmerge/builds/9165#0195d89f-5e8e-4310-ac8f-34426a1e7edf
- https://buildkite.com/ray-project/postmerge/builds/9165#0195d85d-d0e4-4bdc-97fa-527b39bc2291
- https://buildkite.com/ray-project/postmerge/builds/9160#0195d653-4843-4b82-81a4-5008109b4ca3

DataCaseName-linux://python/ray/tests:test_job-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9226#0195e04d-c999-4272-bce9-ca6812d66ef1

@can-anyscale can-anyscale reopened this Mar 29, 2025
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/tests:test_job is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/9206#0195df38-9ca9-4fe9-86ff-db7759e7004e
- https://buildkite.com/ray-project/postmerge/builds/9202#0195dee3-ef1d-404a-a1c7-d7389a518ed5
- https://buildkite.com/ray-project/postmerge/builds/9170#0195d93b-b998-4b11-bf55-5044f0a4e4e9
- https://buildkite.com/ray-project/postmerge/builds/9165#0195d89f-5e8e-4310-ac8f-34426a1e7edf
- https://buildkite.com/ray-project/postmerge/builds/9165#0195d85d-d0e4-4bdc-97fa-527b39bc2291

DataCaseName-linux://python/ray/tests:test_job-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9230#0195ea98-7448-4c19-8240-02a639fe0e20

@can-anyscale
Copy link
Collaborator Author

This test is now considered as flaky because it has been failing on postmerge for too long. Flaky tests do not run on premerge.

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9235#0195ecf6-9d71-41ee-8ace-7f17b2e92833

@can-anyscale can-anyscale reopened this Mar 31, 2025
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/tests:test_job is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/9235#0195ecf6-9d6c-4937-84eb-8063048219e9
- https://buildkite.com/ray-project/postmerge/builds/9230#0195eadb-5ddd-46fb-8258-1bcfc44b9f92
- https://buildkite.com/ray-project/postmerge/builds/9230#0195ea98-744c-4df6-b2fe-f08fcb0a58a9
- https://buildkite.com/ray-project/postmerge/builds/9226#0195e04d-c99b-4c90-95de-b5ab019bf01f
- https://buildkite.com/ray-project/postmerge/builds/9206#0195df38-9ca9-4fe9-86ff-db7759e7004e

DataCaseName-linux://python/ray/tests:test_job-END
Managed by OSS Test Policy

edoakes pushed a commit that referenced this issue Mar 31, 2025
@kevin85421
[core] Update sys.path to ensure that import lib works, thereby f…
6232621 
…ixing `test_job_isolation` (#51765)

This PR fixes #51738.

I found that `sys.path` is different when we run `test_job.py` with
`pytest` and `bazel test //python/ray/tests:test_job` in CI runners (at
least the one for Python 3.12).

For the bazel command, `tmpdir/v1` is not in `sys.path`, so `import lib`
fails.

---------

Signed-off-by: kaihsun <[email protected]>
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9240#0195ed85-c691-4dab-b567-3a18407d4f43

@can-anyscale can-anyscale reopened this Apr 1, 2025
@can-anyscale
Copy link
Collaborator Author

CI test linux://python/ray/tests:test_job is flaky. Recent failures:
- https://buildkite.com/ray-project/postmerge/builds/9254#0195eeb0-b1bc-4158-8e9c-7ba7450c0458
- https://buildkite.com/ray-project/postmerge/builds/9235#0195ecf6-9d6c-4937-84eb-8063048219e9
- https://buildkite.com/ray-project/postmerge/builds/9230#0195eadb-5ddd-46fb-8258-1bcfc44b9f92
- https://buildkite.com/ray-project/postmerge/builds/9230#0195ea98-744c-4df6-b2fe-f08fcb0a58a9
- https://buildkite.com/ray-project/postmerge/builds/9226#0195e04d-c99b-4c90-95de-b5ab019bf01f

DataCaseName-linux://python/ray/tests:test_job-END
Managed by OSS Test Policy

@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/postmerge/builds/9262#0195f26a-feb6-47b1-b8e3-d803f8735598

pavelkushtia pushed a commit to pavelkushtia/ray that referenced this issue Apr 6, 2025
@kevin85421
[core] Update sys.path to ensure that import lib works, thereby f…
1603910 
…ixing `test_job_isolation` (ray-project#51765)

This PR fixes ray-project#51738.

I found that `sys.path` is different when we run `test_job.py` with
`pytest` and `bazel test //python/ray/tests:test_job` in CI runners (at
least the one for Python 3.12).

For the bazel command, `tmpdir/v1` is not in `sys.path`, so `import lib`
fails.

---------

Signed-off-by: kaihsun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that is supposed to be working; but isn't ci-test core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ ray-test-bot Issues managed by OSS test policy stability triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases
Projects
None yet
Milestone
No milestone
2 participants
@kevin85421 @can-anyscale