Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ray Serve] request timeout sec for grpc #51761

Open
abrarsheikh opened this issue Mar 27, 2025 · 0 comments
Open

[Ray Serve] request timeout sec for grpc #51761

abrarsheikh opened this issue Mar 27, 2025 · 0 comments
Labels
enhancement Request for new feature and/or capability good-first-issue Great starter issue for someone just starting to contribute to Ray P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue

Comments

@abrarsheikh
Copy link
Contributor

Description

We don't have request_timeout_s for gRPC like we do for HTTP. Currently, gRPC relies on an environment variable for request timeouts. We should deprecate the environment variable and introduce a new attribute in the gRPC options schema to configure request timeouts explicitly.

Use case

No response
@abrarsheikh abrarsheikh added enhancement Request for new feature and/or capability good-first-issue Great starter issue for someone just starting to contribute to Ray triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 27, 2025
@abrarsheikh abrarsheikh mentioned this issue Mar 27, 2025
Merged
@jcotant1 jcotant1 added the serve Ray Serve Related Issue label Mar 29, 2025
@akshay-anyscale akshay-anyscale added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Apr 1, 2025
zcin pushed a commit that referenced this issue Apr 1, 2025
@abrarsheikh
fix status codes on http proxy (#51658)
6b6bbca 
this change aligns the status codes for timeouts/disconnect between
tracing and proxy logs

in the process of working on this PR, I realized that We don't have
request_timeout_s for gRPC like we do for HTTP. Currently, gRPC relies
on an environment variable for request timeouts. We should deprecate the
environment variable and introduce a new attribute in the gRPC options
schema to configure request timeouts explicitly.
#51761

---------

Signed-off-by: Abrar Sheikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request for new feature and/or capability good-first-issue Great starter issue for someone just starting to contribute to Ray P1 Issue that should be fixed within a few weeks serve Ray Serve Related Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abrarsheikh @akshay-anyscale @jcotant1